From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode Date: Tue, 02 Jun 2020 01:49:46 +0300 Organization: LINKOV.NET Message-ID: <87eeqys8ol.fsf@mail.linkov.net> References: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> <87zh9nn7os.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="107630"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Andrew Schwartzmeyer , 41633@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 02 01:04:26 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jftTm-000RuQ-GI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Jun 2020 01:04:26 +0200 Original-Received: from localhost ([::1]:41900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jftTl-00057u-HD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Jun 2020 19:04:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jftTP-00056y-71 for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 19:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53972) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jftTO-0008A9-2L for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 19:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jftTN-0004Hy-UZ for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 19:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Jun 2020 23:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41633 X-GNU-PR-Package: emacs Original-Received: via spool by 41633-submit@debbugs.gnu.org id=B41633.159105258316411 (code B ref 41633); Mon, 01 Jun 2020 23:04:01 +0000 Original-Received: (at 41633) by debbugs.gnu.org; 1 Jun 2020 23:03:03 +0000 Original-Received: from localhost ([127.0.0.1]:37283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jftSR-0004Gd-Bo for submit@debbugs.gnu.org; Mon, 01 Jun 2020 19:03:03 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:44011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jftSP-0004Fo-55 for 41633@debbugs.gnu.org; Mon, 01 Jun 2020 19:03:01 -0400 X-Originating-IP: 91.129.108.6 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 063751C0002; Mon, 1 Jun 2020 23:02:53 +0000 (UTC) In-Reply-To: <87zh9nn7os.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 31 May 2020 21:57:55 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181382 Archived-At: > Thanks for the report. I don't have anything to comment here > specifically, since I'm not familiar with the modes that you propose > patching, so let's wait for someone more knowledgeable with those modes. I don't know who is more knowledgeable since I just blindly copied that ugly ‘(eq read-buffer-function #'ido-read-buffer)’ from multi-occur to multi-isearch-read-buffers. Also I see that the patch that Andrew sent works fine in multi-isearch-files. > However, at first sight, it doesn't seem to be particularly off the > mark, except that a user might change that binding and break it. Maybe > a better, more generic fix would be ask the current minibuffer for the > answer, perhaps by searching the keymap for the keybinding that maps to > a command symbol that has a certain property set on it (and then > fido-mode and ido-mode would play ball). But maybe that's too > complex... Something like this is needed indeed, not too complicated. If it's not easy to just rephrase the prompt to avoid mentions of the key, then I suggest to display the string returned from (substitute-command-keys "(\\[exit-minibuffer] to end): ") called in the minibuffer.