From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer Date: Tue, 23 Jun 2020 02:38:39 +0300 Organization: LINKOV.NET Message-ID: <87eeq67k9k.fsf@mail.linkov.net> References: <87a70x8f7g.fsf@mail.linkov.net> <87wo40ghht.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="100602"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41974@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 23 02:16:40 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnWc9-000Q4S-CC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jun 2020 02:16:37 +0200 Original-Received: from localhost ([::1]:34928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnWc8-0007Y6-C3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Jun 2020 20:16:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnWbb-00075R-4Y for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnWba-00032o-QB for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnWba-00071g-Ll for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jun 2020 00:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41974 X-GNU-PR-Package: emacs Original-Received: via spool by 41974-submit@debbugs.gnu.org id=B41974.159287132826916 (code B ref 41974); Tue, 23 Jun 2020 00:16:02 +0000 Original-Received: (at 41974) by debbugs.gnu.org; 23 Jun 2020 00:15:28 +0000 Original-Received: from localhost ([127.0.0.1]:34950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWb1-000704-Tz for submit@debbugs.gnu.org; Mon, 22 Jun 2020 20:15:28 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:54041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWaz-0006zn-RX for 41974@debbugs.gnu.org; Mon, 22 Jun 2020 20:15:26 -0400 X-Originating-IP: 91.129.108.6 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AD54EFF804; Tue, 23 Jun 2020 00:15:18 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Mon, 22 Jun 2020 03:59:38 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182299 Archived-At: > How about this: > > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index 9b12d44978..6bb72d8976 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -1074,11 +1074,11 @@ vc-deduce-fileset > (progn ;FIXME: Why not > `with-current-buffer'? --Stef. > (set-buffer vc-parent-buffer) > (vc-deduce-fileset not-state-changing allow-unregistered > state-model-only-files))) > - ((and (derived-mode-p 'log-view-mode) > + ((and (not buffer-file-name) > (setq backend (vc-responsible-backend default-directory))) > (list backend nil)) Thanks for finding the right place to fix, and it should also fix all other vc commands that failed on non-file buffers. > ((not buffer-file-name) > - (error "Buffer %s is not associated with a file" (buffer-name))) > + (error "Buffer %s is not recognized by any VC backend" It seems this code is not necessary anymore because before this code gets executed, vc-responsible-backend already signals its error "No VC backend is responsible for file".