From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#40508: 26.2; shr does not make h1 tag larger if variable-pitch font is set Date: Wed, 29 Jul 2020 09:49:44 +0200 Message-ID: <87eeou221z.fsf@gnus.org> References: <87zh7ymd81.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22530"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40508@debbugs.gnu.org To: ndame Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 29 09:50:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0gqo-0005j9-6Z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jul 2020 09:50:10 +0200 Original-Received: from localhost ([::1]:55014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0gqn-0001qc-5G for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jul 2020 03:50:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0gqg-0001qP-Jy for bug-gnu-emacs@gnu.org; Wed, 29 Jul 2020 03:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k0gqg-0004ae-AY for bug-gnu-emacs@gnu.org; Wed, 29 Jul 2020 03:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k0gqg-0004tB-8D for bug-gnu-emacs@gnu.org; Wed, 29 Jul 2020 03:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Jul 2020 07:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40508 X-GNU-PR-Package: emacs Original-Received: via spool by 40508-submit@debbugs.gnu.org id=B40508.159600899918779 (code B ref 40508); Wed, 29 Jul 2020 07:50:02 +0000 Original-Received: (at 40508) by debbugs.gnu.org; 29 Jul 2020 07:49:59 +0000 Original-Received: from localhost ([127.0.0.1]:59956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0gqc-0004so-Tg for submit@debbugs.gnu.org; Wed, 29 Jul 2020 03:49:59 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:43028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0gqZ-0004sN-31 for 40508@debbugs.gnu.org; Wed, 29 Jul 2020 03:49:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hfHsxUSIN+6WS61OIo8HueUlCa4thxBbHJ94MmEoAnc=; b=DIeS6ip/XILNcFUQBMSUMmVdT6 eEvoKj6LDJG9HbG0jp+gIk9YL/w2KOX0pBD2LWFHvPZt8QUOHkvoJExlHlIpFUyuFaqDfp/Dl0ssr pX/i8b7U8u+TBKoLYep9OyHCjq4JOeL/T0DTqKIS5mq3M7XdvEisZqvDU6dEZAMUPw+Y=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0gqQ-0003q6-3F; Wed, 29 Jul 2020 09:49:48 +0200 In-Reply-To: <87zh7ymd81.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 17 Jul 2020 16:24:14 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183648 Archived-At: Lars Ingebrigtsen writes: >> This is because variable-pitch is listed first in the face setting and >> if it is set with size then it overrides the settings coming later: >> >> (defun shr-tag-h1 (dom) >> (shr-heading dom (if shr-use-fonts >> '(variable-pitch (:height 1.3 :weight bold)) >> 'bold))) > > Would reversing the order fix this problem? Untested patch below. Well, no, and the order isn't the problem at all -- it's that if you set the font that way in a face, it doesn't really matter what else you add to the spec afterwards, as far as I can see. If what you were trying to achieve was to make the face bigger, then you can increase the size by (for instance) 20% with this: (set-face-attribute 'variable-pitch nil :height 120) So this isn't an eww bug, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no