From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38294: [PATCH] Handle killing of virtual buffers in Ido Date: Sat, 15 Aug 2020 12:29:20 +0200 Message-ID: <87eeo819tr.fsf@gnus.org> References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> <87r1s9a3vb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , 38294@debbugs.gnu.org To: Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 15 12:30:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6tS0-000457-1g for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 12:30:12 +0200 Original-Received: from localhost ([::1]:38216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6tRz-000664-4J for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 06:30:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6tRq-00065y-RH for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 06:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6tRq-0007Qx-Hm for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 06:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6tRq-0004mu-EZ for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 06:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38294-submit@debbugs.gnu.org id=B38294.159748737618350 (code B ref 38294); Sat, 15 Aug 2020 10:30:02 +0000 Original-Received: (at 38294) by debbugs.gnu.org; 15 Aug 2020 10:29:36 +0000 Original-Received: from localhost ([127.0.0.1]:54300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tRQ-0004lt-Fd for submit@debbugs.gnu.org; Sat, 15 Aug 2020 06:29:36 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tRO-0004lf-Ja for 38294@debbugs.gnu.org; Sat, 15 Aug 2020 06:29:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=peVuY/rR9yyJksr2ew5suWp/gjpeSoXzpSe/puRAlJE=; b=Uja1ov7zqzCXNbLM9wboyEIQ0k OZZkJ6c98embcD9Mep6nSsTfDY1UetIF4SNgEZ/caJVN2W2CyDnFaGGxr8bvZhq0OIUA6bUA2lj4y eddUdzQ4B/L+z7POkry9VXhAo/jTN89h+mm+rZ30qzq4KZIwPiVQez4MaFFq2ioZOZco=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6tRC-0006ZJ-GV; Sat, 15 Aug 2020 12:29:28 +0200 In-Reply-To: (Dario Gjorgjevski's message of "Sat, 15 Aug 2020 10:03:02 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185208 Archived-At: Dario Gjorgjevski writes: > To me, both _not offering virtual buffers to be killed at all_ and > _offering them but treating killing as removing from =E2=80=98recentf-lis= t=E2=80=99_ > make sense. The latter I prefer simply for consistency with > =E2=80=98ido-kill-buffer-at-head=E2=80=99 (i.e., function that is called = when you press > =E2=80=98C-k=E2=80=99 on a buffer during =E2=80=98C-x b=E2=80=99). Yeah, I think you're right, and the original patch was the correct solution here: When the user explicitly (and interactively) kills a buffer, then they expect that buffer to go away. (There isn't any other reasonable interpretation for that interactive action.) It's perhaps slightly inconsistent, but I think it's more DWIM. So I'm applying your patch to Emacs 28, and we'll see if any users of this ido setting complains (in which case we should be prepared to revert it). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no