bug#42860: 28.0.50; Build on OpenBSD fails in jansson.h

bug#42860: 28.0.50; Build on OpenBSD fails in jansson.h

[Lars Ingebrigtsen]

This is on OpenBSD 6.6, with "pkg_add jansson", build from Emacs trunk now:

gmake[1]: Entering directory '/home/larsi/src/emacs/trunk/src'
  CC       json.o
In file included from json.c:27:
/usr/local/include/jansson.h: In function 'json_incref':
/usr/local/include/jansson.h:124: warning: implicit declaration of function '__atomic_add_fetch'
/usr/local/include/jansson.h:124: error: '__ATOMIC_ACQUIRE' undeclared (first use in this function)
/usr/local/include/jansson.h:124: error: (Each undeclared identifier is reported only once
/usr/local/include/jansson.h:124: error: for each function it appears in.)
/usr/local/include/jansson.h: In function 'json_decref':
/usr/local/include/jansson.h:134: warning: implicit declaration of function '__atomic_sub_fetch'
/usr/local/include/jansson.h:134: error: '__ATOMIC_RELEASE' undeclared (first use in this function)
gmake[1]: *** [Makefile:401: json.o] Error 1
gmake[1]: Leaving directory '/home/larsi/src/emacs/trunk/src'
gmake: *** [Makefile:424: src] Error 2
*** Error 2 in /home/larsi/src/emacs/trunk (makefile:4 'all')

I haven't investigated further -- I wonder whether it's immediately
obvious to Philipp what the problem is here.  :-)



In GNU Emacs 28.0.50 (build 11, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0)
 of 2020-08-13 built on xo
Repository revision: 1bed252ae9109493133a0cc3e9aad9e9a5ddde37
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Debian GNU/Linux bullseye/sid


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#42860: 28.0.50; Build on OpenBSD fails in jansson.h

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Fri, 14 Aug 2020 16:29:41 +0200
> Cc: Philipp Stephani <phst@google.com>
> 
> 
> This is on OpenBSD 6.6, with "pkg_add jansson", build from Emacs trunk now:
> 
> gmake[1]: Entering directory '/home/larsi/src/emacs/trunk/src'
>   CC       json.o
> In file included from json.c:27:
> /usr/local/include/jansson.h: In function 'json_incref':
> /usr/local/include/jansson.h:124: warning: implicit declaration of function '__atomic_add_fetch'
> /usr/local/include/jansson.h:124: error: '__ATOMIC_ACQUIRE' undeclared (first use in this function)
> /usr/local/include/jansson.h:124: error: (Each undeclared identifier is reported only once
> /usr/local/include/jansson.h:124: error: for each function it appears in.)
> /usr/local/include/jansson.h: In function 'json_decref':
> /usr/local/include/jansson.h:134: warning: implicit declaration of function '__atomic_sub_fetch'
> /usr/local/include/jansson.h:134: error: '__ATOMIC_RELEASE' undeclared (first use in this function)
> gmake[1]: *** [Makefile:401: json.o] Error 1
> gmake[1]: Leaving directory '/home/larsi/src/emacs/trunk/src'
> gmake: *** [Makefile:424: src] Error 2
> *** Error 2 in /home/larsi/src/emacs/trunk (makefile:4 'all')
> 
> I haven't investigated further -- I wonder whether it's immediately
> obvious to Philipp what the problem is here.  :-)

Too old GCC version?  What do you have there?

bug#42860: 28.0.50; Build on OpenBSD fails in jansson.h

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Too old GCC version?  What do you have there?

Let's see...  Oh, wow!

-bash-5.0$ gcc --version
gcc (GCC) 4.2.1 20070719 
Copyright (C) 2007 Free Software Foundation, Inc.

I guess the OpenBSD people like the good old classics?  This is with
OpenBSD 6.7 (I think I said 6.6 earlier), which was released this year...

(I just set up an OpenBSD VM to have a look at a couple of
OpenBSD-related bug reports; it's not something I usually use...)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#42860: 28.0.50; Build on OpenBSD fails in jansson.h

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 42860@debbugs.gnu.org,  phst@google.com
> Date: Fri, 14 Aug 2020 16:44:12 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Too old GCC version?  What do you have there?
> 
> Let's see...  Oh, wow!
> 
> -bash-5.0$ gcc --version
> gcc (GCC) 4.2.1 20070719 
> Copyright (C) 2007 Free Software Foundation, Inc.

Then you are probably better off configuring --without-json (assuming
the bugs you wanted to work on don't require native JSON support).

bug#42860: 28.0.50; Build on OpenBSD fails in jansson.h

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> Let's see...  Oh, wow!
>> 
>> -bash-5.0$ gcc --version
>> gcc (GCC) 4.2.1 20070719 
>> Copyright (C) 2007 Free Software Foundation, Inc.
>
> Then you are probably better off configuring --without-json (assuming
> the bugs you wanted to work on don't require native JSON support).

Probably...  but the jansson support is something that's people are
enthusiastic about, so it'd be nice if it worked on OpenBSD, too.

Perhaps Philipp has any ideas whether this would be difficult or not.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#42860: 28.0.50; Build on OpenBSD fails in jansson.h

[Eli Zaretskii]

> Date: Fri, 14 Aug 2020 17:40:26 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: phst@google.com, 42860@debbugs.gnu.org
> 
> Too old GCC version?  What do you have there?

Actually, as this is OpenBSD, maybe the compiler isn't GCC at all?

bug#42860: 28.0.50; Build on OpenBSD fails in jansson.h

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Actually, as this is OpenBSD, maybe the compiler isn't GCC at all?

It's gcc.  Googling a bit, it seems like they have both a newer version
of gcc in their "ports" collection, as well as clang.  But this is the
default "built-in" gcc version.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#42860: 28.0.50; Build on OpenBSD fails in jansson.h

[Lars Ingebrigtsen]

Hm...  I wonder whether this is an OpenBSD packaging issue.  The jansson
package brings in headers with this:

/* If __atomic builtins are available they will be used to manage
   reference counts of json_t. */
#define JSON_HAVE_ATOMIC_BUILTINS 1

But the pkg_add-ed gcc doesn't have those builtins, so when it loads the
jansson.h file, we get an error.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#42860: 28.0.50; Build on OpenBSD fails in jansson.h

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Hm...  I wonder whether this is an OpenBSD packaging issue. 

Aha!  Installing the "gcc" package doesn't install a compiler called
"gcc", but a compiler called "egcc".  Which we then have to use to
compile Emacs with if we're using libraries that are installed with
pkg_add.

Makes sense.  :-/

OK, closing this bug report...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no