From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [elpa] main 8f4cb59: * elpa-packages (counsel, ivy, swiper): Auto-sync. Date: Wed, 10 Mar 2021 12:40:56 +0000 Message-ID: <87eegn18rr.fsf@tcd.ie> References: <20210225102521.11653.64611@vcs0.savannah.gnu.org> <20210225102523.7CEF420B28@vcs0.savannah.gnu.org> <87h7m0z07r.fsf@tcd.ie> <87mtvsundg.fsf@tcd.ie> <875z20m0oa.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21746"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Oleh Krehel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 10 13:42:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJyAP-0005X3-KS for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Mar 2021 13:42:21 +0100 Original-Received: from localhost ([::1]:59370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJyAO-00056x-Ji for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Mar 2021 07:42:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJy9C-0004Cv-Oe for emacs-devel@gnu.org; Wed, 10 Mar 2021 07:41:08 -0500 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:38469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJy96-0004Rw-Oj for emacs-devel@gnu.org; Wed, 10 Mar 2021 07:41:05 -0500 Original-Received: by mail-wr1-x42f.google.com with SMTP id d15so23161719wrv.5 for ; Wed, 10 Mar 2021 04:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NKIgNvIqv0vQMmShaTvABXxxnYwCAY/jNGBurW7v6yQ=; b=W1qWoES1AS6Ki9FyNrww8Dowu9i5G6eQZKg9nLOdXoSF+GaTeb+2w+vHEw8HlI3GOU IfJ9LIEKqSj1+ogGvtbomJhAjGFj+rOcotbDd+bSjzUT3nK7HaBt91mIax69MZrfVHY0 ZtTKPWvgnYBrXlv6gp6hvqLSAvALjsxtdFFQKij7C491/Ysa5FuhLZUk3m72pK618PpC jObnASc1tLoHZyxloRZ6fGi3dnEJcsl+O6nLiQFZsQOiVQfw4dl8tZFQJMeZqLSJrmmn 8siiOH2QaHkX4mN2yEWo6lcT0YDGtHpZl50pHRNPL6w1O215WGGgYe1uSB14tozxxDBO 0qUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=NKIgNvIqv0vQMmShaTvABXxxnYwCAY/jNGBurW7v6yQ=; b=Khi3Gm2rjGfZdd2Q3u4qsDM0B/G2HyNPpKU7q3stCZkKbwQagXgdMG8/IhNY/GGqvY jI1eLuUUes2xvcz9KnGzP2gbtbGGIt/yYPy7GzX7SewFNfovdULffQI+KzWAUqoOFB22 V1W5qYGcal13j0C/9VGrvJn2Jnr/ty/J8s11pbwHjgrtkhlXiVq+44K7JeFRp53k/xQl gPthFJgM3VbvDugV7w9/4PzSnw71PKm215ehY9WsBbIX5inzo6EaDW5Cn3n7G8v5ckaX D4v/0kN3VZyW+TGjSmRMsLHDgWNZXb7B96YQD2GGWw+Kn0phw+Ad9jUusy+K242uSUb8 /yMg== X-Gm-Message-State: AOAM5337kz5tQRtcyIL3quCkrLUR/0iPIWZUk5Pr+5vDtycEeBLrIasM bqrEvDVzxaIFOcBz6BQzdwKRySF0LMZNOg== X-Google-Smtp-Source: ABdhPJzGX3/JnYh6ivo1tySwCW5TOB5Ktkiq1Cr9S8a0rUf/m+k+6KkCk39G5C/RguZqSwkIMJbcJg== X-Received: by 2002:a5d:4fcb:: with SMTP id h11mr3520670wrw.66.1615380058498; Wed, 10 Mar 2021 04:40:58 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id j136sm9821193wmj.35.2021.03.10.04.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 04:40:57 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Tue, 09 Mar 2021 18:56:23 -0500") Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266271 Archived-At: Stefan Monnier writes: > Suggestions: > > - change the versions after merging rather than before (as mentioned > above). It's an easy low-tech solution, but it involves N times more > work if a single .git upstream version leads to N downstream releases. O(2N) is still O(N) though, so not much worse than the status quo. I've gone with this for now so that the packages at least function properly. [Hopefully this is the last version bump this month...] > - if there's really only one version number shared by all the > sub-packages, I'd tend to argue that maybe there should only be one > package ;-) I tend to agree ;). Not my call to make, though, and that ship is either getting smaller or sailing away. > - as discussed earlier, we could have each subpackage have the complete > upstream Git and only create the subpackages via `elpa-package` > filtering out the other files. That would be nice to have in general, but it doesn't solve the inefficiency when multiple packages are bundled from the same repo. Unless, of course, we either stop caring about the inefficiency (run out of hair to pull?) or significantly complicate the Git dance, e.g.: https://stackoverflow.com/q/600079/3084001 > - split the upstream repository. Not my call to make. > - add some other way than :version-map to specify which commit to use. > This could be a new :version-first-parent boolean option, or maybe This would obviously "fix" part of my use-case, but I don't know how good a solution it is. > a "don't look for commit in history" (after all, that's what the old > GNU ELPA script used to do: it used whichever commit was > HEAD when we discovered that the `Version:` "had changed" (meaning > the version in HEAD corresponds to not-yet-built file)). The bump-after-merge works better for me personally, as I don't have to worry about when to push which commits (I just have to repeat the same dance 5 times, which at least is somewhat streamlined thanks to the Project and Magit packages). I guess another alternative to :version-map would be Git tags? E.g. using an N.N.N-elpa scheme or something like that. Thanks, -- Basil