From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47167: Multi-line comment-region with empty comment-continue Date: Thu, 18 Mar 2021 20:01:42 +0200 Organization: LINKOV.NET Message-ID: <87eegcmjcp.fsf@mail.linkov.net> References: <87a6r4muw5.fsf@mail.linkov.net> <878s6lt4xb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22067"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 47167@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 18 19:29:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMxOS-0005cT-3S for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 19:29:12 +0100 Original-Received: from localhost ([::1]:55694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMxOR-0002pL-1X for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 14:29:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMwz8-0001sa-Ph for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 14:03:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36451) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMwz8-0006BB-HB for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 14:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMwz8-000772-Cj for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 14:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Mar 2021 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47167-submit@debbugs.gnu.org id=B47167.161609053027259 (code B ref 47167); Thu, 18 Mar 2021 18:03:02 +0000 Original-Received: (at 47167) by debbugs.gnu.org; 18 Mar 2021 18:02:10 +0000 Original-Received: from localhost ([127.0.0.1]:47995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMwyI-00075a-Ik for submit@debbugs.gnu.org; Thu, 18 Mar 2021 14:02:10 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:54059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMwyG-00075H-Rh; Thu, 18 Mar 2021 14:02:09 -0400 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 586C9100002; Thu, 18 Mar 2021 18:02:00 +0000 (UTC) In-Reply-To: <878s6lt4xb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 18 Mar 2021 06:19:12 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202635 Archived-At: tags 47167 fixed close 47167 28.0.50 quit >> But currently it has no effect. So needed to fix newcomment.el. >> One possible fix is to return the original string from 'comment-padright' >> even when the string contains only whitespace. Maybe this would be >> the right fix, but still not sure about other calls of 'comment-padright'. >> So a safer fix would be to do this in the caller: > > Looks good to me. Now pushed to master.