From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48221: 28.0.50; defsubsts aren't native compiled? Date: Wed, 05 May 2021 11:36:02 +0200 Message-ID: <87eeel7cal.fsf@gnus.org> References: <87zgxa95vb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9789"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48221@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 11:37:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leDxv-0002Mj-R2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 11:37:11 +0200 Original-Received: from localhost ([::1]:35532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leDxu-0005p2-Ro for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 05:37:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leDxl-0005ng-VQ for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 05:37:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leDxl-0005JN-Nc for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 05:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leDxl-00075M-JA for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 05:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 09:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48221 X-GNU-PR-Package: emacs Original-Received: via spool by 48221-submit@debbugs.gnu.org id=B48221.162020737927215 (code B ref 48221); Wed, 05 May 2021 09:37:01 +0000 Original-Received: (at 48221) by debbugs.gnu.org; 5 May 2021 09:36:19 +0000 Original-Received: from localhost ([127.0.0.1]:59025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leDx5-00074t-32 for submit@debbugs.gnu.org; Wed, 05 May 2021 05:36:19 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leDx3-00074j-DT for 48221@debbugs.gnu.org; Wed, 05 May 2021 05:36:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wDrIzxbBHDhPzcyxu1T5JkEAmpnmNhUaRoR+x0yY6c4=; b=gkVxjYp1uk7gYtiVt1UQYMH9ig a7/oBjoQtk+0cPauReOMZUDeE4t/SHkhFzyhn/yb1T2Nxs4KJmZ9NfS4uU+uWEzrzoymFXatZlaBi EGmC4ejJ6MPlfOgGFYSOnjgaCOtpR2ProBBKW2SkODgpvnKV7LsHgkzVm0/F/0+k/HVo=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leDwr-00079m-EA; Wed, 05 May 2021 11:36:08 +0200 X-Now-Playing: Nico's _Fata Morgana_: "Your Voice" In-Reply-To: (Andrea Corallo's message of "Tue, 04 May 2021 16:03:34 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205674 Archived-At: Andrea Corallo writes: > AFAIR having the defsubst non native compiled is what we want as we need > the bytecode definition to have the inline to be performed. Actually > the test is verifying that the defsubst is *not* native compiled. > > I tried to reproduce here (0c993ed1d3) but for me the test is passing, > that's odd... Hm, odd. The two tests here are: ---- (ert-deftest help-fns-test-lisp-defun () (let ((regexp (if (boundp 'comp-ctxt) "a native compiled Lisp function in .+subr\\.el" "a compiled Lisp function in .+subr\\.el")) (result (help-fns-tests--describe-function 'last))) (should (string-match regexp result)))) (ert-deftest help-fns-test-lisp-defsubst () (let ((regexp (if (boundp 'comp-ctxt) "a native compiled Lisp function in .+subr\\.el" "a compiled Lisp function in .+subr\\.el")) (result (help-fns-tests--describe-function 'posn-window))) (should (string-match regexp result)))) ---- Unless I'm really misreading something here, they both seem to expect the native-compiled results? (A related question -- is (boundp 'comp-ctxt) really the best way to test for whether we have a native-compiled Emacs? That's just a defvar in comp-cstr.el...) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no