Hi Eli, Eli Zaretskii writes: > A couple of comments about the documentation parts below. I'll leave > the main part to other reviewers. >> +@item (cl-type @var{type}) >> +Matches if @var{expval} is of type @var{type}, which is a symbol or >> +list as accepted by @ref{cl-typep,,,cl,Common Lisp Extensions}. > > Please don't use @ref with this "HTML-style", it produces bad results > in Info. Instead, use a slightly more wordy > > ... as accepted by @code{cl-typep} (@pxref{cl-typep,,,cl,Common Lisp > Extensions}). Sure, I've changed it. >> +Example: @code{(cl-type integer)} >> +Example: @code{(cl-type (integer 0 10))} > > Examples should be in a @lisp..@end lisp block, and then you can drop > the @code markup, which is applied automatically. Ok, I've changed that two-line example to use "@lisp...@end lisp". I've left the one-line example in the second patch in the "Example: @code{...}" format, which matches all of the other single-line examples in control.texi. If you want me to change that one as well, let me know. >> +*** Added Pcase 'cl-type' pattern. > ^^^^^ > "pcase", without capitalization. The "Pcase" there was actually redundant, being present in the parent heading, so I've removed it. Please see the attached, updated patches. Thanks for your help.