From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Logan Perkins Newsgroups: gmane.emacs.bugs Subject: bug#39687: 26.3; Add customize-variable option for not locking keyboards Date: Wed, 21 Jul 2021 10:52:34 -0700 Message-ID: <87eebr3671.wl-logan@lp-programming.com> References: <3a518d18-cc99-195b-42a9-adc8ef764d67@lp-programming.com> <83mu9cjqml.fsf@gnu.org> <32ea14fb-1ab8-186e-2534-4d3d2a56d6d8@lp-programming.com> <83pne7hsyp.fsf@gnu.org> <6a23af03-d597-6e3e-ceb4-5fb1305a496a@lp-programming.com> <87bl6vpslj.fsf@gnus.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5612"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/27 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: 39687@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 21 19:54:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6GQ6-0001C6-98 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 19:54:10 +0200 Original-Received: from localhost ([::1]:48962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6GQ4-0005Bp-EP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 13:54:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6GPy-0005BR-I6 for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 13:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55199) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6GPy-0004Jd-AQ for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 13:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6GPy-00067l-0r for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 13:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Logan Perkins Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jul 2021 17:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39687 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39687-submit@debbugs.gnu.org id=B39687.162688998323471 (code B ref 39687); Wed, 21 Jul 2021 17:54:01 +0000 Original-Received: (at 39687) by debbugs.gnu.org; 21 Jul 2021 17:53:03 +0000 Original-Received: from localhost ([127.0.0.1]:38512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6GP0-00066U-Td for submit@debbugs.gnu.org; Wed, 21 Jul 2021 13:53:03 -0400 Original-Received: from [63.227.187.208] (port=59300 helo=gentoo-server) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6GOv-000662-P5 for 39687@debbugs.gnu.org; Wed, 21 Jul 2021 13:53:01 -0400 Original-Received: by gentoo-server.smtp.lp-programming.com from 127.0.0.1 with ESMTP ; Wed, 21 Jul 2021 10:52:36 -0700 In-Reply-To: <87bl6vpslj.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210468 Archived-At: On Wed, 21 Jul 2021 08:57:44 -0700, Lars Ingebrigtsen wrote: > > Logan Perkins writes: > > > I *think* I have a patch that still fixes the current behavior, and > > does not reintroduce those two bugs, I've included it below. > > Basically, the fix for Bug#5095 should only be applied if we are in > > the right context. If we're not, the if block above puts a > > Qswitch_frame at the head of the side queue and triggers > > replay_entire_sequence, so we just skip the second check. It'll get > > run again and catch the interruption on the next pass, but in the > > right context. > > I tried the various test cases, and the behaviour with your patch > clearly seems better to me, so I've applied it to Emacs 28. I assume you only applied the patch I supplied, which improves the fix for Bug#5095, but does not address Bug#39687. Hopefully, with that sorted, we can discuss the issues around `temporarily_switch_to_single_kboard`. > > But as Eli says, this is a ticklish area, so if this (re-)introduces > other bugs, we'll have to revert. Fair enough. I am fairly confident that patch won't cause problems (but it might allow latent problems to surface). This is, indeed, a tricky area: it took the better part of 2 hours last year to "wrap my head around" the issue well enough to write the patch. If any other issues arise, I'm happy to address those. > > This change was small enough to apply without assigning copyright to the > FSF, but for future patches you want to submit, it might make sense to > get the paperwork started now, so that subsequent patches can be applied > speedily. Would you be willing to sign such paperwork? I submitted my assignment paperwork 18 May 2020, signed via GPG. Mr. Topham responded (on 4 Jun 2020) that he was having difficulty verifying the signature (possibly due to it being an EDDSA key?), and that he would try again. I have heard nothing since, but did not follow up as this thread was stalled, and last summer was a bit... intense. I still have the assignment document and can submit it again if that would help. Regards, Logan