From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 1f24519 1/2: Allow storing SMTP variables when queueing mail Date: Thu, 12 Aug 2021 11:34:21 +0200 Message-ID: <87eeazqa5e.fsf@gmail.com> References: <20210723181832.28668.12066@vcs0.savannah.gnu.org> <20210723181834.5AE4C20D0A@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33853"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 12 11:51:58 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mE7NV-0008WF-HC for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Aug 2021 11:51:57 +0200 Original-Received: from localhost ([::1]:56154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mE7NT-0002IX-Vu for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Aug 2021 05:51:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mE76b-0006Mt-Ie for emacs-devel@gnu.org; Thu, 12 Aug 2021 05:34:29 -0400 Original-Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:38818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mE76W-00086R-N2 for emacs-devel@gnu.org; Thu, 12 Aug 2021 05:34:29 -0400 Original-Received: by mail-wm1-x335.google.com with SMTP id i10-20020a05600c354ab029025a0f317abfso6596507wmq.3 for ; Thu, 12 Aug 2021 02:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version; bh=TcIiylT5CvxgrNsxIDJEdiAjm0ikuraxINM4547y+1o=; b=BCxO5ft1YKjXnYBKPFn1w3IjbQRs/3d3N5Hjm6JYQQHhd+cdgtmyYYAkKO6HdilRko Mqr1kMPpL5i/WVwOahRYz+fFj7XmzoknVGRY20ibSwvpfg3PZpuVTnro1bHkbq2LwAhy ouUiQ1YwIqVpEoIvAvDIjF7PN9W4VnFjhkKnU5hx+VadooacdxZk69RG3oRE3s8FxTH4 LGep+GJZ23Zy+9wZbtUUILVvPgDPws3qE3mczuzmFgYqqn9Oo265nF2CE7EtWLu+eVN7 OwsS7NFwGA49VuoIV7R1iGOyv4KXerfz/vVNStW9uml53n3LEhWfykIt4zAaPLQsbefT YfGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=TcIiylT5CvxgrNsxIDJEdiAjm0ikuraxINM4547y+1o=; b=AiW0aZpdw7D4ML7LSGfUUkpLg8rllF+jr34UUmp1nMOE3XqAd5tU/DExd+w5XgWaAk m0R+Ad5c9vRTZkNYLVGityNs5l8pPr5SOi5O2VDOgZw8nBPK2Y0msds7lYixPJVqvar/ tKDoVvPooG2wK3wIK6hfJ1lID+5gi9TaKW77NRB+3R4Law8X6aamnQCKVETcc8QRGVC2 42xFaf5KRkVHWuk+twTaXZCYOtJPfF1INhljA/yHI+waMev7VYaUVwKHLmwqw79J4UAf Srfc3ahXGngbofiA2wXm0uZefLgtlYkR0RESSyr48O4v0Efp+/qQIw/gr1pdiYK8/xjT YmTg== X-Gm-Message-State: AOAM530D3SLlezfwhTqqRGcvUG0dTobp3IGABRyiTqMHbEmTDHnBmOcS yErsahQvNV/PxI2HKdqJeRY= X-Google-Smtp-Source: ABdhPJyaObFgHrR/sUig+msaP2YMbEkXy/b+gxKzE7J9jLMItg8iGFy3+OSxisaf9iOf0HPvDjeDuQ== X-Received: by 2002:a1c:98d5:: with SMTP id a204mr2074843wme.52.1628760862526; Thu, 12 Aug 2021 02:34:22 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id k186sm10514001wme.45.2021.08.12.02.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Aug 2021 02:34:22 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: <20210723181834.5AE4C20D0A@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Fri, 23 Jul 2021 14:18:34 -0400 (EDT)") Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=rpluim@gmail.com; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272348 Archived-At: >>>>> On Fri, 23 Jul 2021 14:18:34 -0400 (EDT), larsi@gnus.org (Lars Ingebrigtsen) said: Lars> (defun message-multi-smtp-send-mail () Lars> "Send the current buffer to `message-send-mail-function'. Lars> @@ -4937,7 +4938,8 @@ that instead." Lars> (message-send-mail-with-sendmail)) Lars> ((equal (car method) "smtp") Lars> (require 'smtpmail) Lars> - (let* ((smtpmail-smtp-server (nth 1 method)) Lars> + (let* ((smtpmail-store-queue-variables t) Lars> + (smtpmail-smtp-server (nth 1 method)) Lars> (service (nth 2 method)) Lars> (port (string-to-number service)) Lars> ;; If we're talking to the TLS SMTP port, then force a Why is smtpmail-store-queue-variables unconditionally bound to t here? The user might be queuing mail, but not want to store the variables, no? Robert --