From: Sean Whitton <spwhitton@spwhitton.name>
To: Michael Albinus <michael.albinus@gmx.de>, 46351@debbugs.gnu.org
Subject: bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining
Date: Sat, 25 Dec 2021 15:45:43 -0700 [thread overview]
Message-ID: <87ee601ey0.fsf@melete.silentflame.com> (raw)
In-Reply-To: <87czlkbxnh.fsf@gmx.de>
Hello Michael,
On Sat 25 Dec 2021 at 02:51PM +01, Michael Albinus wrote:
> Yep, the eshell history is there. However, it looks a little bit weird,
> when I have applied '|| cat .emacs | grep a'. The history shows me
> 'eshell-shell-command "cat .emacs | grep a"' instead. I understand
> what's meant, but is this convenient for an occasional eshell user?
Yeah. Actually, when I prepared the first version of this series, the
unexpanded version got stored in the history, so I think something has
changed about Eshell history recording in the past year.
> Thinking more about, perhaps we could solve it a little bit
> differently. Eshell knows how to invoke external commands explicitly, by
> prefixing the command with a star like '*ls'. What if we do it the same
> with pipes? That means, '*|' would mean to call an external pipe. So my
> command above would be 'cat .emacs *| grep a'. And an external pipe
> shall convert all other commands in that line into external commands as
> well, like '*cat .emacs *| *grep a'.
>
> By this you wouldn't need your restore-unexpanded-input patch any more, yes?
This is an intriguing suggestion. It would need to be implemented in
`eshell-parse-pipeline, rather than `eshell-expand-input-functions',
because parsing is required to determine which *| are unquoted, etc. We
also require *> and *< redirections, also in `eshell-parse-pipeline'.
So, I guess when A *| B is parsed, it would be rewritten to a single
call to `shell-file-name' in the way that `eshell-shell-command' does.
I am not sure how feasible it will be to implement that within the
existing structure of `eshell-parse-pipeline', but I can give it a try.
I have one unresolved design question. A disadvantage of your proposal
compared to mine is that it is much more laborious to convert an
existing pipeline to use the external shell: you have to replace each |
with *| and > with *>, etc., instead of just putting || at the
beginning.
I think it's important that it is easy to switch this feature on and
off, because it is often only after you start figuring out a pipeline
that you realise you ought to bypass Eshell's pipelining.
One option would be to add an entry to `eshell-expand-input-functions'
which converts all | to *| and > to *> when the input begins with ||.
But that is too simple, because you need to parse the input to know
which | to replace ... any ideas? I don't think it can be done inside
`eshell-parse-command'.
--
Sean Whitton
next prev parent reply other threads:[~2021-12-25 22:45 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 20:06 bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining Sean Whitton
2021-02-07 9:17 ` Michael Albinus
2021-02-07 19:01 ` Sean Whitton
2021-02-08 10:28 ` Michael Albinus
2021-02-08 18:07 ` Sean Whitton
2021-02-10 11:33 ` Michael Albinus
2021-12-24 21:20 ` Sean Whitton
2021-12-25 13:51 ` Michael Albinus
2021-12-25 22:45 ` Sean Whitton [this message]
2021-12-27 14:42 ` Michael Albinus
2021-12-27 18:13 ` Sean Whitton
2021-12-27 18:22 ` Eli Zaretskii
2021-12-27 19:21 ` Sean Whitton
2021-12-27 19:35 ` Eli Zaretskii
2021-12-27 19:53 ` Sean Whitton
2021-12-27 19:37 ` Michael Albinus
2021-12-27 19:54 ` Sean Whitton
2021-12-28 8:58 ` Michael Albinus
2022-01-18 5:19 ` Sean Whitton
2022-01-18 9:49 ` Robert Pluim
2022-01-18 18:27 ` Sean Whitton
2022-01-18 14:45 ` Eli Zaretskii
2022-01-18 18:40 ` Sean Whitton
2022-01-18 19:38 ` Eli Zaretskii
2022-01-18 23:16 ` Sean Whitton
2022-01-19 7:34 ` Eli Zaretskii
2022-01-19 20:39 ` Sean Whitton
2022-01-20 6:53 ` Eli Zaretskii
2022-01-20 22:16 ` Sean Whitton
2022-01-21 6:54 ` Eli Zaretskii
2022-01-22 0:16 ` Sean Whitton
2022-01-18 18:42 ` Sean Whitton
2022-01-19 15:52 ` Michael Albinus
2022-01-19 20:54 ` Sean Whitton
2022-01-20 18:41 ` Michael Albinus
2022-01-20 22:17 ` Sean Whitton
2022-01-23 22:39 ` Sean Whitton
2022-01-24 9:55 ` Lars Ingebrigtsen
2022-01-24 14:18 ` Michael Albinus
2022-01-24 20:32 ` Sean Whitton
2022-01-24 20:44 ` Sean Whitton
2022-01-24 20:48 ` Lars Ingebrigtsen
2022-01-24 21:42 ` Sean Whitton
2022-01-24 21:51 ` Lars Ingebrigtsen
2022-01-24 22:48 ` Sean Whitton
2022-01-24 20:46 ` Lars Ingebrigtsen
2022-01-25 2:39 ` Jim Porter
2022-01-25 5:33 ` bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols Sean Whitton
2022-01-25 8:50 ` Sean Whitton
2022-01-25 12:26 ` Lars Ingebrigtsen
2022-01-25 16:48 ` Sean Whitton
2022-01-26 5:38 ` Jim Porter
2022-01-26 13:13 ` Lars Ingebrigtsen
2022-01-25 18:14 ` Jim Porter
2022-01-25 20:01 ` Sean Whitton
2022-01-25 20:52 ` Jim Porter
2022-01-25 22:38 ` Sean Whitton
2022-01-25 8:54 ` bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining Michael Albinus
2022-01-25 18:22 ` Jim Porter
2021-12-27 18:26 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee601ey0.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=46351@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.