all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tomas Hlavaty <tom@logand.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: using finalizers
Date: Sat, 01 Jan 2022 18:58:01 +0100	[thread overview]
Message-ID: <87ee5rl4nq.fsf@logand.com> (raw)
In-Reply-To: <83ilv5gdsk.fsf@gnu.org>

On Fri 31 Dec 2021 at 14:27, Eli Zaretskii <eliz@gnu.org> wrote:
> That does happen, but you seem to expect more: you expect that the
> object is collected as soon as you do something in Lisp to break the
> binding between the object and the variable that was bound to it.

No, that's not what I expect.  I even said that.  What I meant is that I
did not expect some other code not under my control to keep references
to the object forever preventing gc to run the finalizer eventually,
which is how I understood your reply.  I know at least one Lisp which
does keeps extra unexpected references to particular kind of objects
preventing finalizers to run, so that kind of behaviour would not be
unheard of, but I see it as a bug and hope that Emacs does not have that
issue.

On another note, I see that finalizers are rarely used and tested:

./test/src/alloc-tests.el33:  (should (equal (type-of (make-finalizer nil)) 'finalizer)))
./lisp/emacs-lisp/generator.el642:                      (make-finalizer

For example the cps-generate-evaluator function has 70 lines and it is
not obvious to me, that the use of finalizer is not buggy.

Do you have an advice, how are programmers supposed to test finalizers?

My original issue did not run the finalizer because of a bug in my use
of letrec.  Unless there is a good way to actually trigger the
finalizer, there is no good way to test such code paths.  Or shall the
programmers just hope for the best?



  reply	other threads:[~2022-01-01 17:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-30 22:43 using finalizers Tomas Hlavaty
2021-12-31  2:46 ` LdBeth
2021-12-31  3:29   ` Stefan Monnier
2021-12-31  3:36     ` Stefan Monnier
2021-12-31  4:30     ` LdBeth
2021-12-31  4:43       ` LdBeth
2021-12-31  6:28   ` Tomas Hlavaty
2021-12-31 10:59     ` LdBeth
2021-12-31 11:18       ` Tomas Hlavaty
2021-12-31 11:41         ` LdBeth
2021-12-31 12:01           ` Tomas Hlavaty
2022-01-01 17:00     ` Stefan Monnier
2022-01-01 20:25       ` Tomas Hlavaty
2022-01-01 20:47         ` Stefan Monnier
2022-01-01 22:55           ` Tomas Hlavaty
2022-01-01 23:18             ` Stefan Monnier
2022-01-01 23:47               ` Tomas Hlavaty
2022-01-01 23:26             ` Tomas Hlavaty
2021-12-31  7:50   ` Eli Zaretskii
2021-12-31  9:31     ` Tomas Hlavaty
2021-12-31 12:27       ` Eli Zaretskii
2022-01-01 17:58         ` Tomas Hlavaty [this message]
2022-01-01 18:20           ` Eli Zaretskii
2022-01-01 20:55             ` Stefan Monnier
2022-01-01 23:05               ` Tomas Hlavaty
2022-01-01 23:21                 ` Stefan Monnier
2021-12-31 14:23       ` Rudolf Schlatte
2021-12-31 16:21         ` Stefan Monnier
2022-01-01 17:37           ` Tomas Hlavaty
2022-01-01 22:36         ` Tomas Hlavaty
2022-01-02  6:54           ` Eli Zaretskii
2022-01-02  7:53             ` Tomas Hlavaty
2022-01-02  8:33               ` Eli Zaretskii
2022-01-02 13:10                 ` Tomas Hlavaty
2022-01-02 14:42                   ` Eli Zaretskii
2022-01-02 15:16                     ` Eli Zaretskii
2022-01-02 17:18                       ` Tomas Hlavaty
2022-01-02 18:11           ` Rudolf Schlatte
2022-01-03  0:37             ` Tomas Hlavaty
2022-01-04  3:08               ` Richard Stallman
2021-12-31 14:39 ` LdBeth
2022-01-01 17:59   ` Tomas Hlavaty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee5rl4nq.fsf@logand.com \
    --to=tom@logand.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.