From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 02bca34: Utilize new string decoding feature in GTK native input Date: Sat, 19 Feb 2022 20:49:58 +0800 Message-ID: <87ee3zm361.fsf@yahoo.com> References: <83czjjyzao.fsf@gnu.org> <87y227mal9.fsf@yahoo.com> <838ru7yqw4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8581"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 19 14:13:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLPYC-00028M-81 for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Feb 2022 14:13:24 +0100 Original-Received: from localhost ([::1]:32952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLPYB-0007Im-86 for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Feb 2022 08:13:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLPMP-0000tR-S7 for emacs-devel@gnu.org; Sat, 19 Feb 2022 08:01:13 -0500 Original-Received: from sonic308-56.consmr.mail.ne1.yahoo.com ([66.163.187.31]:37449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nLPLT-0000m6-49 for emacs-devel@gnu.org; Sat, 19 Feb 2022 08:01:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1645275608; bh=hQKYrzSW8vWiabje3uY2VANonCJ6/FKjUSBTpVyet0A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=NrBCxDjBBVx3nJ+wvurXuyKIdzUQWNaFsgZok/LfhRGSgASu2sllZ2s2tNaq9Knrrh8UMeV8NyVmacjCjQouKlKmKmCrWWT3u+BkhYwB6GGVcR/CVHlYrguujfsbfZ0i4BEKcfPNpLdyHs8pLk7aAm3Bj0Q6AqdEMkerReB+wZlc6JKm/mAdjjoMWPHxJesZTOms1swMZk0NZAv62VGvRoTmBT3tfhsd77fvxpV6ywYNzG0RnpxkElbvaNoEjQIO8LVlKNyEea9xB0k0hFRio6xqps5+z5bDEALccIdoXWaordYgYvZ2V47aqCaSCiK4uAHkh7tOFGD3te6hW1weeg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1645275608; bh=7KD7eUtEVW0ZPrdXCk28OtmrjAyidh/PdISW5OR9HP2=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=F0qFgnqvfBFRNyEzGPDrNnSv2fY//3NadNXNW6bWiIr92vSn8CDqtLCST/wMZIdRc03tkiK2Z0ZPYh1DnS5c7ApPuIdvWqoscob7Sg/3bHFjhOoyqmk3VqKipp4uiXudrAZMorRd8Mz4n5WuShcVteWnzYbn8iK7XJEpY3FTEfI0XATpZ/xvykx3cH8VW1j/WCJ/hgXxt3SXBtM3MisbUD2sgEiDovSnWwofFODr5qgbRKrsZv1xgnj36vfg5CbZ4aqmfaZ+uqfrg3c7XlC+dPb3CH8WzaXUBhOJnUB3eE3kXfC6n5mv8hMvBZWn4vX76dRqrKoxtTDW8A7vHUevWQ== X-YMail-OSG: GtCLxyQVM1mA4oJ5LaklRE0dU.HC2.dY3lCr6uTgSejfOq4PaspGnitqQxlxwQx Bt26WpQF7LPQlJJFGjgg_pkW2ewebASggcwAsOjUs8UWSvpnYQOX0MLNPPmXR0bht5hFKeXCOWHx NLWMr.ujQr9wGFAXsE5AWx4HqYqzgHpenSW.AOdv9MH.lcNe4CJ_dGi16pcnBC82IXPVhsqHMwZw fs9psNWJBVG6c6BgLVycp5H8MSsOaXu52ysuNbxejrzHNHwtHiNvI7tDzvl5X6kgrTu9Uj5pO01T bF4AxPaBxEXNf9C1cQU_sAwZBXoPGjD153bu.yfIwBpDMjFldct5dY7rp3dYr5kMkOmkxVSSexHA .mOslgAJ_w88nBcuXpE.yfSfjTQNrIUAS6Xh2J.RxR4mp3TCaFwnQN5JYY5ZJpapaFYWMZ2Uh2L2 IaBVyvNXg1jdkTvhi6vDYDoAygX4jlQSB4an2LCGlfT1uVWrN82zEvwKPc2n6QzAZ1lW6cqZZu4. thD11TA.hvgyyauMyfWQsbOt4OHobZFQnXLg1fH17LIj77oqYEPLe4iU8bhuV6SGYUZvtrFev6oe 2Xa7sBrdDJCzEFMntvL.Ool.b_ZKJa_UwQbpbVcacPqWUQSC5wAiO_HYF0RuwNBuukgf2pB.GVWS Mss5Fc1Jwf1FpMZClTJe10oo0HJ8Gtj1HoCgkTVUM878Zartdh7Iolsn8oPAXIT2dl3UVHZk9.U3 1dwGqhOLOVybznuaA8mtigB5a4FhLjRVsBJrNEWSapUVybv0YL1D15dWVmucj5Z7QNYdG7zQu1K2 cKq.eGJ8EiMtrLhQty5gBlSBi_M_KBhHASz0HFvzuL X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Sat, 19 Feb 2022 13:00:08 +0000 Original-Received: by kubenode512.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 82757f5635691dcb9f51d6707a7598b4; Sat, 19 Feb 2022 12:50:02 +0000 (UTC) In-Reply-To: <838ru7yqw4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Feb 2022 14:36:43 +0200") X-Mailer: WebService/1.1.19797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.31; envelope-from=luangruo@yahoo.com; helo=sonic308-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286466 Archived-At: Eli Zaretskii writes: > You can still explain that in a comment to the code. Thanks, will do. > And what do we want to do with those invalid UTF-8 sequences? The way > you did it will produce raw bytes for them -- is that really TRT in > this case? Yes, it'll alert the user that something has gone wrong with the input method. > In any case, at the very least consider using decode_string_utf_8 > instead of consing a Lisp string and then using the "usual" decoding > stuff -- decode_string_utf_8 will cons only one string. I will look into that.