all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#54288: 28.0.91; which-func documentation error
@ 2022-03-07  8:21 sebastian--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2022-03-07 15:19 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: sebastian--- via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-03-07  8:21 UTC (permalink / raw)
  To: 54288

In which-func.el there is the following function:

(defun which-func-update ()
  "Update the Which-Function mode display for all windows."
  ;; (walk-windows 'which-func-update-1 nil 'visible))
  (let ((non-essential t))
    (which-func-update-1 (selected-window))))

The doc string is incorrect, since the function only updates the selected window. In fact the doc string is commented out on the 27.2 branch, along with the walk-windows implementation. It's unclear to me from the git history why this implementation for all windows was commented out in the first place, but at the very least the doc string should be updated to correctly reflect the current implementation.

Thanks.

Sebastian





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#54288: 28.0.91; which-func documentation error
  2022-03-07  8:21 bug#54288: 28.0.91; which-func documentation error sebastian--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2022-03-07 15:19 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2022-03-07 15:19 UTC (permalink / raw)
  To: sebastian; +Cc: 54288

sebastian@bsnrg.net writes:

> The doc string is incorrect, since the function only updates the selected window. In fact the doc string is commented out on the 27.2 branch, along with the walk-windows implementation. It's unclear to me from the git history why this implementation for all windows was commented out in the first place, but at the very least the doc string should be updated to correctly reflect the current implementation.

I've now done this in emacs-28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-07 15:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-07  8:21 bug#54288: 28.0.91; which-func documentation error sebastian--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-07 15:19 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.