From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: "corrupted size vs. prev_size" Date: Tue, 12 Apr 2022 13:41:02 +0200 Message-ID: <87ee22wmup.fsf@gnus.org> References: <87mtgqworp.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6470"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 12 13:44:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neEwG-0001VK-4b for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 13:44:04 +0200 Original-Received: from localhost ([::1]:52140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neEwF-00062w-2Q for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 07:44:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neEtW-0004fT-Ny for emacs-devel@gnu.org; Tue, 12 Apr 2022 07:41:23 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:36542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neEtQ-0003cs-I8 for emacs-devel@gnu.org; Tue, 12 Apr 2022 07:41:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/8gdgp5PepZwY7aYtmVQCiF+jlytx3lteRHnTP0wMvk=; b=jgxOKMYd8UOxoe9xZNwQkGyCD5 GQndoiy8SwgJKt0hjb0krbN2gZjbe/SZhSx1T/IAN778EDxOdWWjBY4Y+I3/hmEbi8T27A+WHj6uV 5B/0G62IDmwef3ra7t4AdsRKbunqUnD9ObJbA8/jpDyUJclLVXq+TLVRSdiy3ViZgmxc=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neEtL-0007k1-M5 for emacs-devel@gnu.org; Tue, 12 Apr 2022 13:41:05 +0200 In-Reply-To: <87mtgqworp.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 12 Apr 2022 12:59:38 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288292 Archived-At: Lars Ingebrigtsen writes: > After the recent GIF/WebP caching changes, I sometimes get "corrupted > size vs. prev_size" and Emacs then hangs, so I guess I'm messing up > something in the memory allocation/freeing/writing bits somewhere. After doing more testing, the problem is definitely related to the gif_load code, not the webp_load code. And it only seems to trigger when there's errors in the GIF files (i.e., DGifSlurp etc reports that one of the GIFs can't be parsed). So the problem is either in the error handling on my side, or it could even be a bug in the giflib library. As previously reported, the version of giflib that's in Debian/bookworm has problems parsing GIFs that earlier or later versions of giflib doesn't have... Hm. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no