From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#54931: [PATCH] Have submit-emacs-patch prompt for patch file before subject Date: Thu, 14 Apr 2022 16:41:08 +0000 Message-ID: <87ee1z4nyz.fsf@posteo.net> References: <8735ig55sk.fsf@posteo.net> <875ynbn55g.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2132"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54931@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 14 18:42:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nf2Xs-0000Ib-TH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Apr 2022 18:42:12 +0200 Original-Received: from localhost ([::1]:49428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nf2Xr-000415-Mo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Apr 2022 12:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nf2Xi-00040M-TN for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 12:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nf2Xi-0008A7-KB for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 12:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nf2Xi-0004ci-FV for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 12:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Apr 2022 16:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54931 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54931-submit@debbugs.gnu.org id=B54931.164995447917707 (code B ref 54931); Thu, 14 Apr 2022 16:42:02 +0000 Original-Received: (at 54931) by debbugs.gnu.org; 14 Apr 2022 16:41:19 +0000 Original-Received: from localhost ([127.0.0.1]:57078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nf2X1-0004bX-G6 for submit@debbugs.gnu.org; Thu, 14 Apr 2022 12:41:19 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:45871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nf2Wz-0004bI-GQ for 54931@debbugs.gnu.org; Thu, 14 Apr 2022 12:41:18 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 193FE240027 for <54931@debbugs.gnu.org>; Thu, 14 Apr 2022 18:41:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1649954471; bh=Z0VavKz+YA/Q1oWNwqCiZ8EXoxDsGJNPOdCjgUySUKg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=WFpm8+Ws9JIe4Ak3PhVq108OaeHrKy6oiKef4L2OqIRTrhfC7FL9J25rWWxtun5Qo LtKJZDXl8lJ9ECwnH3xAF1WKsCjiL2dcxjjWwgZSdwPPywfwEmcctXUEiwtgmCdzNF 8NxMhJQDWCmoNuVMVy15V9fZmDqjmZZMh2087Skrh0T+qf2zh7cp1taAMu3vz0frn+ 1Vnl2xFYql6lnmJlZyZutJMNC6JJTOMCRtJbjaJmFoK+QxU4/qn64w+G0xKAIpBTyk nmDyFbpMf3ROziTLaCQe4W9wv54XAqkyTknFJC6MM7Sb41NNWUfrTmVSDm/0zBzkRO bcFSO5yQ0JFEA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KfQFf2vRZz6tnx; Thu, 14 Apr 2022 18:41:10 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <875ynbn55g.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 14 Apr 2022 15:52:43 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229889 Archived-At: Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> When sending patches using submit-emacs-patch, I usually want to reuse >> the commit title for the message subject. As a minor convenience, this >> can be guessed when the patch file is prompted before the subject, >> allowing for a default value to be provided by extracting the "Subject" >> header from the patch file. > > Looks good to me, please go ahead and push. Done, >> + (list (read-string (format-prompt "This patch is about" guess ) >> + nil nil guess) > > But without that space between "guess" and ")". done, Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> Reading through time_cmp, I didn't understand why the lisp_time struct >> was calculated for the first argument before checking if both are eq. >>>>From what I see lisp_time struct is not a destructive function, so it >> should be possible to call the function when calculating the lisp_time >> struct for the second argument. > > Looks good to me; please go ahead and push. and done. -- Philip Kaludercic