Re: master 2ec9f025d2: Include the number of dependencies in the install prompt

Re: master 2ec9f025d2: Include the number of dependencies in the install prompt

[Robert Pluim]

>>>>> On Fri, 13 May 2022 09:31:51 -0400 (EDT), Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> branch: master
    Lars> commit 2ec9f025d242cf28098cf01c532d0cf4e6bd1661
    Lars> Author: Lars Ingebrigtsen <larsi@gnus.org>
    Lars> Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Lars>     Include the number of dependencies in the install prompt
    
    Lars>     * lisp/emacs-lisp/package.el (package-menu--list-to-prompt): Add
    Lars>     the info to the prompt (bug#23346).
    Lars>     (package--dependencies): New function.

After going to all the trouble of calculating the dependencies, it
would be nice to show their names, not just how many there are, no?

Robert
-- 

Re: master 2ec9f025d2: Include the number of dependencies in the install prompt

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> After going to all the trouble of calculating the dependencies, it
> would be nice to show their names, not just how many there are, no?

It would make the prompt really long, though.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 2ec9f025d2: Include the number of dependencies in the install prompt

[Robert Pluim]

>>>>> On Fri, 13 May 2022 15:55:40 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> Robert Pluim <rpluim@gmail.com> writes:
    >> After going to all the trouble of calculating the dependencies, it
    >> would be nice to show their names, not just how many there are, no?

    Lars> It would make the prompt really long, though.

That wouldnʼt bother me particularly. I mean, I upgrade my packages
like twice a year, so just the list after doing 'U' is already
ginormous ;-)

Robert
-- 

Re: master 2ec9f025d2: Include the number of dependencies in the install prompt

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> That wouldnʼt bother me particularly. I mean, I upgrade my packages
> like twice a year, so just the list after doing 'U' is already
> ginormous ;-)

When upgrading, the list is huge, but the patch doesn't include the
dependency thing then (because it's not particularly interesting in that
context).  But if you're installing some-innocuous-package, and it turns
out to have a dependency tree that will install 300 more packages, you
may want to reconsider.  So now it says:

Packages to install: 1 (some-innocuous-package) plus 300 dependencies.  Proceed? (y or n) 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 2ec9f025d2: Include the number of dependencies in the install prompt

[Stefan Monnier]

> +                (if (length= deps 1)
> +                    (format " plus 1 dependency")
> +                  (format " plus %d dependencies" (length deps)))

Don't we have a function specifically for that (also kinda intended for
localization, tho AFAIK this part isn't actually implemented yet)?


        Stefan

Re: master 2ec9f025d2: Include the number of dependencies in the install prompt

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Don't we have a function specifically for that (also kinda intended for
> localization, tho AFAIK this part isn't actually implemented yet)?

Yes, but I can never remember what it's called.  🫠

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 2ec9f025d2: Include the number of dependencies in the install prompt

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org
> Date: Fri, 13 May 2022 16:52:38 +0200
> 
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
> 
> > Don't we have a function specifically for that (also kinda intended for
> > localization, tho AFAIK this part isn't actually implemented yet)?
> 
> Yes, but I can never remember what it's called.  🫠

Unsurprisingly, ngettext.