From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.bugs Subject: bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend Date: Fri, 15 Jul 2022 15:27:23 +0200 Message-ID: <87edymsdz8.fsf@elite.giraud> References: <87wnch16as.fsf@elite.giraud> <87k08gtsz0.fsf@yahoo.com> <87cze8t4i9.fsf@elite.giraud> <87k08goud8.fsf@yahoo.com> <87h73jq1dp.fsf@elite.giraud> <874jzjp1st.fsf@yahoo.com> <87ilnysi72.fsf@elite.giraud> <87v8rymt15.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8793"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: 56538@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 15 15:28:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCLMb-00026z-Df for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 15:28:13 +0200 Original-Received: from localhost ([::1]:46754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCLMa-0003vg-7e for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 09:28:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCLMR-0003tP-OF for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 09:28:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCLMQ-0003FD-3b for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 09:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCLMP-0000zr-VM for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 09:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jul 2022 13:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56538 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56538-submit@debbugs.gnu.org id=B56538.16578916623787 (code B ref 56538); Fri, 15 Jul 2022 13:28:01 +0000 Original-Received: (at 56538) by debbugs.gnu.org; 15 Jul 2022 13:27:42 +0000 Original-Received: from localhost ([127.0.0.1]:39861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCLM6-0000z1-0z for submit@debbugs.gnu.org; Fri, 15 Jul 2022 09:27:42 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:27815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCLM4-0000yr-2w for 56538@debbugs.gnu.org; Fri, 15 Jul 2022 09:27:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=+r4Y6R7a0JlwKthE mmIXXDiovaiJ3BU3n36sR3D/5Lg=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=lCHOckbtyO4QbfRyICDBggNmj952HEu6YE3QCu FsqivA/y7dSq1+uBlviNLZPSW8a8F5npOrlnAz9D4cAJ/1Eueik68Vgb31euno9Fhlm7yR szuYh2wSCtNFEO4Y07AK4YkYmmsTJnDxw0IErC3xnLIaEFceupnP/GPsl58LXOBS+QGSrM 4Msx5vO5yYFsqMhqLpePf/gBzeY9aZMMoVNVZRFCWl0JQ6+aChAlTB3/Aco/8+j7Gzqnen eSxkxnUqPHRNzvFiBeDQVdSv+zuPoxDp/u81jpCCz1V5B+yA1yXHEi4KoCKpCHeNjv14Kw YyradTXxD/G/Y6cFnwafYFmg== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 6c795dba (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 15 Jul 2022 15:27:36 +0200 (CEST) In-Reply-To: <87v8rymt15.fsf@yahoo.com> (Po Lu's message of "Fri, 15 Jul 2022 20:58:46 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237098 Archived-At: Po Lu writes: [...] >> +@item highlightForeground >> +Foreground color for a highlighted menu item. >> +@item highlightBackground >> +Background color for a highlighted menu item. > > Shouldn't this say "the menu item highlighted by the mouse"? Otherwise, > what "highlighted" means is not exactly clear. I did not add "by the mouse" because menus could also be navigated with keyboard arrows. Do you have any other suggestions to make it clearer? >> +** New X resources: "highlightForeground" and "highlightBackground" >> +Only in the Lucid build, this controls colors used for highlighted >> +menu item widget. > > And here, shouldn't "widget" be in plural? Ok. I'll add it to the next patch when the previous issue is resolved. -- Manuel Giraud