* Re: master c12838c73e: * lisp/help-fns.el: Minor fixes
[not found] ` <20220902135440.B28DFC04F05@vcs2.savannah.gnu.org>
@ 2022-09-03 0:44 ` Stefan Kangas
2022-09-03 7:27 ` Eli Zaretskii
2022-09-03 14:34 ` Stefan Monnier
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Kangas @ 2022-09-03 0:44 UTC (permalink / raw)
To: Stefan Monnier, emacs-devel
> branch: master
> commit c12838c73ef161850a081f9ccea6e375b7c2f93b
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> * lisp/help-fns.el: Minor fixes
>
> (describe-mode--minor-modes): Don't burp on minor modes that lack a docstring.
> (describe-mode--minor-modes): Simplify eta-redex.
> (find-lisp-object-file-name): Use `autoload-file`.
> (help-fns--describe-function-or-command-prompt): Allow the user to
> insist on choosing a function even if it appears not to exist.
This seems to lead to:
Test help-fns-test-bug17410 backtrace:
autoload-file((autoload "foo" nil nil t))
find-lisp-object-file-name(help-fns-test--macro (autoload "foo" nil
help-fns-function-description-header(help-fns-test--macro)
describe-function-1(help-fns-test--macro)
(let ((standard-output standard-output)) (describe-function-1 func))
(progn (let ((standard-output standard-output)) (describe-function-1
(unwind-protect (progn (let ((standard-output standard-output)) (des
(let ((standard-output (generate-new-buffer " *string-output*" t)))
(let ((string (let ((standard-output (generate-new-buffer " *string-
help-fns-tests--describe-function(help-fns-test--macro)
(let ((regexp "autoloaded Lisp macro") (result (help-fns-tests--desc
(closure (t) nil (let ((regexp "autoloaded Lisp macro") (result (hel
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name help-fns-test-bug17410 :documentation
ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/help-fns-tests.el" "
command-line()
normal-top-level()
Test help-fns-test-bug17410 condition:
(void-function autoload-file)
FAILED 3/20 help-fns-test-bug17410 (0.000129 sec) at
lisp/help-fns-tests.el:44
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master c12838c73e: * lisp/help-fns.el: Minor fixes
2022-09-03 0:44 ` master c12838c73e: * lisp/help-fns.el: Minor fixes Stefan Kangas
@ 2022-09-03 7:27 ` Eli Zaretskii
2022-09-03 12:00 ` Lars Ingebrigtsen
2022-09-03 14:34 ` Stefan Monnier
1 sibling, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2022-09-03 7:27 UTC (permalink / raw)
To: Stefan Kangas; +Cc: monnier, emacs-devel
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Fri, 2 Sep 2022 17:44:30 -0700
>
> > branch: master
> > commit c12838c73ef161850a081f9ccea6e375b7c2f93b
> > Author: Stefan Monnier <monnier@iro.umontreal.ca>
> > Commit: Stefan Monnier <monnier@iro.umontreal.ca>
> >
> > * lisp/help-fns.el: Minor fixes
> >
> > (describe-mode--minor-modes): Don't burp on minor modes that lack a docstring.
> > (describe-mode--minor-modes): Simplify eta-redex.
> > (find-lisp-object-file-name): Use `autoload-file`.
> > (help-fns--describe-function-or-command-prompt): Allow the user to
> > insist on choosing a function even if it appears not to exist.
>
> This seems to lead to:
>
> Test help-fns-test-bug17410 backtrace:
> autoload-file((autoload "foo" nil nil t))
> find-lisp-object-file-name(help-fns-test--macro (autoload "foo" nil
Yes, because the function autoload-file doesn't seem to exist.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master c12838c73e: * lisp/help-fns.el: Minor fixes
2022-09-03 0:44 ` master c12838c73e: * lisp/help-fns.el: Minor fixes Stefan Kangas
2022-09-03 7:27 ` Eli Zaretskii
@ 2022-09-03 14:34 ` Stefan Monnier
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2022-09-03 14:34 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
>> * lisp/help-fns.el: Minor fixes
>>
>> (describe-mode--minor-modes): Don't burp on minor modes that lack a docstring.
>> (describe-mode--minor-modes): Simplify eta-redex.
>> (find-lisp-object-file-name): Use `autoload-file`.
>> (help-fns--describe-function-or-command-prompt): Allow the user to
>> insist on choosing a function even if it appears not to exist.
>
> This seems to lead to:
>
> Test help-fns-test-bug17410 backtrace:
> autoload-file((autoload "foo" nil nil t))
Not sure what I was smoking back then, sorry.
Should be fixed now,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-03 14:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <166212688020.22107.2630550400639665135@vcs2.savannah.gnu.org>
[not found] ` <20220902135440.B28DFC04F05@vcs2.savannah.gnu.org>
2022-09-03 0:44 ` master c12838c73e: * lisp/help-fns.el: Minor fixes Stefan Kangas
2022-09-03 7:27 ` Eli Zaretskii
2022-09-03 12:00 ` Lars Ingebrigtsen
2022-09-03 14:34 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.