From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: miha--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58176: 29.0.50; mouse-set-point region flicker with highlight-nonselected-windows=t and same buffer in two windows Date: Sat, 01 Oct 2022 12:00:43 +0200 Message-ID: <87edvrualw.fsf@miha-pc> References: <86pmfeaxnv.fsf@miha-pc> <838rm2f1v8.fsf@gnu.org> <87wn9lubu6.fsf@miha-pc> <835yh5fm9j.fsf@gnu.org> <87h70otvgs.fsf@miha-pc> <83czbccddy.fsf@gnu.org> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3811"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58176@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 01 11:47:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oeZ5V-0000li-AZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Oct 2022 11:47:13 +0200 Original-Received: from localhost ([::1]:45942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oeZ5T-0005Tw-Al for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Oct 2022 05:47:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeZ5K-0005Tg-M8 for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 05:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oeZ5K-0006Q6-7X for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 05:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oeZ5J-0000qP-UC for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 05:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Oct 2022 09:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58176 X-GNU-PR-Package: emacs Original-Received: via spool by 58176-submit@debbugs.gnu.org id=B58176.16646176123229 (code B ref 58176); Sat, 01 Oct 2022 09:47:01 +0000 Original-Received: (at 58176) by debbugs.gnu.org; 1 Oct 2022 09:46:52 +0000 Original-Received: from localhost ([127.0.0.1]:43661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeZ59-0000q1-OF for submit@debbugs.gnu.org; Sat, 01 Oct 2022 05:46:52 -0400 Original-Received: from kamnitnik.top ([209.250.245.214]:59802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeZ55-0000pp-9J for 58176@debbugs.gnu.org; Sat, 01 Oct 2022 05:46:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top; s=mail; t=1664617605; bh=d4uuILqey/cdDfCUI3ktPGPBYUh2n4LfsEV165aFYuw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=akobv9TAvxBy82LxNAhcy/MJ8VpQzA4dYf8cXu3PtMjTF/ObR9sFrWI/yR8yIf2tv l2DLKln5ivXhPtt8U+22jTMa4oHcTDwDxxA4rUlv1FRllKu0gysEIzhe+cEE4uup5V oeWZRHt83Hct8YFIrmfFuyxAqNFL+TZKA3MD3FnuiwAxnMAshf/6dw/rbUG8wTItom JLTB0W1o9I64Px/Vtti5mYXJdDoTDMqOri3H0H2O0euOFDCAH+px71n3OA8YKS0AX7 QUWv6dzei33mgGSSwxbgRG6fKDkZwhHTQr2n6FsR5OGxg4S0rGk7UTaH30vaW6Z0W1 rtKo8eiUcgFbQ== In-Reply-To: <83czbccddy.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244090 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> (I'm assuming that by "show regions of zero length", you mean that the >> "Copy text" toolbar icon is enabled.) > > No, we actually attempt to display zero-length regions in the text. Maybe there's something obvious I'm missing, but in a graphical emacs =2Dq, I can't see a zero length active region in the text at all. That is, after activating it with C-SPC or a non-dragging mouse-1 button press, I can't see a single pixel around point changing to indicate the region. I even tried it after considerably enlarging the font with 'C-x C-+ + + + + ...'. (On the other hand, zero-length rectangular regions, created with C-x SPC, are properly indicated with a thin vertical line, but we aren't talking about rectangular regions here.) >> I hope I'm not arguing semantics too much, but my patch doesn't actually >> hide an (active) region of zero length, it prevents one from being >> activated. > > Which is against the behavior we want, I think. > >> It only prevents it in the specific case of a non-dragging mouse-1 >> click, which makes quite a lot sense to me. The current behaviour of a >> non-dragging mouse-1 click is that the zero-length region is only active >> for the duration of the mouse button being held down. Once the button is >> released, the zero-length region is deactivated, which makes it not very >> useful, as far as I can see. > > It is useful in the much more frequent use case where the user then > drags the mouse. This use case is, of course, still supported by my patch. I was talking about the very specific zero-length region, active for the duration of a non-dragging mouse-1 button being held down. My patch affects only this specific use-case >> If you want to create a zero-length region that stays active after >> releasing mouse-1, you have to drag the mouse a little first to make the >> region length non-zero and then drag the mouse back to the starting >> position to make the region length zero again. This use case is still >> supported by my patch. >>=20 >> (Perhaps I missed some use-cases of a zero-length region active during a >> non-dragging mouse-1 button hold. If you know any, please let me know >> about them.) >>=20 >> This, together with the fact that it reduces the "flicker" from the >> original message, makes me insist on the patch. > > I still insist that what you propose is the opposite of the behavior > we want. Another unrelated thing to consider is the current behaviour of clicking/dragging C-M-mouse-1. It doesn't activate a rectangular region until the user drags C-M-mouse-1. In fact, if the user only does a non-dragging C-M-mouse-1 click, the rectangular region is never activated, only the point moves. You can try experimenting with C-M-mouse-1 and see, if this is really the opposite of the behaviour we want. In essence, my patch tries to make behaviour of mouse-1 region activation more similar to C-M-mouse-1 rectangular region activation. (Emacs build info follows, since the non-display of zero-length non-rectangular regions in the text could be dependent on build configuration.) In GNU Emacs 29.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6) of 2022-09-29 built on miha-pc Repository revision: 0edd7770e0ce70cac59f239134962d10f48dec79 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Arch Linux Configured using: 'configure -C --prefix=3D/usr --without-libsystemd --enable-checking=3Dyes,glyphs --enable-check-lisp-object-type 'CFLAGS=3D-O0 -g3'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.utf8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date subr-x cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 38907 4530) (symbols 48 5110 0) (strings 32 13189 1629) (string-bytes 1 377949) (vectors 16 9355) (vector-slots 8 148819 10571) (floats 8 25 24) (intervals 56 348 5) (buffers 1000 11)) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmM4D8sTHG1paGFAa2Ft bml0bmlrLnRvcAAKCRCzCRoakhWZP2aRD/9eHU5+4m2eVl8UnYen+w9LYa5toQmF DOTJd600ykCUKE3i0oJisuxzdLk0KVDgy0sbMRLR/ZjZefsDRUrqBzpH9EuX1fZD rhRpqX9X2lOftR9vicx//zsQiNVRqGCb9CO/JVyEK+vk8mpgsrAllVftSWQiG4aa SmsadQ9S1GDjpNNoFZsMVnh3e2EiI/rUpmxbiU0xq8ciol1WGNCu9lINvgYm5HuP z5QSDi/cNgyv4XdNlJNQc6hSbM9036M7wfBfw+N3wc70fHCQxOYquKOb2RkHlSKm BR1lhsLTAJbnxA+oYzroLZchb+MsngqKZJr/5hCWre0VxGFoptpJEd5AFpAB0wFe IYb7AEb32/mnUXagw8HrZCsHZy8h1/+NO9SXONo3VqpFN8jH3pTLTuOVze8riZM4 k9OOTUkxoAl/4i899/YvdlbWHQj7XBbsEmq4jOi3Xc6mz1pHLUG6CCBLPSjdxv8d faNMDKs8V5pX3L35YnTGHY0rWgvX9Domxw0gQRVjQNpyPiyXcbLrqVFL6b7VwT4X 23wa0v4gcFJsnN17zKqSGi4M9o8CmT2TbKneZM3iAb4dmm7IndiDQTgaUqaJO0jy SgByHwKEcOXf7DRtFhekLNgG7w2jJUnWPjYV0zXuG9aBTMMtcv3O1jIeZ4Qm6Vzh FUrSNTNYWrzv8A== =7hsO -----END PGP SIGNATURE----- --=-=-=--