bug#58311: Missing newline in *Messages* between evaluation result and error

bug#58311: Missing newline in *Messages* between evaluation result and error

[Felix Dietrich]

Package: emacs
Severity: minor

Entries added to the “*Messages*” buffer by the following snippet are
missing a newline between the evaluation result and the error log entry
put there by “xfaces.c:merge_face_ref” using “xdisp.c:add_to_log”.

#+begin_src emacs-lisp
  (let ((buf (generate-new-buffer "*test*"))
        (s (propertize "Hello World" 'face '(:foreground :invalid))))
    (with-current-buffer buf
      (insert s))
    (display-buffer buf))
#+end_src


#+begin_example
#<window 54 on *test*<2>>Invalid face attribute :foreground :invalid
Invalid face attribute :foreground :invalid
#+end_example


-- 
Felix Dietrich

bug#58311: Missing newline in *Messages* between evaluation result and error

[Lars Ingebrigtsen]

Felix Dietrich <felix.dietrich@sperrhaken.name> writes:

> Entries added to the “*Messages*” buffer by the following snippet are
> missing a newline between the evaluation result and the error log entry
> put there by “xfaces.c:merge_face_ref” using “xdisp.c:add_to_log”.
>
> #+begin_src emacs-lisp
>   (let ((buf (generate-new-buffer "*test*"))
>         (s (propertize "Hello World" 'face '(:foreground :invalid))))
>     (with-current-buffer buf
>       (insert s))
>     (display-buffer buf))
> #+end_src
>
> #+begin_example
> #<window 54 on *test*<2>>Invalid face attribute :foreground :invalid
> Invalid face attribute :foreground :invalid
> #+end_example

Hm.  Very odd.  The code just calls

		      add_to_log ("Invalid face attribute %S %S",
				  QCinherit, parent_face);

the normal way, and reading the code and poking at this a bit, it seems
like add_to_log should insert a newline before inserting the text, but I
may be misreading message_dolog -- it's pretty long.

Is it "immediately obvious" to somebody else what is happening here?

bug#58311: Missing newline in *Messages* between evaluation result and error

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Hm.  Very odd.  The code just calls
>
> 		      add_to_log ("Invalid face attribute %S %S",
> 				  QCinherit, parent_face);

Or rather, it's this bit, but the same applies:

	      if (err)
		{
		  add_to_log ("Invalid face attribute %S %S", keyword, value);
		  ok = false;
		}