bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]


Hi 

I encountered a problem when I compiled the latest master (Using Ubuntu
16.04 and the corresponding GTK version)


I attach a screenshot 
The config options are 
auto-apt run ./configure --prefix=/opt/emacs29  --without-pop --with-mailutils



I bisected the problem and found out that the culprit is 
 commit 74c07733698b95eb455edcafab8634a700a3194f
  Author: Po Lu <luangruo@yahoo.com>
  Date: Thu, 17 Feb 2022 10:28:02 +0800
  * src/emacsgtkfixed.c (XSetWMSizeHints): Improve fix for bug#8919.


Regards

Uwe Brauer 

[-- Attachment #2: emacs-no-athena.png --]
[-- Type: image/png, Size: 115914 bytes --]

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> Hi 
>
> I encountered a problem when I compiled the latest master (Using Ubuntu
> 16.04 and the corresponding GTK version)
>
>
> I attach a screenshot 
> The config options are 
> auto-apt run ./configure --prefix=/opt/emacs29  --without-pop --with-mailutils
>
>
>
> I bisected the problem and found out that the culprit is 
>  commit 74c07733698b95eb455edcafab8634a700a3194f
>   Author: Po Lu <luangruo@yahoo.com>
>   Date: Thu, 17 Feb 2022 10:28:02 +0800
>   * src/emacsgtkfixed.c (XSetWMSizeHints): Improve fix for bug#8919.
>
>
> Regards
>
> Uwe Brauer 

Thanks.  What happens if you set frame-resize-pixelwise to t in
early-init.el?

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]


> Uwe Brauer <oub@mat.ucm.es> writes:

> Thanks.  What happens if you set frame-resize-pixelwise to t in
> early-init.el?

I have never used early-init.el

For debugging I always use emacs -Q

So do you want be to have early-init.el in my home directory or in emacs/src?

How should I start emacs then?
-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> So do you want be to have early-init.el in my home directory or in emacs/src?

In your home directory.

> How should I start emacs then?

Without "emacs -Q", if the bug can be reproduced that way.

Thanks.

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Uwe Brauer]

[-- Attachment #1.1: Type: text/plain, Size: 356 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> So do you want be to have early-init.el in my home directory or in emacs/src?

> In your home directory.

>> How should I start emacs then?

> Without "emacs -Q", if the bug can be reproduced that way.

Ok, interesting:
first the screenshots of emacs -Q and emacs -q

[-- Attachment #1.2: emacs-emacs-q.png --]
[-- Type: image/png, Size: 332376 bytes --]

[-- Attachment #1.3: emacs-emacs-Q.png --]
[-- Type: image/png, Size: 256579 bytes --]

[-- Attachment #1.4: Type: text/plain, Size: 135 bytes --]


Then the screenshot with the early-init

It seems to look ok but when it finishes loading all my init files, it
looks like emacs -Q



[-- Attachment #1.5: emacs-emacs-full.png --]
[-- Type: image/png, Size: 343175 bytes --]

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> Then the screenshot with the early-init
>
> It seems to look ok but when it finishes loading all my init files, it
> looks like emacs -Q

Sigh.  If you instrument emacsgtkfixed.c as follows:

	  if (hints->width_inc && data[5] % hints->width_inc)
	    data[5] += (hints->width_inc - (data[5] % hints->width_inc));
	  if (hints->height_inc && data[6] % hints->height_inc)
	    data[6] += (hints->height_inc - (data[6] % hints->height_inc));
         (Add instrumentation following this line)
	  fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
		   data[5], data[6], hints->width_inc, hints->height_inc)

what is printed when you start Emacs with "-Q", and Kwin shrinks your
window?

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Uwe Brauer]

[-- Attachment #1.1: Type: text/plain, Size: 1971 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> Then the screenshot with the early-init
>> 
>> It seems to look ok but when it finishes loading all my init files, it
>> looks like emacs -Q

> Sigh.  If you instrument emacsgtkfixed.c as follows:

> 	  if (hints->width_inc && data[5] % hints->width_inc)
> 	    data[5] += (hints->width_inc - (data[5] % hints->width_inc));
> 	  if (hints->height_inc && data[6] % hints->height_inc)
> 	    data[6] += (hints->height_inc - (data[6] % hints->height_inc));
>          (Add instrumentation following this line)
> 	  fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
> 		   data[5], data[6], hints->width_inc, hints->height_inc)

> what is printed when you start Emacs with "-Q", and Kwin shrinks your
> window?

I don't know anything about that C code (and the last time, I did some C coding is some 10 years ago)


Not sure I understand, I apply the patch attached below and run make again:

Then I get an error (so most likely I misunderstood you)


 GEN      globals.h
  CC       emacsgtkfixed.o
emacsgtkfixed.c: In function ‘XSetWMSizeHints’:
emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
    fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n", /* new code for testing */
                     ^
emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
emacsgtkfixed.c:190:21: warning: unknown conversion type character 0xa in format [-Wformat=]
emacsgtkfixed.c:190:21: warning: too many arguments for format [-Wformat-extra-args]
emacsgtkfixed.c:192:6: error: expected ‘;’ before ‘}’ token
      }
      ^
Makefile:414: recipe for target 'emacsgtkfixed.o' failed
make: *** [emacsgtkfixed.o] Error 1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: emacsgtkfixed.patch --]
[-- Type: text/x-diff, Size: 615 bytes --]

diff --git a/src/emacsgtkfixed.c b/src/emacsgtkfixed.c
--- a/src/emacsgtkfixed.c
+++ b/src/emacsgtkfixed.c
@@ -187,7 +187,9 @@
 	    data[5] += (hints->width_inc - (data[5] % hints->width_inc));
 	  if (data[6] % hints->height_inc)
 	    data[6] += (hints->height_inc - (data[6] % hints->height_inc));
-	}
+	  fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n", /* new code for testing */
+                   data[5], data[6], hints->width_inc, hints->height_inc) /* new code for testing */
+	    }
     }
 
   XChangeProperty (d, w, prop, XA_WM_SIZE_HINTS, 32, PropModeReplace,

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> Then the screenshot with the early-init
>> 
>> It seems to look ok but when it finishes loading all my init files, it
>> looks like emacs -Q

> Sigh.  If you instrument emacsgtkfixed.c as follows:

> 	  if (hints->width_inc && data[5] % hints->width_inc)
> 	    data[5] += (hints->width_inc - (data[5] % hints->width_inc));
> 	  if (hints->height_inc && data[6] % hints->height_inc)
> 	    data[6] += (hints->height_inc - (data[6] % hints->height_inc));
>          (Add instrumentation following this line)
> 	  fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
> 		   data[5], data[6], hints->width_inc, hints->height_inc)

> what is printed when you start Emacs with "-Q", and Kwin shrinks your
> window?


I compiled it finally a ; was missing.

The message is 

./emacs -Q
XSetWMSizeHints: % % width_inc: % height_inc: %
XSetWMSizeHints: % % width_inc: % height_inc: %

(emacs:833): Gtk-WARNING **: Allocating size to Emacs 0x1d503e0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?
XSetWMSizeHints: % % width_inc: % height_inc: %
XSetWMSizeHints: % % width_inc: % height_inc: %
XSetWMSizeHints: % % width_inc: % height_inc: %
XSetWMSizeHints: % % width_inc: % height_inc: %
XSetWMSizeHints: % % width_inc: % height_inc: %


-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

>>>> "PL" == Po Lu <luangruo@yahoo.com> writes:
>
>> Uwe Brauer <oub@mat.ucm.es> writes:
>>> Then the screenshot with the early-init
>>> 
>>> It seems to look ok but when it finishes loading all my init files, it
>>> looks like emacs -Q
>
>> Sigh.  If you instrument emacsgtkfixed.c as follows:
>
>> 	  if (hints->width_inc && data[5] % hints->width_inc)
>> 	    data[5] += (hints->width_inc - (data[5] % hints->width_inc));
>> 	  if (hints->height_inc && data[6] % hints->height_inc)
>> 	    data[6] += (hints->height_inc - (data[6] % hints->height_inc));
>>          (Add instrumentation following this line)
>> 	  fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
>> 		   data[5], data[6], hints->width_inc, hints->height_inc)
>
>> what is printed when you start Emacs with "-Q", and Kwin shrinks your
>> window?
>
> I don't know anything about that C code (and the last time, I did some C coding is some 10 years ago)
>
>
> Not sure I understand, I apply the patch attached below and run make again:
>
> Then I get an error (so most likely I misunderstood you)
>
>
>  GEN      globals.h
>   CC       emacsgtkfixed.o
> emacsgtkfixed.c: In function ‘XSetWMSizeHints’:
> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
>     fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n", /* new code for testing */
>                      ^
> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0xa in format [-Wformat=]
> emacsgtkfixed.c:190:21: warning: too many arguments for format [-Wformat-extra-args]
> emacsgtkfixed.c:192:6: error: expected ‘;’ before ‘}’ token
>       }
>       ^
> Makefile:414: recipe for target 'emacsgtkfixed.o' failed
> make: *** [emacsgtkfixed.o] Error 1

Ah, silly me.  Please replace %l with %ld.

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

>>>> "PL" == Po Lu <luangruo@yahoo.com> writes:
>
>> Uwe Brauer <oub@mat.ucm.es> writes:
>>> Then the screenshot with the early-init
>>> 
>>> It seems to look ok but when it finishes loading all my init files, it
>>> looks like emacs -Q
>
>> Sigh.  If you instrument emacsgtkfixed.c as follows:
>
>> 	  if (hints->width_inc && data[5] % hints->width_inc)
>> 	    data[5] += (hints->width_inc - (data[5] % hints->width_inc));
>> 	  if (hints->height_inc && data[6] % hints->height_inc)
>> 	    data[6] += (hints->height_inc - (data[6] % hints->height_inc));
>>          (Add instrumentation following this line)
>> 	  fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
>> 		   data[5], data[6], hints->width_inc, hints->height_inc)
>
>> what is printed when you start Emacs with "-Q", and Kwin shrinks your
>> window?
>
>
> I compiled it finally a ; was missing.
>
> The message is 
>
> ./emacs -Q
> XSetWMSizeHints: % % width_inc: % height_inc: %
> XSetWMSizeHints: % % width_inc: % height_inc: %
>
> (emacs:833): Gtk-WARNING **: Allocating size to Emacs 0x1d503e0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?
> XSetWMSizeHints: % % width_inc: % height_inc: %
> XSetWMSizeHints: % % width_inc: % height_inc: %
> XSetWMSizeHints: % % width_inc: % height_inc: %
> XSetWMSizeHints: % % width_inc: % height_inc: %
> XSetWMSizeHints: % % width_inc: % height_inc: %

Yes, sorry, please see my other reply.

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Uwe Brauer]

[-- Attachment #1.1: Type: text/plain, Size: 3439 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

   > Uwe Brauer <oub@mat.ucm.es> writes:
   >>>>> "PL" == Po Lu <luangruo@yahoo.com> writes:
   >> 
   >>> Uwe Brauer <oub@mat.ucm.es> writes:
>>> Then the screenshot with the early-init
>>> 
>>> It seems to look ok but when it finishes loading all my init files, it
>>> looks like emacs -Q
   >> 
   >>> Sigh.  If you instrument emacsgtkfixed.c as follows:
   >> 
   >>> if (hints->width_inc && data[5] % hints->width_inc)
   >>> data[5] += (hints->width_inc - (data[5] % hints->width_inc));
   >>> if (hints->height_inc && data[6] % hints->height_inc)
   >>> data[6] += (hints->height_inc - (data[6] % hints->height_inc));
   >>> (Add instrumentation following this line)
   >>> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
   >>> data[5], data[6], hints->width_inc, hints->height_inc)
   >> 
   >>> what is printed when you start Emacs with "-Q", and Kwin shrinks your
   >>> window?
   >> 
   >> I don't know anything about that C code (and the last time, I did some C coding is some 10 years ago)
   >> 
   >> 
   >> Not sure I understand, I apply the patch attached below and run make again:
   >> 
   >> Then I get an error (so most likely I misunderstood you)
   >> 
   >> 
   >> GEN      globals.h
   >> CC       emacsgtkfixed.o
   >> emacsgtkfixed.c: In function ‘XSetWMSizeHints’:
   >> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
   >> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n", /* new code for testing */
   >> ^
   >> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
   >> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
   >> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0xa in format [-Wformat=]
   >> emacsgtkfixed.c:190:21: warning: too many arguments for format [-Wformat-extra-args]
   >> emacsgtkfixed.c:192:6: error: expected ‘;’ before ‘}’ token
   >> }
   >> ^
   >> Makefile:414: recipe for target 'emacsgtkfixed.o' failed
   >> make: *** [emacsgtkfixed.o] Error 1

   > Ah, silly me.  Please replace %l with %ld.
,----
| 
| make
|   GEN      globals.h
|   CC       emacsgtkfixed.o
| emacsgtkfixed.c: In function ‘XSetWMSizeHints’:
| emacsgtkfixed.c:190:21: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int’ [-Wformat=]
|     fprintf (stderr, "XSetWMSizeHints: %ld %ld width_inc: %ld height_inc: %ld\n",
|                      ^
| emacsgtkfixed.c:190:21: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘int’ [-Wformat=]
| make -C ../admin/charsets all
`----


And 



,----
| ./emacs -Q
| XSetWMSizeHints: 297 51 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 51 width_inc: 9 height_inc: 17
| 
| (emacs:2027): Gtk-WARNING **: Allocating size to Emacs 0x2be63e0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?
| XSetWMSizeHints: 414 51 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
`----



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: emacsgtkfixed-2.patch --]
[-- Type: text/x-diff, Size: 552 bytes --]

diff --git a/src/emacsgtkfixed.c b/src/emacsgtkfixed.c
--- a/src/emacsgtkfixed.c
+++ b/src/emacsgtkfixed.c
@@ -187,7 +187,9 @@
 	    data[5] += (hints->width_inc - (data[5] % hints->width_inc));
 	  if (data[6] % hints->height_inc)
 	    data[6] += (hints->height_inc - (data[6] % hints->height_inc));
-	}
+	  fprintf (stderr, "XSetWMSizeHints: %ld %ld width_inc: %ld height_inc: %ld\n",
+		   data[5], data[6], hints->width_inc, hints->height_inc);
+	    }
     }
 
   XChangeProperty (d, w, prop, XA_WM_SIZE_HINTS, 32, PropModeReplace,

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> | XSetWMSizeHints: 414 51 width_inc: 9 height_inc: 17
> | XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
> | XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
> | XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
> | XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17

That's odd.  Unfortunately the previous code resulted in menu bar size
hints set by GTK not being respected, so I'm at odds wrt what to do
here.  On one hand, your window manager is clearly buggy, but it used to
work.  I guess a user option to enable the previous behavior would be
the most reasonable course of action.

Does anyone else have an opinion here?

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> | XSetWMSizeHints: 414 51 width_inc: 9 height_inc: 17
>> | XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
>> | XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
>> | XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
>> | XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17

> That's odd.  Unfortunately the previous code resulted in menu bar size
> hints set by GTK not being respected, so I'm at odds wrt what to do
> here.  On one hand, your window manager is clearly buggy, but it used to
> work.  I guess a user option to enable the previous behavior would be
> the most reasonable course of action.

> Does anyone else have an opinion here?

Two comments:

    1. The compiling error I mentioned is not important?

    2. Since I use athena, and this you fixed, for me that fix is not
       urgent, besides I have to admit that I should upgrade Ubuntu.
-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

>     1. The compiling error I mentioned is not important?

No, it's a warning, and the data printed is correct.