From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add user content APIs for WebKit Xwidgets Date: Sun, 16 Oct 2022 12:32:30 +0800 Message-ID: <87edv8mlr5.fsf@yahoo.com> References: <763B89A7-AF82-4AAB-A0E9-A04D9958CAE8@stanford.edu> <878rlianx4.fsf@yahoo.com> <9FF9464C-1369-423E-A581-A900D132845F@stanford.edu> <87zgdy97t1.fsf@yahoo.com> <63F00459-018C-4634-9B52-A89A3ED1AA36@stanford.edu> <0F1442C8-45E2-408C-B310-448B4A26496E@stanford.edu> <87ilklnxei.fsf@yahoo.com> <0583C9C0-9953-414E-9F51-2AEFDF225BD9@stanford.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28662"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Lars Ingebrigtsen , "emacs-devel@gnu.org" To: Qiantan Hong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 16 06:34:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojvLe-0007EA-5E for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Oct 2022 06:34:02 +0200 Original-Received: from localhost ([::1]:56366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojvLc-00051c-Ip for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Oct 2022 00:34:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojvKV-0004Kd-7h for emacs-devel@gnu.org; Sun, 16 Oct 2022 00:32:51 -0400 Original-Received: from sonic310-25.consmr.mail.ne1.yahoo.com ([66.163.186.206]:41345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojvKQ-0008Fz-9I for emacs-devel@gnu.org; Sun, 16 Oct 2022 00:32:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1665894761; bh=llEbYEaWbGUiDCyrFbYfUmPruqWbvZq83hJbRXblgzg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=RORdR6ATu76Gn5Yy4wv+OHDHXX89KnOl3V32gO2iCHUIRJ27UG4IfdvC5nufq+uzZy6JjQFV8YpCDSM/MIEBOFYH88YcyD1CcmNx9xEnteOtr4Uoi5/5xWATSMroVVVRNF9p27wlYEviFMCB0wJ545WHCWX8h/RdbIzIenGormsw2NOdlfgDfMItxicPyusz55xV8AdqGVsNfR2G0Fh+l70COczpEG0BXcl5DAn6s5dQAlBEhCCV7S+i3A0Psj+NryJXAcA9iRZBErW9v0urWx6rIBaxvSdJs+PR2d2Sazu6poZpU7mChFpfCqTfzsmtAlM35G/TDj1dogM2AZ/wUg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1665894761; bh=YVIwvs8K8dAq2UAdhOiIMAHtgapf5ctEzWEO2zcAiO7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=aHowbCEfL+irVevUQeTYUPMLTK9rrYFBDXL5cZlAHMCeVrpOK8XHNcRbJOwcRJG3bu/4Zqw+Oaxa/x+zKqdMRYiNN62nC1Axx3wn0LcLTBvcuT8fTjXNiEm2M+kv42aCFANHGevbbbfQXla9BuI0WPgnYzrxv5uv7GGi1ZftxtFgjtdjqnc+jIK4qslEDXwiS3f2kzccqvXs/wwDi/xpyBnU7oJCS0ZHm64EghVf2VWEBGvxIflsq3tdkbY6aKL2vgGkXWCtLGk5PnyrmLMW3SzBtLD2natUFPObUXz8vYM8BI4/LgRx1dg2bCzztccOpBWaacrLzRKdFHkuHi2DEg== X-YMail-OSG: inOiBCoVM1lxLElkNtLPKAKzfbbuAMnBb1iYl2U5t9upvdk5Yazps1BjZWMYNa_ ZnWBosSZ5ZfAdKrUhqFk2Xc0NjAeOoU9rV_uZIwY4i4S28LX39QVBpM8rTDH4s4Civf9DqhsyOmI pUtnveVpoh6cfIojx1X5Oj2Ldvo3zyy7O_mugq5U4tPaluc8pJUv6O4AL1jVeFSEVJPKleFpyUsC rylowRE2rC0K.NilFk4oQY49be_QAQTDDm0rziz7ZqpYoLMB0i4z2fQV6IAT139jbcbWwkzCsgoB 6mJ9HKekL8oUYrSxjqYIqQAKbHe43TDPaOxSgt7lJj_cK1EVUWW54Z_4EMm2OKqJQv32gjg1opdF OrS5BBm8n5IHbGaIimwE2tVMUZTudrYhr1YzXwHuC908pkX7qepWP4_xg5Hnk_dBLfBiiTeYDdZO uQdNmzW_GkqVBgV9SySsaHs1on3tpSNHQnO5kvyhDlH6ARX_6i8e18ownRXEDFGeZvirmGm4b_KV c5oxRy7Ul10jn7beh1wiE47CA99WZRm3GTwLW9Blr5MfDmncY.Rb_L1_EC3Oe87GsuSXlE62YzLN NwgMFcxAz95zS9cvunCRFGKw4IHTO2KxbmO0lzIui0YoTv4uI3Sa7GJq4IVG52bNq8kl7pNiyIOI 2LEeD.VMuxZCNf0TkBkEMe5Gi98NN.fjsM9lt8SiOlZafJ6CNH1j.iNUZ.Q1rF7RtwA4KPsP8p1M ecwyjoT4Hj27GO6UnCt0ajI6rWiBGDxSHPPH7oPz5ueSNuTQL3rZK4DpQyNBR9Ki9bDeTchyb418 0Iou8.6gjwyEDTbk56VRZTp2tb49tj.xVtoXaNl78K X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Sun, 16 Oct 2022 04:32:41 +0000 Original-Received: by hermes--production-sg3-785466d859-htxsl (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0a8fd30afa77e67b7de1eff19d491ee6; Sun, 16 Oct 2022 04:32:36 +0000 (UTC) In-Reply-To: <0583C9C0-9953-414E-9F51-2AEFDF225BD9@stanford.edu> (Qiantan Hong's message of "Sat, 15 Oct 2022 23:33:32 +0000") X-Mailer: WebService/1.1.20740 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.186.206; envelope-from=luangruo@yahoo.com; helo=sonic310-25.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297825 Archived-At: Qiantan Hong writes: > Some existing code in xwidget.c use this naming as well. > Should I make a separate patch to fix those? No, I'd rather avoid extraneous style changes to existing contents of the file. At the very least it makes vc-annotate a pain. > Should I also include the fix to some capitalization error > and the runtime symbol usage in that same patch? BTW, there are many other problems with your patch, aside from capitalization and interning symbols with a static string. Please read through the entirety of my reply. > How do I mark it? I suggest linking each callback data struct into a list, each element of which is then marked in a "mark_xwidget" function that should be called by garbage_collect in alloc.c. > I=E2=80=99m imitating the usage pattern of what is already in nsxwidget.m. > I think if I=E2=80=99m leaking memory then the current code must also hav= e been > (which could be the case)... I guess that should be fixed. Thanks.