From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Average-user-facing interface for tree-sitter Date: Wed, 19 Oct 2022 07:35:51 +0200 Message-ID: <87edv4l6iw.fsf@thornhill.no> References: <3A7E7CD1-74A7-4352-9DFE-FC982EAA398E@gmail.com> <87ilko9r9e.fsf@gnus.org> <9794E2EF-4DB5-4A04-90F0-3EB51E6BE008@gmail.com> <87977C2D-844B-4F4E-BEA4-8BCBFC8AE354@gmail.com> <6A0F847F-910D-449B-B461-466493CC9847@gmail.com> <87sfjmg69q.fsf@gnus.org> <21B2ADDF-70BC-46D4-98D6-41C5D0EF7D40@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3970"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel To: Yuan Fu , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 19 07:37:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ol1lZ-0000lp-6Q for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 07:37:21 +0200 Original-Received: from localhost ([::1]:40590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ol1lX-00069q-Kw for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 01:37:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol1kL-0005NV-TN for emacs-devel@gnu.org; Wed, 19 Oct 2022 01:36:05 -0400 Original-Received: from out2.migadu.com ([2001:41d0:2:aacc::]:24674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol1kD-0000hg-8B for emacs-devel@gnu.org; Wed, 19 Oct 2022 01:36:05 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1666157754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MlcJ1SNK9H2lFNyHTdVZavgA06eyRDI3cbJ/uL/k1+Y=; b=sqz0byEuKwUsGha6COUsac4g5MEDRIavQY6qPskhTK6SZQvgkcMeWZDLJrS0Egs61z6EWn mYJfX8HK/tSTEf0HXY7yQagpBNMzi5FTUqcaM1i0hcR6UyJNE7gLuATwKKFgJrqY5a6Ynn s3IkqjRZmvLviHAhVRBrDf8cTrjiCvb8IXSL7bNveKEoXTWTh3kXOF3fai9KezGk+2Z3jm B9G1aJh9JlpIIvA3N/jE1cxYKauBk+wtOd+U2DO5iiztPKtXNhgVWCKLv1RoqcVwoXBc9S bSgjGBrVkyFmk2FnOU04s0Z4kz9nOSEUsmMOn0rEWwbkxp209VbOYllk6Jt9/g== In-Reply-To: X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=theo@thornhill.no; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298098 Archived-At: Hi Yuan! Yuan Fu writes: >>>=20 >>> And remove treesit-remapped-major-mode-alist? >>=20 >> That's I'd do, yes. >>=20 >> It's much easier to add features later (if they prove to satisfy >> a common need) than to remove unused features. >>=20 >> BTW, I see that `global-treesit-mode--turn-on` is currently a (non >> official) alias of `treesit-mode`, but I think it should only call >> `treesit-mode` in those buffers where there is some indication that the >> major mode provides some treesit-mode support (e.g., currently that >> could be if `major-mode-backend-function` is set). > > I=E2=80=99m changing it to what you described in another email. (So major= -mode-backend-function is goner). I can use treesit-font-lock-settings as t= he minimum criterion. > It seems we've had some regressions _after_ 851a8f65e9a6b00b51f6a41f4c8f2ec2a797862b, I presume with the major mode toggles, so font-locking has ceased to work properly. One thing I see is that the "warn" isn't a symbol in the new toggle mechanism, so it errors out. But even after that has been fixed it still doesn't work. Why would we want to init the whole js-mode if we already know that we don't want to use it? All the best, Theo