all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Theodor Thornhill via "Emacs development discussions." <emacs-devel@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>, Yuan Fu <casouri@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: tree-sitter branch broken
Date: Sat, 29 Oct 2022 10:26:15 +0200	[thread overview]
Message-ID: <87edurxcgo.fsf@thornhill.no> (raw)
In-Reply-To: <83bkpvhx0b.fsf@gnu.org>

Hi Eli!

> The current branch seems to be broken by the penultimate commit:
>
>     ELC      treesit.elc
>
>   In end of data:
>   treesit.el: Warning: the function `,' is not known to be defined.
>   make[3]: Leaving directory `/d/gnu/git/emacs/feature/lisp'
>   Function provided is already compiled
>   Function provided is already compiled
>   Function provided is already compiled
>   Function provided is already compiled
>   Function provided is already compiled
>
> It compiles cleanly if I revert the last two commits.
>

Yeah, this seems to be the culprit:

Feel free to apply if you want :-)

diff --git a/lisp/treesit.el b/lisp/treesit.el
index 264935f185..5c1cdf3a4d 100644
--- a/lisp/treesit.el
+++ b/lisp/treesit.el
@@ -724,10 +724,10 @@ treesit-simple-indent-presets
                     (and (or (null node-t)
                              (string-match-p
                               node-t (or (treesit-node-type node) "")))
-                         (or (null ,parent-t)
+                         (or (null parent-t)
                              (string-match-p
                               parent-t (treesit-node-type parent)))
-                         (or (null ,grand-parent-t)
+                         (or (null grand-parent-t)
                              (string-match-p
                               grand-parent-t
                               (treesit-node-type


-- 
Theo



  reply	other threads:[~2022-10-29  8:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-29  8:09 tree-sitter branch broken Eli Zaretskii
2022-10-29  8:26 ` Theodor Thornhill via Emacs development discussions. [this message]
2022-10-29 16:12   ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edurxcgo.fsf@thornhill.no \
    --to=emacs-devel@gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.