From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#59684: 29.0.50; [PATCH] package.el: Insert news for installed packages only Date: Tue, 29 Nov 2022 21:25:32 +0000 Message-ID: <87edtlbghf.fsf@posteo.net> References: <87mt89bhd2.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36979"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59684@debbugs.gnu.org To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 29 22:26:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p087P-0009Oj-AK for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Nov 2022 22:26:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p087C-0008Sj-0y; Tue, 29 Nov 2022 16:26:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0878-0008S3-Vt for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 16:26:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0878-0008DE-M1 for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 16:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0878-0000wt-Gz for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 16:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2022 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59684 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16697571433640 (code B ref -1); Tue, 29 Nov 2022 21:26:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Nov 2022 21:25:43 +0000 Original-Received: from localhost ([127.0.0.1]:56440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p086o-0000we-QD for submit@debbugs.gnu.org; Tue, 29 Nov 2022 16:25:43 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:53078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p086n-0000wY-Gp for submit@debbugs.gnu.org; Tue, 29 Nov 2022 16:25:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p086i-0008JB-Gs for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 16:25:38 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p086g-0008Af-0v for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 16:25:36 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B7C81240026 for ; Tue, 29 Nov 2022 22:25:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669757131; bh=qllyOSAQm88hYLzOEDYpmBHxwfkdAVOFndS3kCti7XM=; h=From:To:Cc:Subject:Date:From; b=KiHtAn3IYhwaPHM1057v1XGChT5HOZlX6FZa6M1FxUpjIsd9rxzNsrqEf+qIFCYFe d2kwHhFGUVjddIUR9xIqnRBout14ldx4c62+icSZ5JagF8I6UgW8mwyGp27FmGSkHc 12d+NdX9Pd12tkWGCZ06m44a6gnGYuIBwKvJZXSdNkGoMNIuCAP9+0vvz0poc3fWGl wXC1YOGO7T6NHw3mPzbEhwZJpqKr6JqhxI9EPmeeMPDX/mEfi2DU8I6VWyyKpAnszF +NPe7VzLHrU0SanWGH+VgKVc06u5o5Tqb6eVI3OMKKD3WGxhsUiR5MxPiA1RN+ILGs 7iifXipwijeDg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NMFk30nMTz9rxD; Tue, 29 Nov 2022 22:25:30 +0100 (CET) In-Reply-To: (Andrii Kolomoiets's message of "Tue, 29 Nov 2022 23:16:00 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249446 Archived-At: Andrii Kolomoiets writes: > Philip Kaludercic writes: > >>> + ((file-regular-p file))) >> >> Shouldn't we keep `file-readable-p'? > > I think we should use `file-regular-p' so even if the pkg-dir will > contain directory named "news" we will not try to insert it with > `insert-file-contents'. I agree that `file-regular-p' is sensible, what I meant was using `file-readable-p' in addition to that. But I guess that all in all, this is a rare circumstance...