From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#59888: [PATCH] Add 'grep-heading-mode' Date: Thu, 08 Dec 2022 11:28:55 +0100 Message-ID: <87edtadw9k.fsf@gmail.com> References: <9DED6125-13ED-4BF6-83A1-E1B2C4249F24@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25135"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59888@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 11:30:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3EAV-0006PD-2s for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 11:30:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3EAJ-0003YF-1z; Thu, 08 Dec 2022 05:30:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3EAE-0003Xt-L3 for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 05:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3EAE-0005kK-CD for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 05:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3EAE-0008Qn-3o for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 05:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59888-submit@debbugs.gnu.org id=B59888.167049534632361 (code B ref 59888); Thu, 08 Dec 2022 10:30:02 +0000 Original-Received: (at 59888) by debbugs.gnu.org; 8 Dec 2022 10:29:06 +0000 Original-Received: from localhost ([127.0.0.1]:55903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3E9K-0008Pt-7D for submit@debbugs.gnu.org; Thu, 08 Dec 2022 05:29:06 -0500 Original-Received: from mail-ej1-f47.google.com ([209.85.218.47]:42643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3E9I-0008PN-3S for 59888@debbugs.gnu.org; Thu, 08 Dec 2022 05:29:04 -0500 Original-Received: by mail-ej1-f47.google.com with SMTP id n21so2772943ejb.9 for <59888@debbugs.gnu.org>; Thu, 08 Dec 2022 02:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CnFPYfPYVCBiXm3Jltcch1lsEefLy/bJ+nOVfNlJFNY=; b=e9LfHEiEGJc2FrE19KWR1AcTe38mpPCbUj6K6t9tvWrtDKmJIVPbXpy4MLRmDM2AAf ANCCEMzBOpTOd2sQU/F+YunBEVKnfB5XYZfAx3AgAG0hAITBFIR+hTJDnUK4Yhu99zLY SHwkMu8TDxpziMzaiZqC//kk4nXQJ95GgFyp/WXE2ou/zYTrBPHDNq9Ww1S+vffjE7gO c+3SJUacK9vUBuKp5Cf/M+cojp3YkjsWU+l26NOrwNcsUUwHcaXgKX2lbfRhyRahBW5s 3bgwC398GJ6hsMbkZKtk3fJFF4kit6rp45uBTaTvw2UplRGirTVECgAUuEDdBj0LWG/B I9VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CnFPYfPYVCBiXm3Jltcch1lsEefLy/bJ+nOVfNlJFNY=; b=a9h+B+XMUYm3LQ1IcpSyzsLQnWxdz9sRouxScr+xXNbusiHGgu/t3U9ifJ6uccnh9Z CzawDGE9WYgSWtg1f0c5Q25mDwnMFW0x2Pz2Og2R6Uo+xpoFgjTL6BfHI2OOdOUNPd0g akee918gSJTVdMQnzALj7LNA1VJ+5rIbzDFb1B9vCuNiTFd19mXKPTk9TRDzviMHgfgx wuwZluro2tne/u5HkN7vV1/udoyS5Sgv0DLE+Q/zeXZ8DL1BIf0+wYI6OKGk7lKhiVal 2RiChT42BoSX6CQsdGciq+/kXOcmqWdGWMA3jPN8BYdLExa5E83ekr8ElpVMzlzA3wIF B7+A== X-Gm-Message-State: ANoB5pmvUUck1L6aHSozYhzYC4gaE109fnNzX8yNwaXvmdQ5hRSfJWCv HQ/Sq63Q4WovCuXVMT+ci+cYojzvQV/2BA== X-Google-Smtp-Source: AA0mqf410xXGReoMfLl6eHGO5tAmSAii/TErELdCCjghnjGJYYs8JXw3AK/b7QixJKhhb91tgWvPCg== X-Received: by 2002:a17:907:7613:b0:7c1:5a7:b91c with SMTP id jx19-20020a170907761300b007c105a7b91cmr9423584ejc.749.1670495337739; Thu, 08 Dec 2022 02:28:57 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::a4bf]) by smtp.gmail.com with ESMTPSA id ce11-20020a170906b24b00b007ae38d837c5sm9608245ejb.174.2022.12.08.02.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 02:28:56 -0800 (PST) In-Reply-To: <9DED6125-13ED-4BF6-83A1-E1B2C4249F24@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Thu, 8 Dec 2022 10:57:59 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250265 Archived-At: On Thu, 8 Dec 2022 at 10:57, Mattias Engdeg=C3=A5rd wrote: > No argument about the idea (good to me) or implementation but minor point= s regarding the regexp: > >> + (group-n 1 (+? any)) > > Very much prefer `nonl` or `not-newline` to `any`, which is only there fo= r compatibility (shouldn't have been included in the first place). Hum, not-newline is too long, so this leaves an option between the slightly deceiving and the quite obscure. Okay, now I see `any' is not even documented. >> + (any "\0-:=3D")) > > Is the range (ASCII 00..1A) intended here, or should that be a literal hy= phen? > If the former, it should probably be made more explicit since that > range includes all sorts of numbers, symbols and control chars and it > kind of looks like it may be a mistake. The literal hyphen, which prefixes context lines in `grep -C '. Thanks for the heads up.