Re: [PATCH] oc-basic.el: Fix wrong type for the editors field when parsing JSON.

[Ihor Radchenko <yantar92@posteo.net>]

Hugo Cisneros <hmj.cisneros@gmail.com> writes:

> I use org-cite with a JSON bibliography and noticed a bug when an entry only has
> an "editors" field but no "authors" field. The function
> `org-cite-basic—get-author' correctly falls back to using the editors instead of
> the authors, but `org-cite-basic--parse-json’ stringifies only the "authors"
> field and not the "editors." This creates an error when other functions assume
> they got a string from `org-cite-basic—get-author'. The patch fixes the issue by
> applying the same transformation to both "authors" and "editors".

Thanks!
Applied onto bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=318807013
Use are now also listed as an Org contributor.
https://git.sr.ht/~bzg/worg/commit/c2bb6a52

> As explained in the ChangeLog entry, this points to a more general issue where
> `org-cite-basic--get-field' is expected to return nil or a string, but calls
> `org-cite-basic--get-entry' that may return an association list. I am not sure
> how to fix that since it means converting anything that
> `org-cite-basic--get-entry' may return into a string.

Non-string can only be for JSON bibliographies for fields that are not
supported. `org-cite-basic--get-field' can probably return nil in such
scenarios.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>