From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
To: Mou Tong <mou.tong@outlook.com>
Cc: "62536@debbugs.gnu.org" <62536@debbugs.gnu.org>
Subject: bug#62536: 30.0.50; Can we add """ ... """ electric pair in elixir, just like python
Date: Sun, 02 Apr 2023 21:24:24 +0200 [thread overview]
Message-ID: <87edp2vzvg.fsf@gmail.com> (raw)
In-Reply-To: <87bkk642k0.fsf@gmail.com>
> Mou Tong <mou.tong@outlook.com> writes:
>
>>> Will it make sense to also add a newline when closing a
>>> multiline
>>> comment/heredoc? It feels smoother to me rather than having to
>>> press
>>> enter and then C-o ( open-line ) to position the cursor
>>> correctly?
>>
>> I agree with you, but I think it might be better to imitate
>> what
>> `c-mode` did:
>>
>> ```c
>> int main () {|}
>> ```
>>
>> When `electric-pair-mode` is on, input the left `{`, Emacs
>> helps you
>> complete the right `}`. After press enter, your cursor will
>> move to
>> the
>> next line and auto-indented according to your offset config:
>>
>> ```c
>> int main () {
>> |
>> }
>> ```
>>
>> So how about making it work like this?
>>
>> ```elixir-ts
>> @doc """|"""
>>
>> # after press enter
>> @doc """
>> |
>> """
>> ```
>
> Yes, I think that is better, let me have a go at it. I was
> concerned
> of doing unsolicited movement with my suggestion of inserting
> newlines.
Playing around with it I think we should add a newline, I changed
my mind.
Unlike the c example above, the following syntax is not valid
elixir: `""""""` and it requires a
newline to make it valid. Part of the appeal of making the
heredoc electric is to keep
the syntax valid. There should never be a reason for the heredoc
to be
on a single line and also makes the tree-sitter grammar invalid,
which
causes the blinking issue.
This will mean:
```
@doc ""|
```
when typing `"` it will insert `\n"""` and thus have the minimal
valid elixir
syntax without doing extra movement.
```
@doc """|
"""
```
This will be the change ( looking at the electric.el code ).
next prev parent reply other threads:[~2023-04-02 19:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 4:25 bug#62536: 30.0.50; Can we add """ ... """ electric pair in elixir, just like python 牟 桐
2023-03-30 5:44 ` Eli Zaretskii
2023-03-30 6:19 ` Wilhelm Kirschbaum
2023-03-30 8:25 ` bug#62536: 回复: " Mou Tong
2023-04-02 7:49 ` Wilhelm Kirschbaum
2023-04-02 16:38 ` Mou Tong
2023-04-02 17:21 ` Wilhelm Kirschbaum
2023-04-02 19:24 ` Wilhelm Kirschbaum [this message]
2023-04-03 2:41 ` Mou Tong
2023-04-03 8:26 ` Wilhelm Kirschbaum
2023-04-03 9:42 ` bug#62536: 回复: " Mou Tong
2023-04-03 10:38 ` Wilhelm Kirschbaum
2023-04-03 12:02 ` João Távora
2023-04-03 12:08 ` Wilhelm Kirschbaum
2023-04-03 14:02 ` Eli Zaretskii
2023-04-03 14:17 ` Wilhelm Kirschbaum
2023-04-03 14:38 ` Eli Zaretskii
2023-04-04 5:39 ` Wilhelm Kirschbaum
2023-04-04 9:08 ` João Távora
2023-04-04 17:54 ` Wilhelm Kirschbaum
2023-04-04 18:39 ` João Távora
2023-04-04 19:03 ` Wilhelm Kirschbaum
2023-04-04 19:46 ` Wilhelm Kirschbaum
2023-04-04 20:29 ` Wilhelm Kirschbaum
2023-04-05 13:09 ` João Távora
2023-04-05 14:33 ` João Távora
2023-04-05 17:28 ` Wilhelm Kirschbaum
2023-04-06 0:17 ` João Távora
2023-04-06 5:39 ` Wilhelm Kirschbaum
2023-04-06 10:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edp2vzvg.fsf@gmail.com \
--to=wkirschbaum@gmail.com \
--cc=62536@debbugs.gnu.org \
--cc=mou.tong@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.