all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 62620-done@debbugs.gnu.org, Wilson Snyder <wsnyder@wsnyder.org>
Subject: bug#62620: 30.0.50; Unused unwind-protect in verilog-mode
Date: Tue, 18 Apr 2023 11:25:07 +0100	[thread overview]
Message-ID: <87edohv664.fsf@tcd.ie> (raw)
In-Reply-To: <CD612F4C-A8FC-4C47-97D6-7E109D51E465@acm.org> ("Mattias Engdegård"'s message of "Tue, 4 Apr 2023 11:57:17 +0200")

close 62620 30.1
quit

Mattias Engdegård [2023-04-04 11:57 +0200] wrote:

> 2 apr. 2023 kl. 18.39 skrev Basil Contovounesios <contovob@tcd.ie>:
>
>> -    (with-temp-buffer "*Verilog-Diff*"
>
> That's a nice catch. I didn't find any other instance of that particular mistake in Emacs; there is one in GNU ELPA (sketch-mode.el).

Thanks for checking.
I can submit a patch there later if no-one beats me to it.

> (The patch looks superficially fine to me but I haven't actually tested it.)

Thanks, now pushed:

Fix verilog-diff-file-with-buffer
0d2fdf6e36d 2023-04-18 11:14:38 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=0d2fdf6e36d

Hopefully Wilson gets a chance to look at and upstream the patch soon.

-- 
Basil





  reply	other threads:[~2023-04-18 10:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-02 16:39 bug#62620: 30.0.50; Unused unwind-protect in verilog-mode Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-04  9:57 ` Mattias Engdegård
2023-04-18 10:25   ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-04-21 12:18     ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-21 14:21       ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edohv664.fsf@tcd.ie \
    --to=bug-gnu-emacs@gnu.org \
    --cc=62620-done@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=mattiase@acm.org \
    --cc=wsnyder@wsnyder.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.