From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function. Date: Tue, 06 Jun 2023 12:10:05 +0100 Message-ID: <87edmog836.fsf@melete.silentflame.com> References: <83r0qq3zo3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34129"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 06 13:11:26 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6Uay-0008dt-1n for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Jun 2023 13:11:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6UZq-0002rZ-88; Tue, 06 Jun 2023 07:10:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6UZo-0002rO-6C for emacs-devel@gnu.org; Tue, 06 Jun 2023 07:10:12 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6UZm-00087Q-IX; Tue, 06 Jun 2023 07:10:11 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B6EA45C01A1; Tue, 6 Jun 2023 07:10:07 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 06 Jun 2023 07:10:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1686049807; x= 1686136207; bh=eWy6C7YiAfIEghrQG44p276zAsoxVERHcpWKkzGaGc4=; b=m Rn1oQZOtFChNtnTWiMt5OBSQsxg8n1ntzIkfTHq3qafyZtJhyamkOWOyPnlyxMF5 3BM8IQpp6CNs4pM99UGsw92CCSW8+icnMupwyal3piCb87fNm24C+rYGh/w6VlDx DURbY4ELax2Hnxv/bts9zaDIbAPXyVkaHXEuvtDp/LYe8BdB2HJdcGR0FteHT9ra j3NbTcgOkD/vKQuXS4N9m4mHPVsCwZxGe1HnJTQYFfsBlZwYr1Y84WImUIfL6zAH OkJuRLww0EV6nvM44xkpM8jdGSvFSHyqXb87mFISUcy7k0X66OZw53qyLRij3HbQ UXOdeV4876pMofDZ/u10A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1686049807; x=1686136207; bh=eWy6C7YiAfIEg hrQG44p276zAsoxVERHcpWKkzGaGc4=; b=skhWy6T0WnIn+i0OlqAbJfjm9V4/W Wj+QaTFYw/De5l0zoopVoCfCBZEXw4soAEHUaJpLdaABmX8wOSpwQEBoA1W6jJQP bMmEUuzE+EXs4LmKnaOsJRgAA+fwlv5WIFLy/RSAqf3pZC0OLnJgsrAfVVNJKylZ R4XBSp7/5dRZuH4y3D4KHXbQDHXbUPx7vaBsXoC5j3FXc/CaBK2mZRPMzzPjokQs IFS5L9Vh/zJme59MnDTYmSDwQOrDp7Cuv+MeIdhEM0nRtnzXwvKCBzCUpyZRa8pH OBTFUBhXHgrUEU1dwohNSHbA5oRdI3fA2N+IX0QTEdome5DNDRBsorSwA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtuddgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Jun 2023 07:10:07 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id E47137E4CF1; Tue, 6 Jun 2023 12:10:05 +0100 (BST) In-Reply-To: <83r0qq3zo3.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 05 Jun 2023 14:40:28 +0300") Received-SPF: pass client-ip=66.111.4.27; envelope-from=spwhitton@spwhitton.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306661 Archived-At: Hello, On Mon 05 Jun 2023 at 02:40PM +03, Eli Zaretskii wrote: > Thanks for working on this, but please document this new function in > the ELisp manual. It is important enough to be mentioned there. > > In the future, please always accompany user-visible changes with > suitable changes to one or both of our manuals, to make sure the > manuals are kept up-to-date at all times. I know to do this in general, but in this case the new function is in subr-x, and my understanding was that functions in that file are not to be documented in any manuals. Are you suggesting I move it to subr.el? > Also, the changeset touches 3 files, but only one of them is mentioned > in the log message; please avoid this in the future. (I'm not really > sure why you needed the change to nadvice.el, FWIW.) I should have documented the new FIXME, my apologies. Regarding NEWS, CONTRIBUTE says There is no need to mention files such as NEWS and MAINTAINERS, or to indicate regeneration of files such as 'lib/gnulib.mk', in the ChangeLog entry. "There is no need" means you don't have to, but you can if you want to. Should that text perhaps be updated? > As for the name of the new function: what do people think about > renaming it to eval-interactive-spec? I don't think we need the > "command" part. In that case, what would we rename advice-eval-interactive-spec to, when we drop the 'advice-' prefix? -- Sean Whitton