From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#63861: [PATCH] pp.el: New "pretty printing" code Date: Wed, 07 Jun 2023 14:10:22 +0000 Message-ID: <87edmnics1.fsf@posteo.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39628"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca To: 63861@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 07 16:11:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6tsc-000A54-IW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Jun 2023 16:11:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6tsQ-00087v-4J; Wed, 07 Jun 2023 10:11:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6tsM-00085n-Fh for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 10:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6tsM-00027F-7E for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 10:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6tsL-0002lr-OF for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 10:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Jun 2023 14:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: 63861@debbugs.gnu.org, Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.168614704210615 (code B ref -1); Wed, 07 Jun 2023 14:11:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Jun 2023 14:10:42 +0000 Original-Received: from localhost ([127.0.0.1]:54461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6ts2-0002l9-1W for submit@debbugs.gnu.org; Wed, 07 Jun 2023 10:10:42 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:54882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6ts0-0002kw-DT for submit@debbugs.gnu.org; Wed, 07 Jun 2023 10:10:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6ts0-0007u0-54 for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 10:10:40 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6trx-0001yP-RP for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 10:10:39 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 66ED024002A for ; Wed, 7 Jun 2023 16:10:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686147034; bh=DpDLfIdDiVbDjZTvK6GG31VMNZfkeQQfiKzxAnS2Mv0=; h=From:MIME-Version:To:Cc:Subject:Date:Message-ID:Autocrypt:OpenPGP: From; b=Q3HsHYcz+8zL9M7vKnURHeJXnNH+zj9o/DxlZfmuFkc+8cQN8JN2S1gD9LssfDPyg 9QqFW5f9iX46pTbWABMOpUvTXT8pE7N1yUbljAzf1wMI3V9rQjKCtdFXrykV7BhpS2 YuV9xSuphjNxBvF28mFUXgQG+gLBY0wuEfxlV7wiWlezXU53Cv1pI01fOXMoGx37LD 0H3N2maTSSqT45liflvXiiv19bLqH53/iK8Yhxinhv8h5Tk+yR2pJeuPBazFIZyBAQ pPt9BMaCpojq7IXBevz0TQn4sSZ/N0p8H2vFwC+prJ8AQw+j/MfqQqYGkDdjSM3K49 o9ooItLnZJyew== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qbq4T1M7bz6tvp; Wed, 7 Jun 2023 16:10:32 +0200 (CEST) In-Reply-To: (Stefan Monnier via's message of "Fri, 02 Jun 2023 18:50:57 -0400") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MAedi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0pkcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfbtG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQGVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqCWcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEAAc0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8hBp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslxhU46VSz1Z83NwIG3mpdYNV5WUTUdgzx ExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263074 Archived-At: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Tags: patch > > I've often been annoyed by the way `ielm` "pretty prints" data, > so I wrote my own pretty printer, which has evolved over the years. > I believe it has finally reached a state which may be acceptable > to more than just myself. > > The new code is in a new function `pp-region`. > The old code redirects to the new code if `pp-buffer-use-pp-region` is > non-nil, tho I'm not sure we want to bother users with such > a config var. Hopefully, the new code should be good enough that users > don't need to choose. Maybe I should make it a `defvar` and have it > default to t, so new users will complain if it's not good enough? I tried your code and it looks very slow (but looks nice once printed). Testing on my bookmark-alist printed in some buffer. Here with a slightly modified version of pp-buffer (not much faster than the original one): (benchmark-run-compiled 1 (pp-buffer)) => (6.942135047 0 0.0) And here with your version (using pp-region): (benchmark-run-compiled 1 (pp-buffer)) => (46.141411097 0 0.0) For describe variable I use a modified version of `pp` which is very fast (nearly instant to pretty print value above) but maybe unsafe with some vars, didn't have any problems though, see https://github.com/thierryvolpiatto/emacs-config/blob/main/describe-variable.el. > > Stefan > > > In GNU Emacs 30.0.50 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo > version 1.16.0, Xaw3d scroll bars) of 2023-05-24 built on pastel > Repository revision: 41b6b907d4cf2f8c302647dc63c5d9c94f9f01d6 > Repository branch: work > Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 > System Description: Debian GNU/Linux 11 (bullseye) > > Configured using: > 'configure -C --enable-checking --enable-check-lisp-object-type --with-modules --with-cairo --with-tiff=ifavailable > 'CFLAGS=-Wall -g3 -Og -Wno-pointer-sign' > PKG_CONFIG_PATH=/home/monnier/lib/pkgconfig' > > -- Thierry