From: Michael Albinus <michael.albinus@gmx.de>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: 64064@debbugs.gnu.org
Subject: bug#64064: [PATCH 3/4] Don't sort bugs in 'debbugs-gnu-show-reports'.
Date: Fri, 16 Jun 2023 12:26:03 +0200 [thread overview]
Message-ID: <87edmbn1ok.fsf@gmx.de> (raw)
In-Reply-To: <DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@DM5PR03MB3163.namprd03.prod.outlook.com> (Morgan Smith's message of "Wed, 14 Jun 2023 08:15:57 -0400")
Morgan Smith <Morgan.J.Smith@outlook.com> writes:
> Everything is automatically sorted by 'tabulated-list-mode' according to
> 'tabulated-list-sort-key' which we already set to the id.
>
> * debbugs-gnu.el (debbugs-gnu-show-reports): Don't sort the bugs.
> ---
> debbugs-gnu.el | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/debbugs-gnu.el b/debbugs-gnu.el
> index c28a4aa5e4..c65ea3e827 100644
> --- a/debbugs-gnu.el
> +++ b/debbugs-gnu.el
> @@ -923,7 +923,6 @@ are taken from the cache instead."
>
> ;; Print bug reports.
> (dolist (status
> - (sort
> (let ((debbugs-cache-expiry (if offline nil debbugs-cache-expiry))
> ids)
> (apply #'debbugs-get-status
> @@ -933,11 +932,7 @@ are taken from the cache instead."
> (push key ids))
> debbugs-cache-data)
> ids)
> - (debbugs-gnu-get-bugs debbugs-gnu-local-query))))
> - ;; Sort so that if a new report gets merged with an old
> - ;; report, it shows up under the new report.
> - (lambda (s1 s2)
> - (> (alist-get 'id s1) (alist-get 'id s2)))))
> + (debbugs-gnu-get-bugs debbugs-gnu-local-query)))))
> (let* ((id (alist-get 'id status))
> (words (cons (alist-get 'severity status)
> (alist-get 'keywords status)))
Have you tested that the use case mentioned in the comment still works?
Best regards, Michael.
next prev parent reply other threads:[~2023-06-16 10:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 12:15 bug#64064: [PATCH 0/4] debbugs improvements Morgan Smith
2023-06-16 8:50 ` Michael Albinus
[not found] ` <DM5PR03MB3163BD5C32B57C2C6860B7B6C558A@DM5PR03MB3163.namprd03.prod.outlook.com>
2023-06-16 16:57 ` Morgan Smith
2023-06-16 17:04 ` Michael Albinus
2023-06-16 10:16 ` bug#64064: [PATCH 1/4] Call 'tabulated-list-print-entry' in 'debbugs-gnu-print-entry' Michael Albinus
2023-06-18 10:11 ` bug#64064: [PATCH 0/4] debbugs improvements Michael Albinus
2023-06-18 19:26 ` Morgan Smith
2023-06-16 10:22 ` bug#64064: [PATCH 2/4] Don't error out on 'nil' alist value Michael Albinus
2023-06-16 16:49 ` Morgan Smith
2023-06-18 11:14 ` Michael Albinus
2023-06-16 10:26 ` Michael Albinus [this message]
2023-06-16 16:56 ` bug#64064: [PATCH 3/4] Don't sort bugs in 'debbugs-gnu-show-reports' Morgan Smith
2023-06-18 11:52 ` Michael Albinus
2023-06-18 19:22 ` Morgan Smith
2023-06-19 7:40 ` Michael Albinus
2023-06-16 10:34 ` bug#64064: [PATCH 4/4] Add 'debbugs-gnu-rescan' to 'tabulated-list-revert-hook' Michael Albinus
2023-06-18 11:50 ` Michael Albinus
2023-06-16 10:37 ` bug#64064: [PATCH 0/4] debbugs improvements Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edmbn1ok.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=64064@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.