From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.bugs Subject: bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections Date: Thu, 13 Jul 2023 22:39:10 +0000 (UTC) Message-ID: <87edlbjv1u.fsf@catern.com> References: <875y72ieq8.fsf@catern.com> <87cz193eno.fsf@yahoo.com> <87jzvgse4k.fsf@yahoo.com> <87pm58phyu.fsf@catern.com> <87y1jwqqel.fsf@yahoo.com> <87mt0bq4py.fsf@catern.com> <87mt06mk7w.fsf@catern.com> <831qhicpsy.fsf@gnu.org> <83zg46b8fa.fsf@gnu.org> <87zg45ex48.fsf@yahoo.com> <83h6qdbong.fsf@gnu.org> <87sf9xehph.fsf@yahoo.com> <83cz11bn0g.fsf@gnu.org> <87wmz5j5vn.fsf@catern.com> <83pm4w5sdp.fsf@gnu.org> <87jzv3kcpw.fsf@catern.com> <83o7kf4pvs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21135"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, sbaugh@janestreet.com, 64423@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 14 00:40:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qK4ys-0005HO-TH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jul 2023 00:40:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qK4yi-0003Wz-EI; Thu, 13 Jul 2023 18:40:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK4yg-0003W3-Lj for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 18:40:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qK4yg-0004XU-Ct for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 18:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qK4yf-00012r-Oc for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 18:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 22:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64423 X-GNU-PR-Package: emacs Original-Received: via spool by 64423-submit@debbugs.gnu.org id=B64423.16892879583957 (code B ref 64423); Thu, 13 Jul 2023 22:40:01 +0000 Original-Received: (at 64423) by debbugs.gnu.org; 13 Jul 2023 22:39:18 +0000 Original-Received: from localhost ([127.0.0.1]:41010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK4xy-00011l-A4 for submit@debbugs.gnu.org; Thu, 13 Jul 2023 18:39:18 -0400 Original-Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]:1384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK4xw-00011W-4r for 64423@debbugs.gnu.org; Thu, 13 Jul 2023 18:39:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: cc:content-type:from:subject:to; s=s1; bh=Nevp6FkSxI/pBJdLKaEyvnR+jgxag3btCgE0bUAAiLE=; b=N9LAOQeElFcNgtmsv8xe0PT4KNK4eD6p1oUOOIj6Dk4z6rkBJvuGxq72vwPUfpkEiLG+ P7TKQw81/3qp1IBKwr4Ur1ZU9du5o+6sw2gzkDvAhrWREo7k4q7Irv0cNrDYbLI9K8pi6T 8YZMEBGUQlBWXaSmDV9jcz3Ii7gTkP8QovGIPtbBf4JIfsgL4GpH3TVJ9zMv5Yd2RRhpFk Cg3QzoLbq9yyJKHpHo6yJa5LUyKXbP4o+BNiTzxr2+8dqynSDtPkCRpwYrhUs8iEQG++AK cV7vf5SSCbZhiJYoOwukAPxaGKPIqcIB1L82XR1CFVP3QkreDQLHL9H5fnsDsFtw== Original-Received: by filterdrecv-66949dbc98-s5rnx with SMTP id filterdrecv-66949dbc98-s5rnx-1-64B07D0E-17 2023-07-13 22:39:10.594367626 +0000 UTC m=+5525973.671765098 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-19 (SG) with ESMTP id vqsEwZsDQteRqO3iY_dnvw Thu, 13 Jul 2023 22:39:10.543 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=gnu.org Original-Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 047AB60075; Thu, 13 Jul 2023 18:39:09 -0400 (EDT) In-Reply-To: <83o7kf4pvs.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Jul 2023 21:39:51 +0300") X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbJ7eovYVBy+uIkYc+0Ipa1kHCGzSKLBcWXSCwu6rwJmQO6litoNcVw/9ac/nSvrqM8HyKUSrJtSD28E2nrZovMF90ST1psUDUtJvfBHZ8V0BEBj7gG5iHILxNEyM5Q+fxSgHLxa2sFIvkG39JiENzqF9zqXbsSXTHkiFxBmzrk1uA== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265053 Archived-At: --=-=-= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Eli Zaretskii writes: >> From: sbaugh@catern.com >> Date: Thu, 13 Jul 2023 16:17:32 +0000 (UTC) >> Cc: luangruo@yahoo.com, sbaugh@janestreet.com, 64423@debbugs.gnu.org >> >> > You can do it in a way that is not objectionable to either of us. It >> > is very simple: make the changes conditioned on X. >> >> OK, how about this? >> >> modified lisp/simple.el >> @@ -5618,8 +5618,11 @@ kill-new >> (if (fboundp 'menu-bar-update-yank-menu) >> (menu-bar-update-yank-menu string (and replace (car kill-ring))))) >> (when save-interprogram-paste-before-kill >> - (let ((interprogram-paste (and interprogram-paste-function >> - (funcall interprogram-paste-function)))) >> + (let ((interprogram-paste >> + (and interprogram-paste-function >> + (if (eq (window-system) 'x) >> + (ignore-error 'quit (funcall interprogram-paste-function)) >> + (funcall interprogram-paste-function))))) >> (when interprogram-paste >> (setq interprogram-paste >> (if (listp interprogram-paste) > > Fine by me, but please add a comment there explaining why we do that > on X. > > Thanks. OK, comment added, here's the patch. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Ignore-quit-while-getting-interprogram-paste-in-kill.patch >From 4d669af4c6273d5c7ca229353c5056e3969f84ae Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Sat, 8 Jul 2023 12:36:22 -0400 Subject: [PATCH] Ignore quit while getting interprogram paste in kill-new On X, if the current selection owner is not responding to selection requests, the user may want to take ownership of the selection. The obvious way to do this is to kill some text (which a user might also be doing just as part of normal editing at the time the selection owner becomes nonresponsive). However, if save-interprogram-paste-before-kill is non-nil, then killing text will hang until the user quits, and this quit will abort the entire kill-new, preventing the user from taking ownership of the selection. Now instead if the user quits while we are attempting to retrieve the selection from hanging owner, we will proceed to take ownership of the selection as normal, resolving the problem. (One example of a selction owner that might not be responding to selection requests is another instance of Emacs itself; while Emacs is blocked in call-process or Lisp execution, it currently does not respond to selection requests.) * lisp/simple.el (kill-new): Ignore quit while getting interprogram paste (bug#64423) --- lisp/simple.el | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index 26944f1f72d..b97b5dd1725 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -5618,8 +5618,14 @@ kill-new (if (fboundp 'menu-bar-update-yank-menu) (menu-bar-update-yank-menu string (and replace (car kill-ring))))) (when save-interprogram-paste-before-kill - (let ((interprogram-paste (and interprogram-paste-function - (funcall interprogram-paste-function)))) + (let ((interprogram-paste + (and interprogram-paste-function + ;; On X, the selection owner might be slow, so the user might + ;; interrupt this. If they interrupt it, we want to continue + ;; so we become selection owner, so this doesn't stay slow. + (if (eq (window-system) 'x) + (ignore-error 'quit (funcall interprogram-paste-function)) + (funcall interprogram-paste-function))))) (when interprogram-paste (setq interprogram-paste (if (listp interprogram-paste) -- 2.41.0 --=-=-=--