From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Thu, 13 Jul 2023 17:19:29 +0000 Message-ID: <87edlbd90e.fsf@localhost> References: <877cr4nez9.fsf@localhost> <83v8eo3pfv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7916"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 19:20:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJzzI-0001tV-NZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 19:20:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJzz2-00015e-BU; Thu, 13 Jul 2023 13:20:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJzz0-00015G-RA for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 13:20:02 -0400 Original-Received: from [2001:470:142:5::43] (helo=debbugs.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJzz0-0000V5-Ix for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 13:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJzz0-0006Wr-FS for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 13:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168926877625057 (code B ref 64596); Thu, 13 Jul 2023 17:20:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 13 Jul 2023 17:19:36 +0000 Original-Received: from localhost ([127.0.0.1]:40756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJzya-0006W5-Ej for submit@debbugs.gnu.org; Thu, 13 Jul 2023 13:19:36 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:52301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJzyW-0006Vp-36 for 64596@debbugs.gnu.org; Thu, 13 Jul 2023 13:19:35 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 34995240028 for <64596@debbugs.gnu.org>; Thu, 13 Jul 2023 19:19:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689268766; bh=fmt0hcUb1GkiNOz1pK0KA4HxG4lG8uhkhmP2/dphF18=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=PUIGMKaadePgYs5/aLf32Wxto0Hp5T807+CNrF6h6MN7bQO+CgaIWfR5QDbMwEZWS tdv4431iP+v2fPniG30EPiADrTnpmCULs1ufb0ArtjunqIwgP/W9XrwGSdRhDdABR1 dF6nzKHatXN+R6Q6BGnggCgvRm2QREAfQ4Kk20BEcAOGjN4NM1Yfc4vqssEv1sQMmB T0cksgV/00VyQ6kAIyMoyjE3M4uqBaLb3/6vnYnmfnGu+bOO2Eoqk1lApE8Ybe64by O27KY0MP/Rh17WfFB06nHeisByppKPDbMYjpczk3QDFroMf9LYLyiuKIUXuZHhrIGC moyR2j5fxVI2A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R21Yn0N46z9rxB; Thu, 13 Jul 2023 19:19:24 +0200 (CEST) In-Reply-To: <83v8eo3pfv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265033 Archived-At: Eli Zaretskii writes: >> If my understanding is correct, >> current_buffer->prevent_redisplay_optimizations_p = true does not belong >> to `force-mode-line-update', but rather to `restore-buffer-modified-p'. > > The purpose of force-mode-line-update is to do what its name says, > regardless of whether the buffer was modified or not, and how it was > modified. The idea is that Lisp programs which change something that > they know must affect the mode line call this function to make sure > the mode line is redrawn with up-to-date information. I do not claim that I fully understand, but what is confusing is that a number of other places in code simply use bset_update_mode_line without disabling optimizations. In particular: 1. kill-all-local-variables 2. rename-buffer Also, `force-window-update' disable optimizations for a given window, but not when all windows should be updated - in contrast with the code in OP. So, `force-window-update' and `force-mode-line-update' are at least inconsistent. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at