Re: [BUG] [PATCH] Add yank-media and DND handler [9.6.7 (9.6.7-g6eb773 @ /home/viz/lib/emacs/straight/build/org/)]

[Ihor Radchenko <yantar92@posteo.net>]

Thanks!

> +(defun org--dnd-attach-file (url action)
> ...
> +    (insert
> +     (org-link-make-string
> +      (concat (if separatep
> +                  "file:"
> +                "attachment:")
> +              (if separatep
> +                  (expand-file-name (file-name-nondirectory filename)
> +                                    org-yank-image-save-type)
> +                (file-name-nondirectory filename))))
> +     "\n")
> +    'private))

> +    (pcase org--dnd-xds-method
> +      (`attach (insert (org-link-make-string
> +                        (concat "attachment:" (file-name-nondirectory filename)))

> +      (`file-link (insert (org-link-make-string (concat "file:" filename))
> +                          "\n"))

Is there any particular reason why you insert a newline after the image
link?

Also, we might want to add a subsection describing the new customization to
17 Miscellaneous section of the manual. Otherwise, users might have
difficulties discovering relevant settings to customize dnd and yank
behavior.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>