Re: master c933f5081fd 1/2: Permit XLFD names to exceed 255 characters

Re: master c933f5081fd 1/2: Permit XLFD names to exceed 255 characters

[Michael Albinus]

Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

Hi,

I know this commit happened some months ago, but I'm just in the process
to track errors on emba.gnu.org.

> branch: master
> commit c933f5081fdaadbe7192d2cc1f7e705f0b0fb842
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
>     (Ffont_xlfd_name): New arg LONG_XLFDs.  If t, return a
>     dynamically allocated XLFD.  All callers changed.

This results in the following error on emba:

--8<---------------cut here---------------start------------->8---
#12 1409. nsfont.m: In function 'nsfont_open':
#12 1409. nsfont.m:1038:36: error: too few arguments to function 'Ffont_xlfd_name'
#12 1409.  1038 |     font->props[FONT_NAME_INDEX] = Ffont_xlfd_name (font_object, Qnil);
#12 1409.       |                                    ^~~~~~~~~~~~~~~
--8<---------------cut here---------------end--------------->8---

See for example <https://emba.gnu.org/emacs/emacs/-/jobs/79588>. Could
you, please, fix this?

Thnaks, and best regards, Michael.

Re: master c933f5081fd 1/2: Permit XLFD names to exceed 255 characters

[Po Lu]

Michael Albinus <michael.albinus@gmx.de> writes:

> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
> Hi,
>
> I know this commit happened some months ago, but I'm just in the process
> to track errors on emba.gnu.org.
>
>> branch: master
>> commit c933f5081fdaadbe7192d2cc1f7e705f0b0fb842
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>>     (Ffont_xlfd_name): New arg LONG_XLFDs.  If t, return a
>>     dynamically allocated XLFD.  All callers changed.
>
> This results in the following error on emba:
>
> #12 1409. nsfont.m: In function 'nsfont_open':
> #12 1409. nsfont.m:1038:36: error: too few arguments to function 'Ffont_xlfd_name'
> #12 1409.  1038 |     font->props[FONT_NAME_INDEX] = Ffont_xlfd_name (font_object, Qnil);
> #12 1409.       |                                    ^~~~~~~~~~~~~~~
>
> See for example <https://emba.gnu.org/emacs/emacs/-/jobs/79588>. Could
> you, please, fix this?
>
> Thnaks, and best regards, Michael.

Thank for spotting this.  It's not possible for me to install this at
the moment, so could you please replace that statement with:

  ... = Ffont_xlfd_name (font_object, Qnil, Qnil);

?

Re: master c933f5081fd 1/2: Permit XLFD names to exceed 255 characters

[Michael Albinus]

Po Lu <luangruo@yahoo.com> writes:

Hi,

> Thank for spotting this.  It's not possible for me to install this at
> the moment, so could you please replace that statement with:
>
>   ... = Ffont_xlfd_name (font_object, Qnil, Qnil);

Done. Best regards, Michael.