From: "J.P." <jp@neverwas.me>
To: 62474-done@debbugs.gnu.org
Subject: bug#62474: 29.0.60; wrong-type-argument from pcomplete-opt
Date: Thu, 18 Jan 2024 15:18:42 -0800 [thread overview]
Message-ID: <87edee1b8t.fsf@neverwas.me> (raw)
In-Reply-To: <87v8int08v.fsf@neverwas.me> (J. P.'s message of "Sun, 26 Mar 2023 19:08:00 -0700")
"J.P." <jp@neverwas.me> writes:
> Hi, this may be related to (or a duplicate of):
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59750
>
> I first encountered it in ERC, but it appears to happen from any
> pcomplete/foo function that calls `pcomplete-opt' with a string of
> length two or more. AFAICT, this doesn't occur in Emacs 28.
>
> Example from emacs -Q:
>
> 1. M-x eshell
> 2. type "gzip -" and hit TAB
> 3. type "h" -> wrong-type-argument // "h" gets inserted anyway
> 4. type TAB -> wrong-type-argument
This appears to have been fixed by
239db5d5162f6f9a4a6735e176c8d306f18e50e7
Author: Jim Porter <jporterbugs@gmail.com>
AuthorDate: Tue Sep 5 18:27:21 2023 -0700
Commit: Jim Porter <jporterbugs@gmail.com>
CommitDate: Tue Oct 10 13:00:38 2023 -0700
Follows: emacs-29.1 (168549)
Revert commits dafa6d6badd6 and 72c45fa9109a
These were there to work around deficiencies in how Eshell produces
completions for 'pcomplete-argument' (Eshell passed various non-string
objects to Pcomplete, which broke things). Now, Eshell always returns
a stringified form of the argument, with the original value stored via
the text property 'pcomplete-arg-value'.
* lisp/pcomplete.el (pcomplete-arg): Revert changes back to a simpler
form.
1 file changed, 7 insertions(+), 29 deletions(-)
lisp/pcomplete.el | 36 +++++++-----------------------------
Closing.
prev parent reply other threads:[~2024-01-18 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 2:08 bug#62474: 29.0.60; wrong-type-argument from pcomplete-opt J.P.
2024-01-18 23:18 ` J.P. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edee1b8t.fsf@neverwas.me \
--to=jp@neverwas.me \
--cc=62474-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.