From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history Date: Fri, 19 Jan 2024 08:48:51 +0100 Message-ID: <87eded2270.fsf@runbox.com> References: <87sf5ge0v6.fsf@runbox.com> <87a5pl1qym.fsf@runbox.com> <87y1d0p9ic.fsf@runbox.com> <874jfibkju.fsf@runbox.com> Reply-To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26177"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67000@debbugs.gnu.org, Eli Zaretskii To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 19 08:50:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQjdw-0006Zo-Nc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Jan 2024 08:50:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQjdb-0001o2-SR; Fri, 19 Jan 2024 02:50:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQjdZ-0001nj-IV for bug-gnu-emacs@gnu.org; Fri, 19 Jan 2024 02:50:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQjdY-0001NC-ON for bug-gnu-emacs@gnu.org; Fri, 19 Jan 2024 02:50:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rQjda-0002xB-GH for bug-gnu-emacs@gnu.org; Fri, 19 Jan 2024 02:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Jan 2024 07:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67000-submit@debbugs.gnu.org id=B67000.170565054711278 (code B ref 67000); Fri, 19 Jan 2024 07:50:02 +0000 Original-Received: (at 67000) by debbugs.gnu.org; 19 Jan 2024 07:49:07 +0000 Original-Received: from localhost ([127.0.0.1]:57380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQjch-0002vp-3x for submit@debbugs.gnu.org; Fri, 19 Jan 2024 02:49:07 -0500 Original-Received: from mailtransmit04.runbox.com ([2a0c:5a00:149::25]:58708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQjce-0002vK-IS for 67000@debbugs.gnu.org; Fri, 19 Jan 2024 02:49:05 -0500 Original-Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1rQjcW-004t2t-EF; Fri, 19 Jan 2024 08:48:56 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From; bh=Q614xSZE2oU9SPGB4H4QpoiaF4pUWCHS4HZw+24krho=; b=rJhpRz6nHyOYTtMEuaFYj1fHVh ArlCQNhslBbyYFZsR0w4uIQnh+YJNagEVPzHvoDl7QmrBOCOdacGYQUBHn+vUbaUheegphFZV/83P r6FAx+N6jNdQlBXg7eqREL2hO+zoCqIFDpC25pe02jVb/nGHo+mgvFAuA6zFcyLh1mvibxaPqZx2p iiDvKbQ1/kojcTwldMPgrlDvndxR+QEyLEWi5ldz9OEtkYjQk6tct9l2vy2CQfXESZAkjDvhIeTvP efcvlZnBbOYUM7iSdCQahp5qaG2Ufp0Iybof6BLbJTG0I80EjzaYY5+1VYDdHn/cUY93KBx/QjE8t 3w6l3Jug==; Original-Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1rQjcV-0007G4-OK; Fri, 19 Jan 2024 08:48:55 +0100 Original-Received: by submission03.runbox with esmtpsa [Authenticated ID (963757)] (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93) id 1rQjcT-002yNw-4G; Fri, 19 Jan 2024 08:48:53 +0100 In-Reply-To: (Stefan Kangas's message of "Sat, 13 Jan 2024 01:08:49 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278482 Archived-At: --=-=-= Content-Type: text/plain Stefan Kangas writes: > I'm not against adding a hook to `kill-emacs-hook', but it should be > added when you start IELM and not on top-level. We want to avoid any > side effects from merely loading a file. Fixed. > I don't think this will work in its current form either: AFAICT, > `comint-write-input-ring' saves it for the current buffer, and that's > not guaranteed to be the *ielm* buffer when `kill-emacs-hook' runs. > > So you'd want to first switch to that buffer, I think. It could also > have been renamed meanwhile, so I think you want to save the actual > buffer and not it's name (i.e. use `get-buffer'). Right, good catch. New attempt in the attached patch! --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-support-for-reading-writing-IELM-input-history.patch >From 738801b3126e78cf893d58e47fa156aeeec84cfc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= Date: Tue, 16 Jan 2024 08:21:41 +0100 Subject: [PATCH] Add support for reading/writing IELM input history * lisp/ielm.el (inferior-emacs-lisp-mode): Add support for reading/writing input history. (ielm--history-file-name): Name of the file to read/write IELM input history. (ielm--exit): Holds a function to call when Emacs is killed to write out the input history. (ielm--input-history-writer): Helper function for writing the IELM input history out to file. --- etc/NEWS | 11 +++++++++++ lisp/ielm.el | 29 +++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+) diff --git a/etc/NEWS b/etc/NEWS index 735a05f6579..b87ba93f456 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1254,6 +1254,17 @@ chat buffers use by default. *** New command 'customize-dirlocals'. This command pops up a buffer to edit the settings in ".dir-locals.el". +** IELM + +--- +*** IELM now remembers input history between sessions. + +--- +*** New variable 'ielm-history-file-name'. +If non-nil, name of the file to read/write IELM input history. Set to +nil to revert IELM to the old behavior of not remembering input +history between sessions. + * New Modes and Packages in Emacs 30.1 diff --git a/lisp/ielm.el b/lisp/ielm.el index 777aebb70cf..54da62c4359 100644 --- a/lisp/ielm.el +++ b/lisp/ielm.el @@ -110,6 +110,13 @@ ielm-dynamic-multiline-inputs such as `edebug-defun' to work with such inputs." :type 'boolean) +(defcustom ielm-history-file-name + (locate-user-emacs-file "ielm-history.eld") + "If non-nil, name of the file to read/write IELM input history." + :type '(choice (const :tag "nil" nil) + file) + :version "30.1") + (defvaralias 'inferior-emacs-lisp-mode-hook 'ielm-mode-hook) (defcustom ielm-mode-hook nil "Hooks to be run when IELM (`inferior-emacs-lisp-mode') is started." @@ -503,6 +510,17 @@ ielm--expand-ellipsis (funcall pp-default-function beg end) end)) +;;; Input history + +(defvar ielm--exit + "Function to call when Emacs is killed.") + +(defun ielm--input-history-writer (buf) + "Return a function writing IELM input history to BUF." + (lambda () + (with-current-buffer buf + (comint-write-input-ring)))) + ;;; Major mode (define-derived-mode inferior-emacs-lisp-mode comint-mode "IELM" @@ -605,6 +623,17 @@ inferior-emacs-lisp-mode #'ielm-indirect-setup-hook 'append t) (setq comint-indirect-setup-function #'emacs-lisp-mode) + ;; Input history + (setq-local comint-input-ring-file-name ielm-history-file-name) + (setq-local ielm--exit (ielm--input-history-writer (current-buffer))) + (setq-local kill-buffer-hook + (lambda () + (funcall ielm--exit) + (remove-hook 'kill-emacs-hook ielm--exit))) + (unless noninteractive + (add-hook 'kill-emacs-hook ielm--exit)) + (comint-read-input-ring t) + ;; A dummy process to keep comint happy. It will never get any input (unless (comint-check-proc (current-buffer)) ;; Was cat, but on non-Unix platforms that might not exist, so -- 2.39.2 --=-=-= Content-Type: text/plain -- Simen --=-=-=--