From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#65896: 30.0.50; folding text with text properties prevents background from extending past the newline Date: Thu, 25 Jan 2024 08:46:10 +0100 Message-ID: <87ede57t4t.fsf@gmail.com> References: <87ttrzmfua.fsf@strawberrytea.xyz> <8734z6xvsh.fsf@localhost> <83a5te74sa.fsf@gnu.org> <87fs352mdx.fsf@localhost> <83sf75401f.fsf@gnu.org> <871qep2l2z.fsf@localhost> <83pm293w0k.fsf@gnu.org> <87y1gx11vv.fsf@localhost> <83jzsh3uj8.fsf@gnu.org> <87ttrl0yt1.fsf@localhost> <87lecwrast.fsf@strawberrytea.xyz> <83edio4snm.fsf@gnu.org> <87jzsgr9jr.fsf@strawberrytea.xyz> <83cyy84143.fsf@gnu.org> <877cog80hc.fsf@strawberrytea.xyz> <87h6nj27s0.fsf@localhost> <83v8bz3hpq.fsf@gnu.org> <87r0ml9wk5.fsf@localhost> <87o7ddwhnm.fsf@localhost> <87r0i7eub6.fsf@gmail.com> <87ttn2el8x.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22364"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 65896-done@debbugs.gnu.org, look@strawberrytea.xyz To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 25 08:47:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSuSE-0005Y2-SG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jan 2024 08:47:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSuRw-0006ye-63; Thu, 25 Jan 2024 02:47:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSuRt-0006yP-7R for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 02:46:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSuRs-0003jd-KQ for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 02:46:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rSuRy-0001zo-4X for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 02:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 07:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65896 X-GNU-PR-Package: emacs Original-Received: via spool by 65896-done@debbugs.gnu.org id=D65896.17061687897625 (code D ref 65896); Thu, 25 Jan 2024 07:47:02 +0000 Original-Received: (at 65896-done) by debbugs.gnu.org; 25 Jan 2024 07:46:29 +0000 Original-Received: from localhost ([127.0.0.1]:47214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSuRR-0001yv-17 for submit@debbugs.gnu.org; Thu, 25 Jan 2024 02:46:29 -0500 Original-Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:53283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSuRM-0001yd-1Z for 65896-done@debbugs.gnu.org; Thu, 25 Jan 2024 02:46:27 -0500 Original-Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40eb033c1b0so45406905e9.2 for <65896-done@debbugs.gnu.org>; Wed, 24 Jan 2024 23:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706168772; x=1706773572; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HzsAxhJdEdO8DdHm/sZHKwbrhAxSVb8g096iMhRHvyY=; b=NOProYSQHxAqnIUhvOfFZBlepX1Gw4taD2i+zFE2JBg3dM9idQ1266gq8pYokofCyt gBXCYn9aDgv2XwsBO9ThX9Nh+lHDs9/R82Ul0MuxBdaH/t445BHZpnmgR/fLuDWrmMTN 9/JrwLOb0LEkJSxUoeev8ffU2K6Ks4qvZRyWWBGCz9dZNV1Gksp7VBtpU/FTUTJ2goF/ PJUTCrJK2XJu4aO6Dh5WeCrUdprP1gA+Yc8x1bUjlAFYlOoWBE27MTbamBytIGN7DFtW TbJcF1b15w22mp6ZROQg++MkAlv3UI1kvVOFASVlcQ1t7JVDGMg1wcs1QY42etzE9omz VNjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706168772; x=1706773572; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HzsAxhJdEdO8DdHm/sZHKwbrhAxSVb8g096iMhRHvyY=; b=Viar3ng1RFHi07VE9V+FcTWMTf80OEfN0kP1eNxyOhObw/4om+IiDCJUSdbY/D9ZSH 8pj2tN8CWhH2FtssLw060JMZN5KMKmk6WVQ0HakEuaPQYFxihHsW7E/NOWwXniaCrXyc EfH1jGT0ZmlTJRb0vnM0CJ1W0j6kfjNM4fIhBwvYLDnUKyzvgg83tUiXozK5YXyRCE98 xbrY259tgHsPrcUD5bJKojY4ctq+7IpjA2gVJDPUwC8Ur2dg1v2gm6EOsYh2DD771/GL KuT4ncsSnG33NUVbpYbj6wmdpg3rgnQucvm3OmFq4VxVPxnoq6pEpx/BD+2T44aEmqYp waZQ== X-Gm-Message-State: AOJu0Yx17pptnhnFZkIijVnU6fG477Jagh4aT7YuEQdudFJNg9r8kC21 TsAc2JX6v64ndkoFq/3JO864leiw5IXK/ZfvVhxJdBA20lUyqjFY X-Google-Smtp-Source: AGHT+IEiZVo6yEfJ7RQxxlorXBKrkRV/3bukgkUW6WTKkLM37LBilk4jytzCQppjHlQgczCSt8bHdA== X-Received: by 2002:a05:600c:45d3:b0:40e:7d24:cc15 with SMTP id s19-20020a05600c45d300b0040e7d24cc15mr239474wmo.34.1706168772136; Wed, 24 Jan 2024 23:46:12 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id i19-20020a05600c355300b0040e4a7a7ca3sm1556199wmq.43.2024.01.24.23.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 23:46:11 -0800 (PST) In-Reply-To: <87ttn2el8x.fsf@localhost> (Ihor Radchenko's message of "Wed, 24 Jan 2024 16:42:22 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278835 Archived-At: Ihor Radchenko writes: > K=C3=A9vin Le Gouguec writes: > >> Ihor Radchenko writes: >> >>> After several attempts, I found a way to handle faces in the trailing >>> newlines after folds without excessive changes in Org mode. >>> Fixed, on main. >>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D2ade1= 6bbc >> >> Neat. At first glance (including the subsequent fixup), it looks like >> outline.el could be taught the same trick, right? It would """just""" >> be a matter of finding the spot(s) that map to org-fold-core-region, and >> implementing equivalents to the org-fold-core helpers you leveraged >> (get-regions, get-folding-spec, get-region-at-point) if they don't exist >> already? > > Yes, it should be doable. > The equivalents would be overlay* functions. > Or outline.el can use org-fold-core to fold staff :) > org-fold-core has no major dependencies from Org libraries. Taking notes. That prompts further thoughts, but emacs-devel and/or emacs-orgmode would be better venues for them. For the purposes of this report, all that comes to mind is * You might have solved bug#52587? At least I can no longer reproduce using the recipe there (NB: the OP needs adjustments=C2=B9) after pulling your changes, 'make all', and 'emacs -Q -L lisp' from the Org repo=C2=B2. (Which means I could finally dispense with newlines between "#+end_" lines and headings =F0=9F=A5=B9) * Thank you so much for looking into this! =F0=9F=99=8F =C2=B9 As noted in the comments, the issue only comes up if you remove the newline between "#+end_quote" and "* baz"; also AFAICT modus-operandi no longer adds a background to org-block-*-line by default? So I had to theme that in manually to reproduce & test the fix. =C2=B2 Don't know if there is a "blessed" way to interactively test changes in the Org repo; thinking of e.g. magit's 'emacs-Q' target which reduces the chance of forgetting a step. FWIW I went in guns blazing with 'make -j8' and got screenfuls of version-mismatch warnings, so elected to take -j8 off; that seemed to make things quieter.