From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Add a function for building sort predicates Date: Thu, 01 Feb 2024 20:22:01 +0100 Message-ID: <87eddwuh0m.fsf@web.de> References: <87msskw1u8.fsf@web.de> <87eddw9k5o.fsf@daniel-mendler.de> <871q9wvz5p.fsf@web.de> <87bk909h7c.fsf@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31961"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen via "Emacs development discussions." To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 01 20:22:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVce7-00088w-Om for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Feb 2024 20:22:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVcdQ-0000a5-JY; Thu, 01 Feb 2024 14:22:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVcdO-0000YK-F4 for emacs-devel@gnu.org; Thu, 01 Feb 2024 14:22:02 -0500 Original-Received: from mout.web.de ([217.72.192.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVcdH-0000Sl-As for emacs-devel@gnu.org; Thu, 01 Feb 2024 14:22:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1706815297; x=1707420097; i=michael_heerdegen@web.de; bh=6uBwMN/OmATS8meFblRUL0IZOu6xRj5jcGxVACDvavw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=NXiotv/yeHmSY4Af2zR/3Ca76gWRKQCPuNLpjZyR1qb89aeb26m8IChefaFjkM2R fv8z/9LBYleBwpEufTZTAZBrs6eHjGnB7cLugjVCRYTCANwuid8tHCqbVzlQ17eoI xqNArIEtgEDX6z88P1mknDOZkIz9a7ha1dnFGAHJh2YyJCOtyyXBwLszWGXF5Sydu iLZXQiBvYR8Z5EzuyGIG3G7gHZOAeV1taxK/Pv6YGKIDV21MrdIzIYkyOHjts8kU4 CxyHg26gG3Ce179c9Z3eEbwaL7vWVeAZssk1yMEAn4wA33kXY9C/YPDQTaZOWq3Sk NpKDITWlx6x6EL4PSg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([178.6.28.230]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M2xvy-1rUVdV0KVw-003VHu; Thu, 01 Feb 2024 20:21:37 +0100 In-Reply-To: <87bk909h7c.fsf@daniel-mendler.de> (Daniel Mendler's message of "Thu, 01 Feb 2024 19:23:35 +0100") X-Provags-ID: V03:K1:Z3wchYmCRACi55gfVxIXi+ksanKK2A6NQYRKhStpgto9+8sIVZW VzYcSIu/RH9dAV8QGnN+v6zeV/xr/mTCoOGW1bQzmWxXrLv7L0Y+1ayLq0ArtkMuM10iKSL +RCE/pSddHnKLDisTjQDOgD2QzVfP/zyNultxH/TOMdxFxhAH0faqinnALGhum6cY2UAd/P 4+JXbZpOCtOtRMjhsbDxg== UI-OutboundReport: notjunk:1;M01:P0:ggUBaqdg2Ks=;hB97x+Ca8NqRIEJt0HyROTQB8vV ouv/0700ipQo8x7Oxe6J/E5IKFepyawJb5E3n6bdoSMLp6aB9Yl7Rtsd1M8jXGI4yTi4NeTJ4 Ac2MpGJkPEWEpbSEWFj5tF5wY6Kbq0PCCfhMe4N78427I0oDkNm9zRRkBqC4mowP4q4pehAWd B4UGE4C2Nlu74KgV47PRCrf26M3FYZoewzz5PcKSate2rPp9UbUMtu0EWRtY0RbMQGOTk9mTb tscFBKDDcKZPC2TenM6qPAbAi7wLCg8LnV3GXgato9ktgP+ucXzQ21YnV99tdhGgN9ypymUb4 sbaF3Bxqhk3E+m5i4Q3oZSbECWSg/wVb4NJYENyEID4GF/r9Wa5BLtJ54OopH6HcdN1rT+D4Q H1S1tVfusZ6C8PULd90AsJfH0rHwVLaK902+ZogyJMtxttS/oloqabkggGXLWCcV94Lg+n8d7 jojL6LUwIugzM4GJwvYmmbUu4tcakO0MlS75JMlbdBRZcWdhSBSiCT5qpRwczY/55cWy7yGB7 zKWWT0fhJ/NKucXQSs4RoXONfXMBmupnkeZTsw8tP2oD+vu1NsZnycPRWJdRU0/Z0pcm5hXiN fWLITB7gOQH2BhPo4Wz4wjnUxtfxw0i/xlv7+AL3T+J6A/IodkCWP+vNDpnUfj+P9eq++qhkI 4E021D1R2+DbeqTNUTqnuGdfpK/i+9V0Le3h2FiKxVuPLyAI/jG2mG592cCnAEGXYC87K1Ypa HlsVSicSBksG5/4c9w1CHLzOk5oXoK+AUXhcm/0446Ut0gwYJQWwL8rdC1B9VTZl04tSNSk8 Received-SPF: pass client-ip=217.72.192.78; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315717 Archived-At: Daniel Mendler writes: > Did you perform some measurements, comparing with the hand-written > predicate in package.el? The code does not look efficient with the > function calls and the throws. My version was around 6% slower. Using dynamic lookup of the key order. I did not try with native compiling. > In contrast, if the macro creates a sequence of conditions the native > compiler can optimize the result. It all depends on the use case. If > the rules are supposed to be customizable and the lists are short, the > dynamic approach will likely work well enough. For long lists an > efficient sort predicate makes a difference in my experience, e.g., in > a dynamically updating completion UI with thousands of candidates, > since the predicate is called very often. A disadvantage is that custom option will have to introduce new :set dependencies, I wanted to avoid that. But in some cases the speed difference might be worth such an optimization. If you want to experiment, please be my guest. Michael.