bug#68761: [PATCH] Record dependencies in packages installed via package-vc

bug#68761: [PATCH] Record dependencies in packages installed via package-vc

[Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 79 bytes --]


The dependency list wasn't getting recorded in the package's `-pkg.el` file.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1009 bytes --]

From edc9f75958d5feb2a82c53879e9dde4c51921bb6 Mon Sep 17 00:00:00 2001
From: Steven Allen <steven@stebalien.com>
Date: Sat, 27 Jan 2024 08:17:08 -0800
Subject: [PATCH] Record dependencies in packages installed via package-vc

* lisp/emacs-lisp/package-vc.el (package-vc--unpack-1): Record a
package's declared dependencies in the package's metadata ("-pkg.el").
---
 lisp/emacs-lisp/package-vc.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index db0cc515e46..fc402716dab 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -532,6 +532,7 @@ package-vc--unpack-1
                 (setq deps))))))
       (dolist (dep deps)
         (cl-callf version-to-list (cadr dep)))
+      (setf (package-desc-reqs pkg-desc) deps)
       (setf missing (package-vc-install-dependencies (delete-dups deps)))
       (setf missing (delq (assq (package-desc-name pkg-desc)
                                 missing)
-- 
2.43.0

bug#68761: [PATCH] Record dependencies in packages installed via package-vc

[Philip Kaludercic]

Steven Allen <steven@stebalien.com> writes:

> The dependency list wasn't getting recorded in the package's `-pkg.el` file.

Did you notice this because of some bug or what is the motivation for
this change?  I'll certainly look into it, I just wanted some context.

>>From edc9f75958d5feb2a82c53879e9dde4c51921bb6 Mon Sep 17 00:00:00 2001
> From: Steven Allen <steven@stebalien.com>
> Date: Sat, 27 Jan 2024 08:17:08 -0800
> Subject: [PATCH] Record dependencies in packages installed via package-vc
>
> * lisp/emacs-lisp/package-vc.el (package-vc--unpack-1): Record a
> package's declared dependencies in the package's metadata ("-pkg.el").
> ---
>  lisp/emacs-lisp/package-vc.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
> index db0cc515e46..fc402716dab 100644
> --- a/lisp/emacs-lisp/package-vc.el
> +++ b/lisp/emacs-lisp/package-vc.el
> @@ -532,6 +532,7 @@ package-vc--unpack-1
>                  (setq deps))))))
>        (dolist (dep deps)
>          (cl-callf version-to-list (cadr dep)))
> +      (setf (package-desc-reqs pkg-desc) deps)
>        (setf missing (package-vc-install-dependencies (delete-dups deps)))
>        (setf missing (delq (assq (package-desc-name pkg-desc)
>                                  missing)

bug#68761: [PATCH] Record dependencies in packages installed via package-vc

[Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> The dependency list wasn't getting recorded in the package's `-pkg.el` file.
>
> Did you notice this because of some bug or what is the motivation for
> this change?  I'll certainly look into it, I just wanted some context.

I noticed this because I tried to remove "unused" dependencies
(package-autoremove) and ended up removing dependencies from my
package-vc packages.

bug#68761: [PATCH] Record dependencies in packages installed via package-vc

[Philip Kaludercic]

Steven Allen <steven@stebalien.com> writes:

>>> The dependency list wasn't getting recorded in the package's `-pkg.el` file.
>>
>> Did you notice this because of some bug or what is the motivation for
>> this change?  I'll certainly look into it, I just wanted some context.
>
> I noticed this because I tried to remove "unused" dependencies
> (package-autoremove) and ended up removing dependencies from my
> package-vc packages.

That doesn't sound good.  Your patch should resolve the issue, and I
would be inclined to propose applying it to the Emacs 29 branch, if the
maintainers don't object.

bug#68761: [PATCH] Record dependencies in packages installed via package-vc

[Eli Zaretskii]

> Cc: 68761@debbugs.gnu.org
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Wed, 07 Feb 2024 07:18:33 +0000
> 
> Steven Allen <steven@stebalien.com> writes:
> 
> >>> The dependency list wasn't getting recorded in the package's `-pkg.el` file.
> >>
> >> Did you notice this because of some bug or what is the motivation for
> >> this change?  I'll certainly look into it, I just wanted some context.
> >
> > I noticed this because I tried to remove "unused" dependencies
> > (package-autoremove) and ended up removing dependencies from my
> > package-vc packages.
> 
> That doesn't sound good.  Your patch should resolve the issue, and I
> would be inclined to propose applying it to the Emacs 29 branch, if the
> maintainers don't object.

How serious is the problem?  Since it's unlikely there will be any
more Emacs 29.x releases, except if we have some emergency, we should
try to keep the release branch as safe and undiverged from 29.2 as
possible.

bug#68761: [PATCH] Record dependencies in packages installed via package-vc

[Philip Kaludercic]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: 68761@debbugs.gnu.org
>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Wed, 07 Feb 2024 07:18:33 +0000
>> 
>> Steven Allen <steven@stebalien.com> writes:
>> 
>> >>> The dependency list wasn't getting recorded in the package's `-pkg.el` file.
>> >>
>> >> Did you notice this because of some bug or what is the motivation for
>> >> this change?  I'll certainly look into it, I just wanted some context.
>> >
>> > I noticed this because I tried to remove "unused" dependencies
>> > (package-autoremove) and ended up removing dependencies from my
>> > package-vc packages.
>> 
>> That doesn't sound good.  Your patch should resolve the issue, and I
>> would be inclined to propose applying it to the Emacs 29 branch, if the
>> maintainers don't object.
>
> How serious is the problem?  Since it's unlikely there will be any
> more Emacs 29.x releases, except if we have some emergency, we should
> try to keep the release branch as safe and undiverged from 29.2 as
> possible.

I wouldn't clarify it as an emergency, at most a regrettable
inconvenience.

Just to avoid confusion: What branch is the current release branch then?

bug#68761: [PATCH] Record dependencies in packages installed via package-vc

[Eli Zaretskii]

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: steven@stebalien.com,  68761@debbugs.gnu.org
> Date: Wed, 07 Feb 2024 17:07:43 +0000
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Cc: 68761@debbugs.gnu.org
> >> From: Philip Kaludercic <philipk@posteo.net>
> >> Date: Wed, 07 Feb 2024 07:18:33 +0000
> >> 
> >> Steven Allen <steven@stebalien.com> writes:
> >> 
> >> >>> The dependency list wasn't getting recorded in the package's `-pkg.el` file.
> >> >>
> >> >> Did you notice this because of some bug or what is the motivation for
> >> >> this change?  I'll certainly look into it, I just wanted some context.
> >> >
> >> > I noticed this because I tried to remove "unused" dependencies
> >> > (package-autoremove) and ended up removing dependencies from my
> >> > package-vc packages.
> >> 
> >> That doesn't sound good.  Your patch should resolve the issue, and I
> >> would be inclined to propose applying it to the Emacs 29 branch, if the
> >> maintainers don't object.
> >
> > How serious is the problem?  Since it's unlikely there will be any
> > more Emacs 29.x releases, except if we have some emergency, we should
> > try to keep the release branch as safe and undiverged from 29.2 as
> > possible.
> 
> I wouldn't clarify it as an emergency, at most a regrettable
> inconvenience.

Then I tend to think this should be installed on master.

> Just to avoid confusion: What branch is the current release branch then?

It's still emacs-29.  When we start the release cycle of Emacs 30.1,
we will cut the emacs-30 branch.

The release branch is not closed to fixes, it just should receive only
very safe ones (like documentation fixes), or very urgent/serious
ones.

bug#68761: [PATCH] Record dependencies in packages installed via package-vc

[Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> I wouldn't clarify it as an emergency, at most a regrettable
>> inconvenience.
>
> Then I tend to think this should be installed on master.

I agree. Users will only run into it if they:

1. Use `package-vc` (very new and has quite a few sharp edges).
2. Use the "package-autoremove" feature.

Given that nobody else has reported this, it's probably not causing too
many issues.

bug#68761: [PATCH] Record dependencies in packages installed via package-vc

[Philip Kaludercic]

Steven Allen <steven@stebalien.com> writes:

>>> I wouldn't clarify it as an emergency, at most a regrettable
>>> inconvenience.
>>
>> Then I tend to think this should be installed on master.
>
> I agree. Users will only run into it if they:
>
> 1. Use `package-vc` (very new and has quite a few sharp edges).
> 2. Use the "package-autoremove" feature.
>
> Given that nobody else has reported this, it's probably not causing too
> many issues.

OK, I have applied the branch to master.

Thanks!

-- 
Philip Kaludercic