From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#66114: [PATCH] Fix interactive prompt for selecting checkout directory Date: Wed, 14 Feb 2024 16:54:15 +0000 Message-ID: <87eddfgf60.fsf@posteo.net> References: <87h6npfhoa.fsf@breatheoutbreathe.in> <87h6nmvcru.fsf@posteo.net> <87bkdsp2ns.fsf@breatheoutbreathe.in> <87lecvbpt4.fsf@posteo.net> <87v8bzi7iz.fsf@breatheoutbreathe.in> <877cjgvpjl.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14571"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66114-done@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 14 17:54:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1raIXA-0003Rm-TX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Feb 2024 17:54:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raIWz-0007EY-GE; Wed, 14 Feb 2024 11:54:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raIWy-0007EF-Ep for bug-gnu-emacs@gnu.org; Wed, 14 Feb 2024 11:54:44 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raIWy-00076m-76 for bug-gnu-emacs@gnu.org; Wed, 14 Feb 2024 11:54:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1raIXF-0005TG-Sr for bug-gnu-emacs@gnu.org; Wed, 14 Feb 2024 11:55:01 -0500 Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Feb 2024 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 66114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 66114@debbugs.gnu.org, philipk@posteo.net, joseph@breatheoutbreathe.in Original-Received: via spool by 66114-done@debbugs.gnu.org id=D66114.170792968321000 (code D ref 66114); Wed, 14 Feb 2024 16:55:01 +0000 Original-Received: (at 66114-done) by debbugs.gnu.org; 14 Feb 2024 16:54:43 +0000 Original-Received: from localhost ([127.0.0.1]:52933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raIWx-0005Se-9r for submit@debbugs.gnu.org; Wed, 14 Feb 2024 11:54:43 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:46659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raIWu-0005SP-N2 for 66114-done@debbugs.gnu.org; Wed, 14 Feb 2024 11:54:41 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7BA4E240104 for <66114-done@debbugs.gnu.org>; Wed, 14 Feb 2024 17:54:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707929656; bh=VtfDQsJFn4/vRyMnmTJANSMfC4SaLQbHttFtL/mm13I=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=K2oak402DbxnVFoaPr8O9IOyCypT9Falq3jTdVaq7DWGUYwSmwMFmf1FTMhcTX1l/ H2tzhelUBVqoBFGuNFhdT6skrr7ygpdXP7Dl1vpwZmI4L46MBrI2djXNA8whUbgAz0 U8p4YRV9i+hYyBWFFgRAICUl2XlcHiNBoJsRfUqwI+SnbTpipBO1iv13ksuAcMuu+L SMuNGUNWpP6C2aB9m1lEWq/UIvfiBu0yjn1ZRYyRNF4fHkJPVcDENmUaOh8bpUYF/o NvmxsK4PO7FRiwGMAln2rPBuhMDdYkgv5BHCE+QnF01pXeUaMckveLvndORmTTJ2Fg fqXWCRK3IhEwA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TZkn35Krhz9rxK; Wed, 14 Feb 2024 17:54:15 +0100 (CET) In-Reply-To: <877cjgvpjl.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Tue, 30 Jan 2024 00:42:21 -0800") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280019 Archived-At: Joseph Turner writes: > Joseph Turner writes: > >> Philip Kaludercic writes: >> >>> Joseph Turner writes: >>> >>>> However, the behavior of >>>> read-file-name is unspecified when a MUSTMATCH function returns nil: >>>> >>>> - a function, which will be called with the input as the >>>> argument. If the function returns a non-nil value, the >>>> minibuffer is exited with that argument as the value. >>>> >>>> Is this a bug, a case of under-documentation, or do I misunderstand something? >>>> >>>> I'm happy to post this in a separate bug thread if you think it's worth it. >>> >>> Perhaps that would be worth doing, that way the people who know more >>> about completion than I do would be more likely to see it and help >>> out. >> >> Okay, thanks! I'll do that. > > Now that #66187 > () > and bug#68815 > () > are fixed on emacs-29, I'm revisiting this issue. > > With the following patch, the interactive prompt in package-vc-checkout > now offers all directory for completion (empty or not), but only exits > when the minibuffer contains an empty directory or nonexistent filename. > > Testing this patch requires checking out emacs-29 after e6c82fe35e3. LGTM, I've pushed it to emacs-29. Thanks! > Thanks! > > Joseph