From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70868: 30.0.50; pp--insert-lisp prints small integers as characters Date: Tue, 28 May 2024 12:51:19 +0200 Message-ID: <87ed9mdxaw.fsf_-_@web.de> References: <663fb841.050a0220.ffcbb.b84f@mx.google.com> <86jzk019u0.fsf@gnu.org> <86h6f419mi.fsf@gnu.org> <87v83jozi7.fsf@web.de> <86ikzjysrh.fsf@gnu.org> <87r0e7oyct.fsf@web.de> <86frunyr3o.fsf@gnu.org> <87h6f2q4sa.fsf@web.de> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34467"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Stefan Monnier , iarchivedmywholelife@gmail.com To: 70868-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 28 12:51:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBuQ9-0008mB-NY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 May 2024 12:51:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBuPu-0007aE-QN; Tue, 28 May 2024 06:50:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBuPt-0007Zp-Hg for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 06:50:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBuPt-00034P-80 for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 06:50:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBuQ2-0008AQ-7Y for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 06:51:02 -0400 Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 May 2024 10:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70868 X-GNU-PR-Package: emacs Mail-Followup-To: 70868@debbugs.gnu.org, michael_heerdegen@web.de, iarchivedmywholelife@gmail.com Original-Received: via spool by 70868-done@debbugs.gnu.org id=D70868.171689345731378 (code D ref 70868); Tue, 28 May 2024 10:51:01 +0000 Original-Received: (at 70868-done) by debbugs.gnu.org; 28 May 2024 10:50:57 +0000 Original-Received: from localhost ([127.0.0.1]:45748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBuPw-0008A2-Q9 for submit@debbugs.gnu.org; Tue, 28 May 2024 06:50:57 -0400 Original-Received: from mout.web.de ([217.72.192.78]:35653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBuPv-00089o-2v for 70868-done@debbugs.gnu.org; Tue, 28 May 2024 06:50:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1716893434; x=1717498234; i=michael_heerdegen@web.de; bh=JOwRK6O9a3TcY8ECwVmzklJYP4rJ3+mko108GHLLRGY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=cJhdVCPoCU1V6JFYbM7b6JEAj4VvVI2IINUMHFdI635OZpPzt4ytcsYc8DWUAkV9 o5P97xHrminjOFJfrNJ3KawcAuXQk5lYySfnc6r50Yr5zwDz1MCpcI+HuWFh57Dbx jaEfJ/l0M2Q/eQAzqPOonmVtfcR6jaOk6tcxefnmPT8/+A4l8ZDZ9//acRJGGJQLl 7fQ/CHoFl7FmZLrJ3sdE79He67AuwOvWl92ZDUsvDYIYpskkXUs40szv7/2AGRkwJ 9vZ5RQ5zoe7dOGO4oUpV0kZ+MXQB3PCYvnlCrMx5qlV4B3kLkaxCC0IN3sxce+uAD A9tN0GMrEg7dYBdvug== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.113]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N4vNe-1sb6C60dU4-00vRe8; Tue, 28 May 2024 12:50:34 +0200 In-Reply-To: <87h6f2q4sa.fsf@web.de> (Michael Heerdegen's message of "Sun, 12 May 2024 20:11:17 +0200") X-Provags-ID: V03:K1:t5pwiw+bSWDMR2pe4UUYJMMzrbzFk8s03uQs+VAM0++qiLOyn8g bYaXkbLq5yRf38gNc+QZJwe6vgRoXVUes9okuMWhOqY9HK/9RgdPXgQZNOkInahzHrc3xau HdhoixznK8G6o4umVC0FAzVET8Cu0boHWcd6Cp9HTF3MPr2cHmVOhdBdS4ELTTM8Xb5YnA7 12DG55paGp+r4Tk8dtD1Q== UI-OutboundReport: notjunk:1;M01:P0:snNx8liOdk0=;27r0b1VXoRn7cDkMyMi6vBGYfW9 NILkjh4yqpCEO9Gm2IFK+igV+1wSHV/zbkUJgu0FGr8pboFDyyg3HjGoFUScdOo7jmbUOuSU+ yN0s25c8GCHYnDjzob/JIkyopPo0AB6bFH/ea3naVouJmkWb01mOxBhwx5HS+zlXjrmzK9QEl QCiQh5tOJTXumTL32lzWKApPiuFQHrms8nedm5HRyFvJgNKGBkQepj4CQWaP0+iLCwp12tk9V dicyrOLio0nRQiXu6LgIH7Tz2KjVJvBRVnH19Xv4vKbJjkl8Ght5kEb63gEb7YkehByeMPhdj H8w+rhBDxRIsO8ynh1LMmxQ8xplkJ57xkYT9Bl426DDDUlWhzdXos/kKaLucLhvp0W44/CLpj EvqyZ7yLD0zxg07QVOAC3efIOIVLMySa9YfSDG9CE/cyzxHeVc6zYck0nQ19ZAx37YHFwLrnj NEkwRBH31DWVoyVXtntRDe24EQANbo43jaDwTrO/CO0Xi7bDbw54xFAlHpSPj0p1RzTVpVICl LyrWZ06+EbWFo9YAo5YgSA5vJgY7ic117Y1Tfdv/iEdzcSINTBwj3fIzC6NMv/ARPN2BjMkFl 1dkzT8l4dFTjS+ysWgTEP6vk8kdSE9A7DyjGvfrIsrN2J0LrEbK5MHlGqryVttWpmwx1T8qhd jJ1rs4CVQpM91RkNzJO6djaoa6eK8YfLorBY3zQp5sVsPYE0ym7LRa6cMjxv9QaoN8XtiiswD Oi8tPcwLJajYfZmtonnGs9wHVMXqvNhPKImwDvshKcuXsdm5ZYbtEiHnuREJNjiN5/kzKA+8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286082 Archived-At: --=-=-= Content-Type: text/plain Hello again, I have committed our fix now and close this bug report since we are done. Thanks to everybody. While I was at it I found a branch in the algorithm where we printed an arbitrary non-list cons using `prin1' for no reason. Since we have everything in pp to pretty-print any list and cons, I fixed that: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-let-pp-fall-back-to-prin1-for-conses.patch Content-Transfer-Encoding: quoted-printable =46rom 804f36d5abdbc38a4664a341aaea563195f79b03 Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Sun, 26 May 2024 16:31:26 +0200 Subject: [PATCH] Don't let pp fall back to prin1 for conses * lisp/emacs-lisp/pp.el (pp--insert-lisp): Don't `prin1' non-list conses; use our pp function for cons and list printing `pp--format-list' instead. =2D-- lisp/emacs-lisp/pp.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/pp.el b/lisp/emacs-lisp/pp.el index 3176ee42533..e550bd4d689 100644 =2D-- a/lisp/emacs-lisp/pp.el +++ b/lisp/emacs-lisp/pp.el @@ -491,7 +491,7 @@ pp--insert-lisp (pp--insert-lisp (cadr sexp))) (pp--format-list sexp)))) (t - (prin1 sexp (current-buffer))))) + (pp--format-list sexp)))) ;; Print some of the smaller integers as characters, perhaps? (integer (if (<=3D ?0 sexp ?z) =2D- 2.39.2 --=-=-= Content-Type: text/plain Michael. --=-=-=--