From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: : : master 7f97cf31dc3: Create blessmail at build time instead of install time Date: Sun, 25 Aug 2024 04:50:12 +0200 Message-ID: <87ed6d2u57.fsf@web.de> References: <172441424046.32730.1198862680597856819@vcs2.savannah.gnu.org> <20240823115720.C4A92C1FB72@vcs2.savannah.gnu.org> <87y14n77sd.fsf@protonmail.com> <87bk1js9gm.fsf@gmail.com> <87ttfb75oh.fsf@protonmail.com> <877cc7rzo7.fsf@gmail.com> <877cc65a55.fsf@protonmail.com> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:XrtUi7SrD0Kx9CQsxR2hMa44VEA= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 25 04:50:17 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1si3Ka-0000Qg-RD for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Aug 2024 04:50:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1si3Js-0002mX-6O; Sat, 24 Aug 2024 22:49:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1si3Jq-0002mK-9H for emacs-devel@gnu.org; Sat, 24 Aug 2024 22:49:30 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1si3Jo-0003uS-Ng for emacs-devel@gnu.org; Sat, 24 Aug 2024 22:49:30 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1si3Jl-000AKp-7f for emacs-devel@gnu.org; Sun, 25 Aug 2024 04:49:25 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323113 Archived-At: Pip Cet writes: > +(defun blessmail-command (string) > + (if (and (boundp 'blessmail-doit) > + blessmail-doit) > + (shell-command string) > + (message (concat " " string)))) Better (message "%s" ...) maybe? But my main point is: > + (unless (= ?w (aref modes 8)) > + (message (concat "Assuming %s is really the mail spool directory, you should\n" > + "run the following commands as root, to give %s\n" > + "appropriate permissions:\n") > + dirname (file-name-nondirectory movemail-path)) > + (cond > + ((= ?w (aref modes 5)) > + (blessmail-command > + (concat "chgrp " (number-to-string (file-attribute-group-id attr)) > + " " movemail-path " && chmod g+s " movemail-path))) > + ((= ?w (aref modes 2)) > + (blessmail-command > + (concat "chown " (number-to-string (file-attribute-user-id attr)) > + " " movemail-path " && chmod u+s " movemail-path))) > + (t > + (blessmail-command > + (concat "chown root " movemail-path " && chmod u+s " movemail-path))))) > + (message "\nDo that after running make install."))) > (kill-emacs) Not an expert for shell stuff, but: wouldn't this cause trouble for people using a non-posix compliant shell, like the popular fish shell? AFAIU this will be called before the user can even set `shell-file-name'. Michael.