From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#64055: [WIP Patch] Enable editing commit messages - vc-git-modify-change-comment Date: Sun, 20 Oct 2024 16:42:54 +0800 Message-ID: <87ed4brwq9.fsf@melete.silentflame.com> References: <87legmnq4l.fsf@gmail.com> <87r090o8cl.fsf@melete.silentflame.com> <874j5vgypf.fsf@melete.silentflame.com> <787fb692-db24-4682-871b-5a52d31a1249@gutov.dev> <87ed4obs1b.fsf@melete.silentflame.com> <87o73sad24.fsf@melete.silentflame.com> <877ca63ln5.fsf@melete.silentflame.com> <86r08enfri.fsf@gnu.org> <87cyjyvsns.fsf@melete.silentflame.com> <868qulojrx.fsf@gnu.org> <87zfn1vjvb.fsf@melete.silentflame.com> <864j59ob91.fsf@gnu.org> <87ldyjvbgz.fsf@melete.silentflame.com> <86h697jrpu.fsf@gnu.org> <87plnvtk88.fsf@melete.silentflame.com> <86bjzfjofn.fsf@gnu.org> <87zfmzs0mp.fsf@melete.silentflame.com> <868qujjid8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15739"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Morgan.J.Smith@outlook.com, rpluim@gmail.com, 64055@debbugs.gnu.org, control@debbugs.gnu.org, dmitry@gutov.dev To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 20 10:44:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2RXu-0003yM-9Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Oct 2024 10:44:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2RXM-000499-A0; Sun, 20 Oct 2024 04:43:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2RXG-00048E-DQ for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 04:43:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2RXE-0000xE-Vy for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 04:43:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=zaHulqPs10DgOf8/y5CVG+dRmfDZphesiPZSHWN71jo=; b=dABA629zykd5Dga9N37demzGC/Yq5xIUxCO+w4nIeVPD0hkTJw7uluoiGWMUAu5Cw0EC6YdQCbmqlRWATXm5qeucywg3r017Mss08doWiywrsfh5wYsQCfPTiSqT0b8X6JErNCwJEV2gWhuZNdw08/dK+Bp0AYvPhpa6D5fCFQ5/kUHf7X9E+CKNP31KcQ0exgf3MqO2xhR16acbxyaCqJ6xv4ZQaDTk8jdkm4haecuZfMYlnjh6/iRYPBSqe4hHvU5gd2UWyzZoLbQfQTgwCV3E1t857zuB9RF6iEH3qh5ZuCGCoCm74UBvacQGnMeEMnfmEetyKP9MMxWxwbuEYQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2RXd-0002sW-Og for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 04:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2024 08:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.172941381511009 (code B ref 64055); Sun, 20 Oct 2024 08:44:01 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 20 Oct 2024 08:43:35 +0000 Original-Received: from localhost ([127.0.0.1]:45731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2RXD-0002rV-G1 for submit@debbugs.gnu.org; Sun, 20 Oct 2024 04:43:35 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:39418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2RXB-0002rG-6T for 64055@debbugs.gnu.org; Sun, 20 Oct 2024 04:43:34 -0400 DKIM-Signature: a=rsa-sha256; b=D/pnHt6eS4PAdU9P02f4g0z2tZoI6D+GygeyUD8GwUl+Bs69ARidxNvWsBGIsqPy4lJ6G9jUmrj98BkVdFcKwmQqN9uNTxY9igkOd4MkDcvTn8ODVxsSlqQoCC4GdRsbAsYph2CHJr0p0rB2u5MpfQzudzxEpMZaWfOgOzef1UvRmeZ32PpxGFsx2Y1K18a1StCOvlPYJTkdTg4SvtpuMQfk2r9WMsJxu1nVlFPqpC9pap8xjvZmpEe9vo0TBETZOSVzyxjWkusuexh3RLnYgqTuSiu1PuytvRHxNYXbj0j1M68iFEsfR6P0pgPQH3f/xW60HQzdS8CgzlhR2r++Ig==; s=purelymail1; d=spwhitton.name; v=1; bh=Uzn8qZojcxKHNXe9Xvxxf2kBhfXdizIVhdx3nzH3n3M=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=CNg5Nu2XoKiMhKWJ6Lud9ajsIAE+jyD1ELA6A51+ifOqAOvL90QdHt1YZCHpRab1z2zSHRFcCUFYHp3yVI6SuLQDqY7sNyx6pBEzEbPlnONuhhjTMGnPwZKb3xu6CNbm9Clq8qeyTw/BTtPZD8uwF/WBh47+NrXjP1qTjsWEkUhp7YDbn81j8hJTMsokhD6z1aJIdgAHyPDD9kGjkifuwthejznk1cazqDZzz5M3MKjT4CMS8F/2vHSRoh5br39sPBHGOkln2ng3P0NMTk9CV1jTIGoR3MxAD9/c8WTGPXwoo5afhVXU1NDy8KFf7IzlCf3K+kpb4zBomrA7KhESsA==; s=purelymail1; d=purelymail.com; v=1; bh=Uzn8qZojcxKHNXe9Xvxxf2kBhfXdizIVhdx3nzH3n3M=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 64055@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1738419589; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 20 Oct 2024 08:42:58 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 4A85A7E086F; Sun, 20 Oct 2024 16:42:54 +0800 (CST) In-Reply-To: <868qujjid8.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Oct 2024 11:20:19 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293937 Archived-At: retitle 64055 31.0.50; log-view-modify-change-comment support for Git and Hg thanks On Sun 20 Oct 2024 at 11:20am +03, Eli Zaretskii wrote: > I consider this change incomplete until we add that support at least > for Hg. Fair enough. I'm retitling the bug. And after I install the change to vc-git.el, I won't close this bug. >> > In any case, the reason for having a backend method should be >> > explained in the comments. >> >> I've added a FIXME pointing to this bug. Is there somewhere else you >> have in mind? > > I don't see it; did you forget to push? I did push it. > In any case, I prefer an explicit explanation, including the reference > to the vc-*-log-switches variables, not just a reference to a bug > number. Added a second FIXME regarding modern VCS. -- Sean Whitton