From: Ihor Radchenko <yantar92@posteo.net>
To: Jack Kamm <jackkamm@gmail.com>
Cc: emacs-orgmode@gnu.org, matt@excalamus.com, jeremiejuste@gmail.com
Subject: Re: [PATCH] Async sessions: Fix prompt removal regression in ob-R
Date: Tue, 22 Oct 2024 17:16:52 +0000 [thread overview]
Message-ID: <87ed4812ij.fsf@localhost> (raw)
In-Reply-To: <8734koert4.fsf@gmail.com>
Jack Kamm <jackkamm@gmail.com> writes:
> Great, thanks. I'm attaching an updated patch with the more explicit
> cond clause, and rebased onto latest bugfix. I also attach a second
> patch with the NEWS entry on main.
Thanks!
> + (t (error (format "Unrecognized prompt handling behavior %s"
> + (symbol-name prompt-handling))))))
I think that `symbol-name' is unnecessary here.
It will lead to cryptic error if PROMPT-HANDLING happens to be something
that is not symbol (for example, a number)
> +*** ~org-babel-comint-async-register~: Added argument to specify prompt handling
Maybe "New optional argument controlling prompt handling"
> +The new argument ~prompt-handling~ allows Babel languages to specify
> +how prompts should be handled when passing output to
> +~org-babel-comint-async-chunk-callback~. If equal to
> +~filter-prompts~, prompts are removed beforehand, similar to the
similar -> same (or did I miss something?)
> +default behavior of ~org-babel-comint-with-output~. If equal to
> +~disable-prompt-filtering~, then the prompt filtering is skipped. If
> +unset, then the default behavior is the same as ~filter-prompts~ for
> +backwards compatibility.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-10-22 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 21:45 [PATCH] Async sessions: Fix prompt removal regression in ob-R Jack Kamm
2024-10-02 17:05 ` Ihor Radchenko
2024-10-15 7:03 ` Jack Kamm
2024-10-19 7:58 ` Ihor Radchenko
2024-10-20 7:01 ` Jack Kamm
2024-10-20 9:34 ` Ihor Radchenko
2024-10-22 3:32 ` Jack Kamm
2024-10-22 17:16 ` Ihor Radchenko [this message]
2024-10-28 2:55 ` Jack Kamm
2024-10-28 17:16 ` Ihor Radchenko
2024-11-02 0:19 ` Jack Kamm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed4812ij.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=jackkamm@gmail.com \
--cc=jeremiejuste@gmail.com \
--cc=matt@excalamus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.