all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Howard Melman <hmelman@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 74111@debbugs.gnu.org
Subject: bug#74111: [PATCH] New `tmm-menubar' shortcut display style
Date: Fri, 01 Nov 2024 18:34:04 +0100	[thread overview]
Message-ID: <87ed3u2703.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <lysesbghe5.fsf@gmail.com> (Howard Melman's message of "Fri, 01 Nov 2024 10:25:54 -0400")

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

Howard Melman <hmelman@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> I'd rephrase the last sentence like this:
>>
>>   When non-nil, the first menu-entry's character that acts as a
>>   shortcut will be highlighted with the `highlight' face to help
>>   identifying it.
>
> That should be "to help identify it."
>
> I think this would be a little better:
>
>     When non-nil, the first menu-entry's character that acts as a
>     shortcut is displayed with the `highlight' face to help identify
>     it.

Thanks.  Here's a fix to apply on master.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-tmm-shortcut-inside-entry-docstring-fix.patch --]
[-- Type: text/x-patch, Size: 962 bytes --]

From 44520536c998d4cad90f4e5fc1dca5aba28afa53 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Fri, 1 Nov 2024 18:30:40 +0100
Subject: [PATCH] `tmm-shortcut-inside-entry' docstring fix

* lisp/tmm.el (tmm-shortcut-inside-entry): Docstring fix.
---
 lisp/tmm.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/tmm.el b/lisp/tmm.el
index 80991b246b6..eeea1cf20be 100644
--- a/lisp/tmm.el
+++ b/lisp/tmm.el
@@ -111,8 +111,8 @@ tmm-shortcut-words
 (defcustom tmm-shortcut-inside-entry nil
   "Highlight the shortcut character in the menu entry's string.
 When non-nil, the first menu-entry's character that acts as a shortcut
-will be highlighted with the `highlight' face to help identifying it.
-The `tmm-mid-prompt' string is not used then."
+is displayed with the `highlight' face to help identify it.  The
+`tmm-mid-prompt' string is not used then."
   :type 'boolean)
 
 (defface tmm-inactive
-- 
2.47.0


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud

      reply	other threads:[~2024-11-01 17:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 16:35 bug#74111: [PATCH] New `tmm-menubar' shortcut display style Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31  9:46 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 10:04 ` Eli Zaretskii
2024-10-31 10:28   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 10:50     ` Eli Zaretskii
2024-10-31 11:48       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 14:25         ` Eli Zaretskii
2024-10-31 16:04           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 16:57             ` Eli Zaretskii
2024-10-31 22:07               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-01  7:16                 ` Eli Zaretskii
2024-11-01  9:31                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-01 12:11                     ` Eli Zaretskii
2024-11-01 14:25                   ` Howard Melman
2024-11-01 17:34                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed3u2703.fsf@ledu-giraud.fr \
    --to=bug-gnu-emacs@gnu.org \
    --cc=74111@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=hmelman@gmail.com \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.