From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: Adding git-commit highlight mode? Date: Fri, 03 Jan 2025 21:02:21 +0000 Message-ID: <87ed1j8vc2.fsf@zephyr.silentflame.com> References: <37733be4476e1c2b6e873c967c79cb0035959a9e.camel@yandex.ru> <86wmfdhwg7.fsf@gnu.org> <0347118b217c57e4e62018547883fad5f1d1e63e.camel@yandex.ru> <86r05lht77.fsf@gnu.org> <875xmwykuk.fsf@aarsen.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7869"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: Stefan Kangas , Arsen =?utf-8?Q?Arsenovi=C4=87?= , Eli Zaretskii , Konstantin Kharlamov , emacs-devel@gnu.org, Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 03 22:03:28 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTopL-0001tB-9O for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Jan 2025 22:03:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTooc-00075b-VF; Fri, 03 Jan 2025 16:02:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tToob-00075R-DS for emacs-devel@gnu.org; Fri, 03 Jan 2025 16:02:41 -0500 Original-Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTooZ-0004pP-J7 for emacs-devel@gnu.org; Fri, 03 Jan 2025 16:02:41 -0500 DKIM-Signature: a=rsa-sha256; b=hqQdu/5UZRD+/kgQdohwEOERJ6bHji+1g8qu8ZUZblkheXPEQ7rut2ikv2pbbEec5RepKZ9m12O2njpo43JKCrfGgrxLMQcXxRp5a8MkXnGpJBlrbcdWGezt6gxBYEdnUbnfVP3r2KyG2VVW4YtZXGx0B+Zq1Ltjwg5CTBiN+D+nSEqzKKtrI3fC1K/cS6bgkFUqY5K8w1KQzjDMr4Yu+kqMoiNaFcABH5vLKgFTgl26i6hN4l4Co+ruiVeT1Hlvk1QLUnv1l4E5hHhcB0isTNX3zK53zAuQT3VIigbvuqb/H/X4l+a6kKb4l/1Nq2vXs+ie5Pd+XBx3fh+pOY8IKw==; s=purelymail3; d=spwhitton.name; v=1; bh=Vn0tVFiN5nFDDhY+roCnK9/MFxSC7dELRWEm0S3bN44=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=K+38u6Gt8NBeQLO+YmUVv1WX+cIgvl/L/Vv//SBxSZMKo/liTUZ3uRqohMqHUniQHAJdOwqzTWN4/l4Xn11QtZjiUdzILPUhGEVokoxgL12XI0Blu3JAHowcj1WZzY5ly1DrrAgUjE46i/pWvD3wvKZachGZwtQP3AU0zbxdMh8V4rxhkjVF2gLo5LAcnIVPcNwgcEnfGwMypGVEoy1GrF6cUhCPEYqiutRzTbyLhxqgEPtRQpe+IsvYLFRK9iYG6kJhk7OwAMQQ+2Ru1gEs3kUkovmI4ACItyl6Oy1scD8Sl33EF1hr9o23eAjOMEOSEi1KYEcgl4tjinh4x7UWsQ==; s=purelymail3; d=purelymail.com; v=1; bh=Vn0tVFiN5nFDDhY+roCnK9/MFxSC7dELRWEm0S3bN44=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 717646512; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 03 Jan 2025 21:02:22 +0000 (UTC) Original-Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 4729994A6EC; Fri, 3 Jan 2025 21:02:21 +0000 (GMT) In-Reply-To: (Stefan Kangas's message of "Thu, 2 Jan 2025 15:53:29 -0600") Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327637 Archived-At: Hello, On Thu 02 Jan 2025 at 03:53pm -06, Stefan Kangas wrote: > AFAICT, the 50 character line limit for the summary line is not really > followed very strictly in practice by most projects, including the Linux > kernel. It's more of a recommendation. Even the link you provide above > says that it's "a good idea" to use "no more than 50 characters" for it. > For that reason, I think that this should be a warning (with a highlight > if you go over), and not a hard limit. > > In `git-commit-mode`, the user option `git-commit-summary-max-length' is > 68 by default, which strikes me as unopinionated enough. As Jonas mentioned, some of the things suggested in this thread overlap with our existing vc-git-log-edit-mode. For example, we already have vc-git-log-edit-summary-target-len and vc-git-log-edit-summary-max-len. I haven't looked at your code, Jim, but hopefully it could avoid too much reimplementation/crossover with vc-git-log-edit-mode if we are going to put it in emacs.git. I will happily review what you'd actually like to include. (As the VC maintainer, I would have appreciated being CC'd on this thread at some point; glad I caught it anyway.) -- Sean Whitton